dsmiley commented on code in PR #3209:
URL: https://github.com/apache/solr/pull/3209#discussion_r1969009364


##########
solr/core/src/java/org/apache/solr/response/PrometheusResponseWriter.java:
##########
@@ -47,12 +47,15 @@
  * org.apache.solr.handler.admin.MetricsHandler}
  */
 @SuppressWarnings(value = "unchecked")
-public class PrometheusResponseWriter extends RawResponseWriter {

Review Comment:
   @mlbiscoc why did you choose RawResponseWriter?  It's a very special 
QueryResponseWriter and I don't see that the this response writer utilizes it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to