Re: [PR] SOLR-8282: Switch CoreContainer#getSolrHome to return Path instead of String [solr]

2025-02-21 Thread via GitHub
mlbiscoc commented on code in PR #3204: URL: https://github.com/apache/solr/pull/3204#discussion_r1966047995 ## solr/core/src/java/org/apache/solr/core/ZkContainer.java: ## @@ -87,7 +87,7 @@ public void initZooKeeper(final CoreContainer cc, CloudConfig config) { // TODO: r

Re: [PR] fix the solr zk invocation [solr-operator]

2025-02-21 Thread via GitHub
HoustonPutman commented on PR #756: URL: https://github.com/apache/solr-operator/pull/756#issuecomment-2675380584 We also desperately need integration tests for the basic auth stuff. Our biggest testing gap -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] SOLR-8282: Switch CoreContainer#getSolrHome to return Path instead of String [solr]

2025-02-21 Thread via GitHub
AndreyBozhko commented on code in PR #3204: URL: https://github.com/apache/solr/pull/3204#discussion_r1966064254 ## solr/core/src/java/org/apache/solr/core/ZkContainer.java: ## @@ -87,7 +87,7 @@ public void initZooKeeper(final CoreContainer cc, CloudConfig config) { // TOD

Re: [PR] SOLR-8282: Switch CoreContainer#getSolrHome to return Path instead of String [solr]

2025-02-21 Thread via GitHub
epugh commented on code in PR #3204: URL: https://github.com/apache/solr/pull/3204#discussion_r1966069823 ## solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java: ## @@ -145,7 +145,7 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp

Re: [PR] fix the solr zk invocation [solr-operator]

2025-02-21 Thread via GitHub
HoustonPutman commented on PR #756: URL: https://github.com/apache/solr-operator/pull/756#issuecomment-2675378459 Yeah, this will need a bug fix release probably -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] SOLR-8282: Switch CoreContainer#getSolrHome to return Path instead of String [solr]

2025-02-21 Thread via GitHub
AndreyBozhko commented on code in PR #3204: URL: https://github.com/apache/solr/pull/3204#discussion_r1966067522 ## solr/solrj/src/test/org/apache/solr/client/solrj/request/TestCoreAdmin.java: ## @@ -80,7 +80,7 @@ public void testCustomUlogDir() throws Exception { cores.g

Re: [PR] SOLR-17677: Ensure DBQ is safe before running [solr]

2025-02-21 Thread via GitHub
gerlowskija commented on PR #3203: URL: https://github.com/apache/solr/pull/3203#issuecomment-2675454565 Alright - looks like that was a problem on the 'main' I was based on - there was a revert on main and I've rebased on that now. Should be good to go. -- This is an automated mes

[jira] [Created] (SOLR-17680) Unable to create Dimensional Routed Alias(DRA)

2025-02-21 Thread Marcel Gawron (Jira)
Marcel Gawron created SOLR-17680: Summary: Unable to create Dimensional Routed Alias(DRA) Key: SOLR-17680 URL: https://issues.apache.org/jira/browse/SOLR-17680 Project: Solr Issue Type: Bug

Re: [PR] SOLR-8282: Switch CoreContainer#getSolrHome to return Path instead of String [solr]

2025-02-21 Thread via GitHub
epugh commented on code in PR #3204: URL: https://github.com/apache/solr/pull/3204#discussion_r1965992291 ## solr/core/src/java/org/apache/solr/core/ZkContainer.java: ## @@ -87,7 +87,7 @@ public void initZooKeeper(final CoreContainer cc, CloudConfig config) { // TODO: remo

Re: [PR] SOLR-8282: Switch CoreContainer#getSolrHome to return Path instead of String [solr]

2025-02-21 Thread via GitHub
epugh commented on code in PR #3204: URL: https://github.com/apache/solr/pull/3204#discussion_r1965995115 ## solr/solrj/src/test/org/apache/solr/client/solrj/request/TestCoreAdmin.java: ## @@ -80,7 +80,7 @@ public void testCustomUlogDir() throws Exception { cores.getAllow

Re: [PR] in tests replace deprecated IndexSearcher.doc() calls [solr]

2025-02-21 Thread via GitHub
cpoerschke merged PR #3149: URL: https://github.com/apache/solr/pull/3149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

[jira] [Updated] (SOLR-17680) Unable to create Dimensional Routed Alias(DRA)

2025-02-21 Thread Marcel Gawron (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Gawron updated SOLR-17680: - Affects Version/s: 9.7 (was: 9.7.0) > Unable to create Dimensional Rou

Re: [PR] SOLR-17677: Ensure DBQ is safe before running [solr]

2025-02-21 Thread via GitHub
gerlowskija commented on PR #3203: URL: https://github.com/apache/solr/pull/3203#issuecomment-2674963541 Check and tests pass for me locally. The `precommit` PR check fails with the error below, but this is almost certainly unrelated to the PR. Will investigate a bit though to see if

[jira] [Updated] (SOLR-8282) Move Java APIs to NIO2 (Path), and ban use of java.io.File

2025-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-8282: - Labels: pull-request-available (was: ) > Move Java APIs to NIO2 (Path), and ban use of java.io.Fi

[PR] SOLR-8282: Switch CoreContainer#getSolrHome to return Path instead of String [solr]

2025-02-21 Thread via GitHub
AndreyBozhko opened a new pull request, #3204: URL: https://github.com/apache/solr/pull/3204 https://issues.apache.org/jira/browse/SOLR-8282 # Description This is only a part of SOLR-8282, prompted by the comment here: https://github.com/apache/solr/pull/3146#discus

[jira] [Resolved] (SOLR-17675) Remove DirContext param from DirectoryFactory create method

2025-02-21 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved SOLR-17675. --- Fix Version/s: main (10.0) Resolution: Fixed > Remove DirContext param from DirectoryF

Re: [PR] Fix race condition in TestThinCache [solr]

2025-02-21 Thread via GitHub
HoustonPutman commented on PR #3198: URL: https://github.com/apache/solr/pull/3198#issuecomment-2674924334 In the meantime I'll merge, since this is failing the tests occasionally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Fix race condition in TestThinCache [solr]

2025-02-21 Thread via GitHub
HoustonPutman merged PR #3198: URL: https://github.com/apache/solr/pull/3198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[PR] SOLR-17444: Add Passage Sorting Option in UnifiedSolrHighlighter [solr]

2025-02-21 Thread via GitHub
Seunghan-Jung opened a new pull request, #2697: URL: https://github.com/apache/solr/pull/2697 https://issues.apache.org/jira/browse/SOLR-17444 # Description We will add the `passageSortComparator` option, introduced in the `UnifiedHighlighter` in the Lucene 9.11 pro

Re: [PR] Payload Score Parser: expand documentation's pointing to Lucene javadocs [solr]

2025-02-21 Thread via GitHub
cpoerschke commented on PR #2693: URL: https://github.com/apache/solr/pull/2693#issuecomment-2675080382 > I think I figured out how to add the Lucene `queries` module to the local Javadocs. I had to manually edit the lockfiles... Thanks for figuring it out and picking this up! -- T

Re: [PR] LogListener: remove no-arg convenience methods [solr]

2025-02-21 Thread via GitHub
dsmiley merged PR #3202: URL: https://github.com/apache/solr/pull/3202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] Payload Score Parser: expand documentation's pointing to Lucene javadocs [solr]

2025-02-21 Thread via GitHub
epugh merged PR #2693: URL: https://github.com/apache/solr/pull/2693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] @SOLR-17675 Remove DirContext param from DirectoryFactory create method. [solr]

2025-02-21 Thread via GitHub
bruno-roustant merged PR #3194: URL: https://github.com/apache/solr/pull/3194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.ap

[jira] [Commented] (SOLR-17675) Remove DirContext param from DirectoryFactory create method

2025-02-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929116#comment-17929116 ] ASF subversion and git services commented on SOLR-17675: Commit 5

Re: [I] Text to Vector Filter for Indexing [solr-operator]

2025-02-21 Thread via GitHub
HoustonPutman closed issue #758: Text to Vector Filter for Indexing URL: https://github.com/apache/solr-operator/issues/758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] SOLR-16391: Convert create-core, core-status to JAX-RS [solr]

2025-02-21 Thread via GitHub
gerlowskija merged PR #3054: URL: https://github.com/apache/solr/pull/3054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] SOLR-17677: Ensure DBQ is safe before running [solr]

2025-02-21 Thread via GitHub
gerlowskija merged PR #3203: URL: https://github.com/apache/solr/pull/3203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[jira] [Commented] (SOLR-17677) {!join} in delete-by-query throws ClassCastException and closes IndexWriter

2025-02-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929297#comment-17929297 ] ASF subversion and git services commented on SOLR-17677: Commit 7

[jira] [Commented] (SOLR-16391) Cosmetic improvements and migration to JAX-RS (collection, collection prop, core CRUD APIs)

2025-02-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929295#comment-17929295 ] ASF subversion and git services commented on SOLR-16391: Commit 5

[PR] Finally fix TestCoordinatorRole for good. [solr]

2025-02-21 Thread via GitHub
HoustonPutman opened a new pull request, #3205: URL: https://github.com/apache/solr/pull/3205 `TestCoordinatorRole.testNRTRestart()` has been flaky for a long time, and for various reasons. I believe this is the last one. Basically in the last part, it's supposed to turn off the NRT r

Re: [I] Text to Vector Filter for Indexing [solr-operator]

2025-02-21 Thread via GitHub
HoustonPutman commented on issue #758: URL: https://github.com/apache/solr-operator/issues/758#issuecomment-2675799680 Agreed, please open an issue at https://issues.apache.org/jira/projects/SOLR! Great idea though -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] SOLR-17531: Use new unified GC log options [solr]

2025-02-21 Thread via GitHub
github-actions[bot] commented on PR #2815: URL: https://github.com/apache/solr/pull/2815#issuecomment-2675846661 This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be fam