AndreyBozhko commented on code in PR #3204: URL: https://github.com/apache/solr/pull/3204#discussion_r1966067522
########## solr/solrj/src/test/org/apache/solr/client/solrj/request/TestCoreAdmin.java: ########## @@ -80,7 +80,7 @@ public void testCustomUlogDir() throws Exception { cores.getAllowPaths().add(dataDir.toPath()); // Allow the test dir cores.getAllowPaths().add(newCoreInstanceDir.toPath()); // Allow the test dir - File instanceDir = new File(cores.getSolrHome()); + File instanceDir = cores.getSolrHome().toFile(); Review Comment: Yes, it's possible to replace FileUtils here with `org.apache.commons.io.file.PathUtils`. For now I changed just the callsites for CoreContainer#getSolrHome, to simplify the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org