dsmiley commented on code in PR #3171:
URL: https://github.com/apache/solr/pull/3171#discussion_r1948227396
##
solr/benchmark/src/test/org/apache/solr/bench/DockMakerTest.java:
##
@@ -200,25 +201,4 @@ public void testWordListZipfian() {
assertNotNull(field.getValue().toSt
mkhludnev commented on code in PR #3158:
URL: https://github.com/apache/solr/pull/3158#discussion_r1948227521
##
solr/core/src/java/org/apache/solr/search/facet/FacetField.java:
##
@@ -139,11 +139,11 @@ public FacetProcessor
createFacetProcessor(FacetContext fcontext) {
//
dsmiley commented on code in PR #3158:
URL: https://github.com/apache/solr/pull/3158#discussion_r1948246532
##
solr/core/src/java/org/apache/solr/search/facet/FacetField.java:
##
@@ -139,11 +139,11 @@ public FacetProcessor
createFacetProcessor(FacetContext fcontext) {
// F
dsmiley commented on code in PR #3172:
URL: https://github.com/apache/solr/pull/3172#discussion_r1948343274
##
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##
@@ -1129,7 +1129,7 @@ protected SolrCore(
initWriters();
qParserPlugins.init(QParserPlugin.stand
dsmiley opened a new pull request, #3171:
URL: https://github.com/apache/solr/pull/3171
See this
[thread](https://github.com/apache/solr/pull/254#discussion_r1917413526)
> I see a repeating failure running DockMakerTest.testBasicCardinalityAlpha
with seed E0BBCB76FA600308 in which every
github-actions[bot] closed pull request #1899: SOLR-16966: Add a first-class
cache for OrdinalMaps
URL: https://github.com/apache/solr/pull/1899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
dsmiley commented on code in PR #3172:
URL: https://github.com/apache/solr/pull/3172#discussion_r1948360244
##
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java:
##
@@ -18,6 +18,7 @@
import static org.apache.solr.schema.IndexSchema.NEST_PAT
dsmiley commented on PR #3172:
URL: https://github.com/apache/solr/pull/3172#issuecomment-2646875261
Adding another check, that the implementations do *not* implement
`SolrCoreAware`, would also be good, as they are the builtIn ones instantiated
once. I imagine a non-issue for existing one
github-actions[bot] commented on PR #1899:
URL: https://github.com/apache/solr/pull/1899#issuecomment-2646664483
This PR is now closed due to 60 days of inactivity after being marked as
stale. Re-opening this PR is still possible, in which case it will be marked
as active again.
--
This
github-actions[bot] commented on PR #814:
URL: https://github.com/apache/solr/pull/814#issuecomment-2646664536
This PR is now closed due to 60 days of inactivity after being marked as
stale. Re-opening this PR is still possible, in which case it will be marked
as active again.
--
This i
github-actions[bot] closed pull request #1481: SOLR-16707: Avoid "Recursive
update" ISE in non-async cache `computeIfAbsent()`
URL: https://github.com/apache/solr/pull/1481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
github-actions[bot] commented on PR #1481:
URL: https://github.com/apache/solr/pull/1481#issuecomment-2646664503
This PR is now closed due to 60 days of inactivity after being marked as
stale. Re-opening this PR is still possible, in which case it will be marked
as active again.
--
This
github-actions[bot] closed pull request #814: SOLR-16162: FilterQuery should
implement DocSetProducer
URL: https://github.com/apache/solr/pull/814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
David Smiley created SOLR-17662:
---
Summary: Java SPI/ServiceLoader for plugin discovery &
instantiation
Key: SOLR-17662
URL: https://issues.apache.org/jira/browse/SOLR-17662
Project: Solr
Issue
dsmiley opened a new pull request, #3172:
URL: https://github.com/apache/solr/pull/3172
https://issues.apache.org/jira/browse/SOLR-17662
Despite me wanting this for a long time, what motivated me today
specifically was looking at @malliaridis trying to solve risks of static class
ini
[
https://issues.apache.org/jira/browse/SOLR-17662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17662:
--
Labels: pull-request-available (was: )
> Java SPI/ServiceLoader for plugin discovery & instant
dsmiley commented on code in PR #3164:
URL: https://github.com/apache/solr/pull/3164#discussion_r1948435790
##
solr/core/src/java/org/apache/solr/metrics/prometheus/SolrPrometheusFormatter.java:
##
@@ -206,6 +251,22 @@ public void collectGaugeDatapoint(
metricGauges.get(met
dsmiley commented on code in PR #115:
URL: https://github.com/apache/solr-sandbox/pull/115#discussion_r1948445957
##
encryption/src/main/java/org/apache/solr/encryption/EncryptionRequestHandler.java:
##
@@ -412,58 +409,46 @@ private void distributeRequest(SolrQueryRequest req,
mkhludnev commented on code in PR #3158:
URL: https://github.com/apache/solr/pull/3158#discussion_r1948229222
##
solr/core/src/java/org/apache/solr/search/facet/FieldUtil.java:
##
@@ -44,27 +48,49 @@ public static SortedDocValues
getSortedDocValues(SolrIndexSearcher searcher, S
dsmiley commented on code in PR #3158:
URL: https://github.com/apache/solr/pull/3158#discussion_r1948247603
##
solr/core/src/java/org/apache/solr/search/facet/FieldUtil.java:
##
@@ -44,27 +48,49 @@ public static SortedDocValues
getSortedDocValues(SolrIndexSearcher searcher, Str
malliaridis commented on PR #3082:
URL: https://github.com/apache/solr/pull/3082#issuecomment-2646197885
We should upgrade this plugin instead and backport it. See
https://github.com/apache/solr/pull/3125
--
This is an automated message from the Apache Git Service.
To respond to the messa
malliaridis commented on PR #2881:
URL: https://github.com/apache/solr/pull/2881#issuecomment-2646309035
Thanks for your feedback @uschindler 😄
> Please be still careful to not use the plural s classes during
initialization on the original class. This would reintroduce the problems.
malliaridis commented on PR #3110:
URL: https://github.com/apache/solr/pull/3110#issuecomment-2646208813
Since `versions.props` in `branch_9x` does not explicitly defines the asm
version, this PR won't be backported.
For future reference, the explicit definition of this dependency for
uschindler commented on PR #2881:
URL: https://github.com/apache/solr/pull/2881#issuecomment-2646291916
Please be still careful to not use the plural s classes during
initialization on the original class. This would reintroduce the problems. I
wasn't able to check all those patterns, but I
bruno-roustant commented on code in PR #115:
URL: https://github.com/apache/solr-sandbox/pull/115#discussion_r1948115545
##
encryption/src/main/java/org/apache/solr/encryption/EncryptionRequestHandler.java:
##
@@ -412,58 +409,46 @@ private void distributeRequest(SolrQueryRequest
[
https://issues.apache.org/jira/browse/SOLR-17659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925379#comment-17925379
]
Gus Heck commented on SOLR-17659:
-
Another facet of what I'm saying is that the login sho
[
https://issues.apache.org/jira/browse/SOLR-17659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925377#comment-17925377
]
Gus Heck commented on SOLR-17659:
-
What I'm advocating is that unauthenticated users cann
bruno-roustant commented on code in PR #115:
URL: https://github.com/apache/solr-sandbox/pull/115#discussion_r1948118413
##
encryption/src/main/java/org/apache/solr/encryption/EncryptionRequestHandler.java:
##
@@ -527,31 +512,33 @@ private void commitEncryptionStart(String keyId
[
https://issues.apache.org/jira/browse/SOLR-17659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925383#comment-17925383
]
Jan Høydahl commented on SOLR-17659:
Ui is only yet another solr client. No data. No
solrbot commented on PR #3110:
URL: https://github.com/apache/solr/pull/3110#issuecomment-2646205282
### Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not
recognize the last commit author and assumes somebody else may have edited the
PR.
malliaridis merged PR #3110:
URL: https://github.com/apache/solr/pull/3110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
[
https://issues.apache.org/jira/browse/SOLR-17659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925389#comment-17925389
]
Gus Heck commented on SOLR-17659:
-
Yes I believe I said just that.
> Implement basic aut
uschindler commented on PR #2881:
URL: https://github.com/apache/solr/pull/2881#issuecomment-2646355888
> Thanks for your feedback @uschindler 😄
>
> > Please be still careful to not use the plural s classes during
initialization on the original class. This would reintroduce the proble
[
https://issues.apache.org/jira/browse/SOLR-17659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925389#comment-17925389
]
Gus Heck edited comment on SOLR-17659 at 2/9/25 3:28 PM:
-
Yes I b
[
https://issues.apache.org/jira/browse/SOLR-17659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925394#comment-17925394
]
Gus Heck commented on SOLR-17659:
-
To be clearer, think of the browser based UI as a pre-
[
https://issues.apache.org/jira/browse/SOLR-17659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925396#comment-17925396
]
Gus Heck commented on SOLR-17659:
-
I also hope that the login stuff is kept simple enough
[
https://issues.apache.org/jira/browse/SOLR-17659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christos Malliaridis updated SOLR-17659:
Description:
In the new UI one of the key features that is not implemented yet is u
malliaridis merged PR #3138:
URL: https://github.com/apache/solr/pull/3138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
malliaridis closed pull request #3111: chore(deps): update dependency
org.owasp.dependencycheck to v9.2.0
URL: https://github.com/apache/solr/pull/3111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
malliaridis commented on PR #3111:
URL: https://github.com/apache/solr/pull/3111#issuecomment-2646436311
Closing this as we have upgraded to 12.0.2 (see #3138)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
malliaridis opened a new pull request, #3170:
URL: https://github.com/apache/solr/pull/3170
Backport of #3138 to 9x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
[
https://issues.apache.org/jira/browse/SOLR-17659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925405#comment-17925405
]
Christos Malliaridis commented on SOLR-17659:
-
I think I understand what you
dsmiley commented on PR #2881:
URL: https://github.com/apache/solr/pull/2881#issuecomment-2646476270
Looking back at this a bit briefly. In general these plural form classes
should be very unreferenced except when the registry itself is needed (should
be rare). These classes should be con
dsmiley commented on PR #3158:
URL: https://github.com/apache/solr/pull/3158#issuecomment-2646477023
Looking for additional code review since I contributed to this PR
substantially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
dsmiley commented on PR #3148:
URL: https://github.com/apache/solr/pull/3148#issuecomment-2646517321
Will merge in a few days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
45 matches
Mail list logo
