dsmiley commented on code in PR #3172: URL: https://github.com/apache/solr/pull/3172#discussion_r1948360244
########## solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java: ########## @@ -18,6 +18,7 @@ import static org.apache.solr.schema.IndexSchema.NEST_PATH_FIELD_NAME; +import jakarta.inject.Named; Review Comment: Could also have added a getName to instances but it's more verbose and forces instantiation of the class. They are instantiated here anyway but nonetheless I like the idea of a future optimization that doesn't instantiate until first use. Could also decide a public static final String field `NAME` is the name. Anyway, FWIW I prefer the annotation; feels more modern and is simpler. Wouldn't be okay in SolrJ (e.g. for DocRouter) as we don't want to add dependencies there but that's fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
