thomaswoeckinger commented on PR #3158:
URL: https://github.com/apache/solr/pull/3158#issuecomment-2636198561
@dsmiley @gerlowskija May you know who is responsible for this part of
faceting code, to get a reviewer
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/SOLR-17649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Wöckinger updated SOLR-17649:
Summary: Multivalue facets on enum field type returns empty result when
using JsonFacet API
[
https://issues.apache.org/jira/browse/SOLR-17649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923979#comment-17923979
]
Thomas Wöckinger commented on SOLR-17649:
-
[~dsmiley] [ |https://github.com/dsmil
gerlowskija commented on code in PR #3047:
URL: https://github.com/apache/solr/pull/3047#discussion_r1943253094
##
solr/core/src/java/org/apache/solr/filestore/NodeFileStore.java:
##
@@ -76,135 +66,54 @@ public SolrJerseyResponse getFile(String path, Boolean
sync, String getFro
epugh commented on code in PR #3151:
URL: https://github.com/apache/solr/pull/3151#discussion_r1943278670
##
solr/test-framework/src/java/org/apache/solr/util/RestTestBase.java:
##
@@ -88,13 +88,33 @@ private static void checkUpdateU(String message, String
update, boolean shoul
[
https://issues.apache.org/jira/browse/SOLR-13681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923973#comment-17923973
]
Christine Poerschke commented on SOLR-13681:
bq. ticket cross-referencing: SO
[
https://issues.apache.org/jira/browse/SOLR-17653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924309#comment-17924309
]
Jan Høydahl commented on SOLR-17653:
I have some experience with JUnit and testContai
[
https://issues.apache.org/jira/browse/SOLR-17649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924310#comment-17924310
]
David Smiley commented on SOLR-17649:
-
Might you surmise how this regression came to
dsmiley commented on code in PR #3158:
URL: https://github.com/apache/solr/pull/3158#discussion_r1943824313
##
solr/core/src/test/org/apache/solr/search/facet/TestJsonFacets.java:
##
@@ -4907,6 +4907,38 @@ public void testQueryJoinBooksAndPages() throws
Exception {
janhoy commented on PR #3160:
URL: https://github.com/apache/solr/pull/3160#issuecomment-2638285227
> _(thinking out loud)_ I'd love to get a JVM running in Windows in a
container maybe (not possible with macOS host?) or I suppose VirtualBox if I
have to. Actually, I could probably use AWS
github-actions[bot] closed pull request #2218: SOLR-17130:
edismax-matchalldocs-optimization
URL: https://github.com/apache/solr/pull/2218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
github-actions[bot] commented on PR #2218:
URL: https://github.com/apache/solr/pull/2218#issuecomment-2638303460
This PR is now closed due to 60 days of inactivity after being marked as
stale. Re-opening this PR is still possible, in which case it will be marked
as active again.
--
This
github-actions[bot] closed pull request #1654: SOLR-16810: Under certain
situations Solr produces managed schema XML with duplicate fields
URL: https://github.com/apache/solr/pull/1654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
github-actions[bot] commented on PR #1654:
URL: https://github.com/apache/solr/pull/1654#issuecomment-2638303508
This PR is now closed due to 60 days of inactivity after being marked as
stale. Re-opening this PR is still possible, in which case it will be marked
as active again.
--
This
github-actions[bot] commented on PR #2221:
URL: https://github.com/apache/solr/pull/2221#issuecomment-2638303410
This PR is now closed due to 60 days of inactivity after being marked as
stale. Re-opening this PR is still possible, in which case it will be marked
as active again.
--
This
github-actions[bot] closed pull request #2221: SOLR-17131: Optimize rows=0
since score/sort isn't necessary
URL: https://github.com/apache/solr/pull/2221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
thomaswoeckinger commented on PR #3158:
URL: https://github.com/apache/solr/pull/3158#issuecomment-2639051999
> It's unfortunate we can't check the docValues format, but can we at least
add a comment explaining this. It's a bit confusing just looking at it without
context.
FacetField
[
https://issues.apache.org/jira/browse/SOLR-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924383#comment-17924383
]
Renato Haeberli commented on SOLR-17635:
The default behavior should be to use Si
mlbiscoc opened a new pull request, #3160:
URL: https://github.com/apache/solr/pull/3160
https://issues.apache.org/jira/browse/SOLR-17654
# Description
Number of tests failing on windows due to beginning slash in a path not
being stripped to become relative.
# Solution
mlbiscoc commented on code in PR #2924:
URL: https://github.com/apache/solr/pull/2924#discussion_r1943703861
##
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##
@@ -80,19 +80,21 @@ public DistribFileStore(CoreContainer coreContainer) {
}
@Override
-
[
https://issues.apache.org/jira/browse/SOLR-17654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17654:
--
Labels: pull-request-available (was: )
> DistribFileStore._getRealPath() has issues on Windows
gerlowskija commented on PR #3047:
URL: https://github.com/apache/solr/pull/3047#issuecomment-2637426498
Alright - I think I've addressed the feedback so far? If I've missed
anything, let me know. I've brought it up to date with 'main' and will aim to
merge in the next few days pending an
alessandrobenedetti commented on code in PR #3151:
URL: https://github.com/apache/solr/pull/3151#discussion_r1943491138
##
solr/modules/llm/src/java/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessor.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the A
Houston Putman created SOLR-17654:
-
Summary: DistribFileStore._getRealPath() has issues on Windows
Key: SOLR-17654
URL: https://issues.apache.org/jira/browse/SOLR-17654
Project: Solr
Issue Ty
alessandrobenedetti commented on code in PR #3151:
URL: https://github.com/apache/solr/pull/3151#discussion_r1943577028
##
solr/modules/llm/src/java/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessorFactory.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to
dsmiley commented on PR #3160:
URL: https://github.com/apache/solr/pull/3160#issuecomment-2638256078
_(thinking out loud)_
I'd love to get a JVM running in Windows in a container maybe (not possible
with macOS host?) or I suppose VirtualBox if I have to. Actually, I could
probably use A
epugh commented on PR #3159:
URL: https://github.com/apache/solr/pull/3159#issuecomment-2636956809
I ❤️ deprecations. How can we have a strategy to make sure these removals
happen? I.e, how can we help folks see these areas of work and then move it
forward?
ARe you thinking that
alessandrobenedetti commented on code in PR #3151:
URL: https://github.com/apache/solr/pull/3151#discussion_r1943628396
##
solr/modules/llm/src/java/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessor.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the A
dsmiley commented on PR #3159:
URL: https://github.com/apache/solr/pull/3159#issuecomment-2637969249
> we can just go ahead in main and start removing the deprecated code?
Sure. Some have JIRAs, even. There's plenty of other deprecations outside
this PR.
> any deprecated code
alessandrobenedetti commented on code in PR #3151:
URL: https://github.com/apache/solr/pull/3151#discussion_r1943633074
##
solr/modules/llm/src/test/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessorFactoryTest.java:
##
@@ -0,0 +1,129 @@
+/*
+ * Licens
[
https://issues.apache.org/jira/browse/SOLR-13681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924252#comment-17924252
]
David Smiley commented on SOLR-13681:
-
Yes please do that. Major releases are indeed
alessandrobenedetti commented on code in PR #3151:
URL: https://github.com/apache/solr/pull/3151#discussion_r1943636345
##
solr/modules/llm/src/test/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessorTest.java:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to t
alessandrobenedetti commented on code in PR #3151:
URL: https://github.com/apache/solr/pull/3151#discussion_r1943637205
##
solr/modules/llm/src/test/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessorTest.java:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to t
David Smiley created SOLR-17655:
---
Summary: Deprecate ExternalFileField in lieu of in-place docValue
updates
Key: SOLR-17655
URL: https://issues.apache.org/jira/browse/SOLR-17655
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-17655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17655:
Description: ExternalFileField is an old capability of Solr that pre-dated
in-place partial updates
[
https://issues.apache.org/jira/browse/SOLR-17655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924257#comment-17924257
]
David Smiley commented on SOLR-17655:
-
Some users [have
issues|https://lists.apache.
[
https://issues.apache.org/jira/browse/SOLR-17655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17655:
Priority: Blocker (was: Major)
> Deprecate ExternalFileField in lieu of in-place docValue updates
[
https://issues.apache.org/jira/browse/SOLR-17655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924259#comment-17924259
]
David Smiley commented on SOLR-17655:
-
BTW there are a variety of pieces of code here
[
https://issues.apache.org/jira/browse/SOLR-17655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17655:
Fix Version/s: 9.9
> Deprecate ExternalFileField in lieu of in-place docValue updates
> ---
mlbiscoc commented on code in PR #2924:
URL: https://github.com/apache/solr/pull/2924#discussion_r1943652914
##
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##
@@ -80,19 +80,21 @@ public DistribFileStore(CoreContainer coreContainer) {
}
@Override
-
alessandrobenedetti commented on code in PR #3151:
URL: https://github.com/apache/solr/pull/3151#discussion_r1943595213
##
solr/modules/llm/src/java/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessorFactory.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to
HoustonPutman commented on code in PR #2924:
URL: https://github.com/apache/solr/pull/2924#discussion_r1943584596
##
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##
@@ -80,19 +80,21 @@ public DistribFileStore(CoreContainer coreContainer) {
}
@Overr
[
https://issues.apache.org/jira/browse/SOLR-17497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski resolved SOLR-17497.
Fix Version/s: main (10.0)
9.8
Assignee: Sanjay Dutt
Reso
HoustonPutman commented on PR #3153:
URL: https://github.com/apache/solr/pull/3153#issuecomment-2637917612
> Agree with @epugh - isn't Security Manager all no-ops even with 21 (which
IIRC is the minimum Java for Solr 10)
I've never heard that. Do you have a link for that?
--
This i
uschindler commented on PR #3153:
URL: https://github.com/apache/solr/pull/3153#issuecomment-2637926350
> > Agree with @epugh - isn't Security Manager all no-ops even with 21
(which IIRC is the minimum Java for Solr 10)
>
> I've never heard that. Do you have a link for that?
No
alessandrobenedetti commented on code in PR #3151:
URL: https://github.com/apache/solr/pull/3151#discussion_r1943608528
##
solr/modules/llm/src/java/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessorFactory.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to
alessandrobenedetti commented on code in PR #3151:
URL: https://github.com/apache/solr/pull/3151#discussion_r1943614530
##
solr/modules/llm/src/test-files/solr/collection1/conf/solrconfig-llm-indexing-notDenseVectorField.xml:
##
Review Comment:
I could, but the reason I add
alessandrobenedetti commented on code in PR #3151:
URL: https://github.com/apache/solr/pull/3151#discussion_r1943616272
##
solr/modules/llm/src/java/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessor.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the A
dsmiley commented on code in PR #3151:
URL: https://github.com/apache/solr/pull/3151#discussion_r1943529534
##
solr/modules/llm/src/test/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessorFactoryTest.java:
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Ap
dsmiley commented on code in PR #3151:
URL: https://github.com/apache/solr/pull/3151#discussion_r1943539435
##
solr/test-framework/src/java/org/apache/solr/util/RestTestBase.java:
##
@@ -88,13 +88,33 @@ private static void checkUpdateU(String message, String
update, boolean sho
gerlowskija commented on code in PR #3054:
URL: https://github.com/apache/solr/pull/3054#discussion_r1943369180
##
solr/core/src/java/org/apache/solr/handler/admin/CoreAdminOperation.java:
##
@@ -92,32 +82,12 @@ public enum CoreAdminOperation implements CoreAdminOp {
CREATE_O
alessandrobenedetti commented on code in PR #3151:
URL: https://github.com/apache/solr/pull/3151#discussion_r1943488899
##
solr/modules/llm/src/java/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessorFactory.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to
alessandrobenedetti commented on code in PR #3151:
URL: https://github.com/apache/solr/pull/3151#discussion_r1943553277
##
solr/modules/llm/src/java/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessor.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the A
alessandrobenedetti commented on code in PR #3151:
URL: https://github.com/apache/solr/pull/3151#discussion_r1943565203
##
solr/modules/llm/src/java/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessor.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the A
alessandrobenedetti commented on code in PR #3151:
URL: https://github.com/apache/solr/pull/3151#discussion_r1943565203
##
solr/modules/llm/src/java/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessor.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the A
[
https://issues.apache.org/jira/browse/SOLR-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924234#comment-17924234
]
ASF subversion and git services commented on SOLR-17379:
Commit e
[
https://issues.apache.org/jira/browse/SOLR-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman resolved SOLR-17379.
---
Fix Version/s: 9.9
Assignee: Houston Putman
Resolution: Fixed
> ParsingFieldU
alessandrobenedetti commented on PR #3151:
URL: https://github.com/apache/solr/pull/3151#issuecomment-2637867724
> I wanted to follow-up on my feedback to the LLM module concerning use of
the word "embedding". I first tried to say that I was not familiar with the
word, and your response was
alessandrobenedetti commented on code in PR #3151:
URL: https://github.com/apache/solr/pull/3151#discussion_r1943565203
##
solr/modules/llm/src/java/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessor.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the A
59 matches
Mail list logo
