dsmiley commented on code in PR #3151:
URL: https://github.com/apache/solr/pull/3151#discussion_r1943539435
##########
solr/test-framework/src/java/org/apache/solr/util/RestTestBase.java:
##########
@@ -88,13 +88,33 @@ private static void checkUpdateU(String message, String
update, boolean shouldSu
if (response != null) fail(m + "update was not successful: " +
response);
} else {
String response = restTestHarness.validateErrorUpdate(update);
- if (response != null) fail(m + "update succeeded, but should have
failed: " + response);
+ if (response == null) fail(m + "update succeeded, but should have
failed: " + response);
}
} catch (SAXException e) {
throw new RuntimeException("Invalid XML", e);
}
}
+ public static void checkUpdateU(String update, String... tests) {
Review Comment:
At the moment, RestTestBase is common to basically any test using a
"REST-based model store"; which the LLM stuff recently added a new variant of
and hence RestTestBase is used. RestTestBase is used a lot. Preferrably we
wouldn't depend too much on our class hierarchy to accomplish re-usable things.
But there's no realistic action to take right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
