[jira] [Commented] (SOLR-17630) Add CloudSolrClient instance for a Solr node

2025-01-27 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17921350#comment-17921350 ] Jason Gerlowski commented on SOLR-17630: bq. SolrClientCache is largely an unnece

Re: [PR] SolrParams.equals implementation [solr]

2025-01-27 Thread via GitHub
renatoh commented on code in PR #3141: URL: https://github.com/apache/solr/pull/3141#discussion_r1930665571 ## solr/solrj/src/java/org/apache/solr/common/params/SolrParams.java: ## @@ -526,4 +527,36 @@ public String toString() { } return sb.toString(); } + + /** +

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2025-01-27 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1930746093 ## solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/icons/SolrLogo.kt: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Remove broken and unused ZkStateReader.getReplicaProps() [solr]

2025-01-27 Thread via GitHub
psalagnac merged PR #3059: URL: https://github.com/apache/solr/pull/3059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

Re: [PR] SOLR-16903: Migrate off java.io.File to java.nio.file.Path from core files [solr]

2025-01-27 Thread via GitHub
mlbiscoc commented on code in PR #2924: URL: https://github.com/apache/solr/pull/2924#discussion_r1929246536 ## solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java: ## @@ -373,12 +372,12 @@ public InputStream openResource(String resource) throws IOException {

Re: [PR] SolrParams.equals implementation [solr]

2025-01-27 Thread via GitHub
dsmiley commented on code in PR #3141: URL: https://github.com/apache/solr/pull/3141#discussion_r1930815270 ## solr/solrj/src/java/org/apache/solr/common/params/SolrParams.java: ## @@ -526,4 +527,36 @@ public String toString() { } return sb.toString(); } + + /** +

Re: [PR] remove deprecated (DocValues,Norms)FieldExistsQuery use [solr]

2025-01-27 Thread via GitHub
HoustonPutman commented on PR #2632: URL: https://github.com/apache/solr/pull/2632#issuecomment-2616441824 > Suggest `main` branch only, since now changes for https://issues.apache.org/jira/browse/SOLR-14199 are also included, WDYT? So that Jira isn't actually done here. Inside Solr i

Re: [PR] remove deprecated (DocValues,Norms)FieldExistsQuery use [solr]

2025-01-27 Thread via GitHub
cpoerschke commented on code in PR #2632: URL: https://github.com/apache/solr/pull/2632#discussion_r1930845447 ## solr/core/src/java/org/apache/solr/schema/DenseVectorField.java: ## @@ -394,7 +394,7 @@ public Query getFieldQuery(QParser parser, SchemaField field, String externa

Re: [PR] remove deprecated (DocValues,Norms)FieldExistsQuery use [solr]

2025-01-27 Thread via GitHub
cpoerschke commented on code in PR #2632: URL: https://github.com/apache/solr/pull/2632#discussion_r1930872830 ## solr/core/src/java/org/apache/solr/schema/DenseVectorField.java: ## @@ -394,7 +394,7 @@ public Query getFieldQuery(QParser parser, SchemaField field, String externa

Re: [PR] remove deprecated (DocValues,Norms)FieldExistsQuery use [solr]

2025-01-27 Thread via GitHub
cpoerschke commented on PR #2632: URL: https://github.com/apache/solr/pull/2632#issuecomment-2616389577 > for `main` and `branch_9x` only, no JIRA or solr/CHANGES.txt entry needed in my opinion. Suggest `main` branch only, since now changes for https://issues.apache.org/jira/browse/S

[jira] [Commented] (SOLR-17630) Add CloudSolrClient instance for a Solr node

2025-01-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17921462#comment-17921462 ] David Smiley commented on SOLR-17630: - SolrClientCache could be removed entirely in S

Re: [PR] SolrParams.equals implementation [solr]

2025-01-27 Thread via GitHub
renatoh commented on code in PR #3141: URL: https://github.com/apache/solr/pull/3141#discussion_r1931638863 ## solr/solrj/src/java/org/apache/solr/common/params/SolrParams.java: ## @@ -526,4 +527,36 @@ public String toString() { } return sb.toString(); } + + /** +

Re: [PR] Jetty12 + EE10 [solr]

2025-01-27 Thread via GitHub
dsmiley commented on code in PR #2876: URL: https://github.com/apache/solr/pull/2876#discussion_r1931628768 ## solr/core/src/test/org/apache/solr/servlet/HttpSolrCallCloudTest.java: ## @@ -93,40 +114,66 @@ private void assertCoreChosen(int numCores, TestRequest testRequest) thr