[
https://issues.apache.org/jira/browse/SOLR-17630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17921350#comment-17921350
]
Jason Gerlowski commented on SOLR-17630:
----------------------------------------
bq. SolrClientCache is largely an unnecessary mechanism outside of
streaming-expressions. We don't need to cache SolrClient instances by a URL key
Curious for more details there. What makes it necessary in
streaming-expressions, but unnecessary elsewhere? (Or is it "unnecessary"
everywhere, but prohibitively difficult to untangle from certain places like
streaming-expressions?).
To Eric's point - allowing usage only within a particular module seems like a
hard line to hold. Most folks will just see it as an IDE autocomplete option
when they type "coreContainer.get", and blithely go on their way. That's what
I blame for my mistaken usage the other day.
> Add CloudSolrClient instance for a Solr node
> --------------------------------------------
>
> Key: SOLR-17630
> URL: https://issues.apache.org/jira/browse/SOLR-17630
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
> Reporter: David Smiley
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There ought to be a general CloudSolrClient instance for the Solr node,
> without each potential user of such needing to create one. The closest
> substitute at the moment is
> {{cc.getSolrClientCache().getCloudSolrClient(cc.getZkController().getZkServerAddress())}}
> which is too verbose, not as discoverable, and it's debatable if
> SolrClientCache should be it's home.
> A scalability/simplicity advantage of a shared one instead of newly
> constructed one is that the existing ZkClientClusterStateProvider (same node
> ZkStateReader instance) can be used, thus improving scalability and
> simplifying interpretation of logs (as all logs from ZkStateReader on a node
> can be assumed to then be from the same instance). SolrClientCache creates
> new ones.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
