Re: [PR] SOLR-17602: Per-Module Dependency Locking [solr]

2025-01-11 Thread via GitHub
dsmiley commented on code in PR #2925: URL: https://github.com/apache/solr/pull/2925#discussion_r1912079520 ## solr/modules/sql/build.gradle: ## @@ -20,6 +20,7 @@ apply plugin: 'java-library' description = 'SQL Module' dependencies { + implementation platform(project(':plat

Re: [PR] Payload Score Parser: expand documentation's pointing to Lucene javadocs [solr]

2025-01-11 Thread via GitHub
github-actions[bot] commented on PR #2693: URL: https://github.com/apache/solr/pull/2693#issuecomment-2585484446 This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. -- This

[PR] SOLR-17618: Add unit tests for org.apache.solr.util.TimeOut [solr]

2025-01-11 Thread via GitHub
sandbergja opened a new pull request, #3026: URL: https://github.com/apache/solr/pull/3026 This class did not appear to have any unit tests yet. https://issues.apache.org/jira/browse/SOLR-17618 # Description Adding some unit tests for `org.apache.solr.util.Tim

[jira] [Updated] (SOLR-17618) Unit tests for org.apache.solr.util.TimeOut

2025-01-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17618: -- Labels: pull-request-available (was: ) > Unit tests for org.apache.solr.util.TimeOut > ---

[jira] [Created] (SOLR-17618) Unit tests for org.apache.solr.util.TimeOut

2025-01-11 Thread Jane Sandberg (Jira)
Jane Sandberg created SOLR-17618: Summary: Unit tests for org.apache.solr.util.TimeOut Key: SOLR-17618 URL: https://issues.apache.org/jira/browse/SOLR-17618 Project: Solr Issue Type: Test

Re: [PR] Payload Score Parser: expand documentation's pointing to Lucene javadocs [solr]

2025-01-11 Thread via GitHub
github-actions[bot] closed pull request #2693: Payload Score Parser: expand documentation's pointing to Lucene javadocs URL: https://github.com/apache/solr/pull/2693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [SOLR-17187] Add possibility to supply a custom commitPollInterval for TLOG/PULL replicas [solr]

2025-01-11 Thread via GitHub
github-actions[bot] commented on PR #2316: URL: https://github.com/apache/solr/pull/2316#issuecomment-2585484468 This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. -- This

Re: [PR] [SOLR-17187] Add possibility to supply a custom commitPollInterval for TLOG/PULL replicas [solr]

2025-01-11 Thread via GitHub
github-actions[bot] closed pull request #2316: [SOLR-17187] Add possibility to supply a custom commitPollInterval for TLOG/PULL replicas URL: https://github.com/apache/solr/pull/2316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[PR] Move DOMUtil ConfigNode methods to ConfigNode, with some name changes. [solr]

2025-01-11 Thread via GitHub
dsmiley opened a new pull request, #3027: URL: https://github.com/apache/solr/pull/3027 ConfigNode.requiredStrAttr -> attrRequired ConfigNode.child (ex) -> childRequired ConfigNode.getAll move name to first param; don't use empty set PluginInfo: don't need the XML Node constructo

Re: [PR] Move DOMUtil ConfigNode methods to ConfigNode, with some name changes. [solr]

2025-01-11 Thread via GitHub
dsmiley commented on code in PR #3027: URL: https://github.com/apache/solr/pull/3027#discussion_r1912371099 ## solr/core/src/java/org/apache/solr/core/PluginInfo.java: ## @@ -100,39 +100,23 @@ public String toString() { } } + /** From XML. */ public PluginInfo(Conf

[jira] [Commented] (SOLR-16116) Refactor the Solr Zookeeper logic to use Apache Curator

2025-01-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912241#comment-17912241 ] David Smiley commented on SOLR-16116: - Also, same test but different failing test run

[jira] [Commented] (SOLR-16116) Refactor the Solr Zookeeper logic to use Apache Curator

2025-01-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912239#comment-17912239 ] David Smiley commented on SOLR-16116: - I was looking at [flaky failures|https://ge.a

Re: [PR] reusing empty NamedList rather than recreating a new empty NamedList … [solr]

2025-01-11 Thread via GitHub
dsmiley merged PR #2932: URL: https://github.com/apache/solr/pull/2932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] reusing empty NamedList rather than recreating a new empty NamedList … [solr]

2025-01-11 Thread via GitHub
dsmiley commented on PR #2932: URL: https://github.com/apache/solr/pull/2932#issuecomment-2585401392 Also merged to branch_9x thus will appear in Solr 9.9. Thanks for contributing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G