[ 
https://issues.apache.org/jira/browse/SOLR-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912239#comment-17912239
 ] 

David Smiley commented on SOLR-16116:
-------------------------------------

I was looking at [flaky 
failures|https://ge.apache.org/s/mjapfoyz6alvi/tests/task/:solr:core:test/details/org.apache.solr.cloud.BasicDistributedZk2Test/test?top-execution=1]
 to BasicDistributedZk2Test that you tried to fix via calling 
blockUntilConnected.  But that block is only 50ms and it'll merely return and 
we continue into a failure.  Shouldn't we potentially wait longer and assert 
the response of that?  An aside; sadly Curator is using currentTimeMillis 
instead of nanoTime to track the passage of time.

> Refactor the Solr Zookeeper logic to use Apache Curator
> -------------------------------------------------------
>
>                 Key: SOLR-16116
>                 URL: https://issues.apache.org/jira/browse/SOLR-16116
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SolrCloud
>            Reporter: Houston Putman
>            Assignee: Houston Putman
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: main (10.0)
>
>          Time Spent: 10h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to