Re: [PR] SOLR-17588 : javabin must support primitive arrays [solr]

2024-12-23 Thread via GitHub
noblepaul merged PR #2900: URL: https://github.com/apache/solr/pull/2900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-17588) javabin must support primitive arrays

2024-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17908019#comment-17908019 ] ASF subversion and git services commented on SOLR-17588: Commit c

Re: [PR] SOLR-17582 Stream CLUSTERSTATUS API response [solr]

2024-12-23 Thread via GitHub
dsmiley commented on PR #2916: URL: https://github.com/apache/solr/pull/2916#issuecomment-2559819637 Yes; as the code you modified in a ClusterStateProvider shows, the NamedList->Map happened and broke that code. You could add a check for {{params.get(CommonParams.WT)}} and check if

[jira] [Commented] (SOLR-17608) v1/v2 serialization should support 'Instant'

2024-12-23 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907905#comment-17907905 ] Jason Gerlowski commented on SOLR-17608: I should've given a bit more detail in m

[jira] [Resolved] (SOLR-17541) LBSolrClient implementations should agree on 'getClient()' semantics

2024-12-23 Thread James Dyer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Dyer resolved SOLR-17541. --- Resolution: Fixed > LBSolrClient implementations should agree on 'getClient()' semantics > -

Re: [PR] SOLR-15751: Modify v2 `GET /collections/collName` to support full ColStatus response [solr]

2024-12-23 Thread via GitHub
gerlowskija commented on code in PR #2912: URL: https://github.com/apache/solr/pull/2912#discussion_r1895633101 ## solr/api/src/java/org/apache/solr/client/api/model/CollectionStatusResponse.java: ## @@ -82,21 +97,93 @@ public static class LeaderSummary { // Present with

[jira] [Resolved] (SOLR-14730) Build new SolrJ APIs without concrete classes like NamedList/Map

2024-12-23 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-14730. Resolution: Duplicate > Build new SolrJ APIs without concrete classes like NamedList/Map >

[jira] [Commented] (SOLR-17405) Zookeeper session can be re-established by multiple threads concurrently

2024-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907844#comment-17907844 ] ASF subversion and git services commented on SOLR-17405: Commit 5

[jira] [Updated] (SOLR-17405) Zookeeper session can be re-established by multiple threads concurrently

2024-12-23 Thread Pierre Salagnac (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Salagnac updated SOLR-17405: --- Fix Version/s: 9.8 (was: 9.9) > Zookeeper session can be re-establishe

[jira] [Commented] (SOLR-17541) LBSolrClient implementations should agree on 'getClient()' semantics

2024-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907898#comment-17907898 ] ASF subversion and git services commented on SOLR-17541: Commit b

[jira] [Commented] (SOLR-17608) v1/v2 serialization should support 'Instant'

2024-12-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907900#comment-17907900 ] David Smiley commented on SOLR-17608: - I doubt we need to do custom things for Instan

[jira] [Commented] (SOLR-17405) Zookeeper session can be re-established by multiple threads concurrently

2024-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907841#comment-17907841 ] ASF subversion and git services commented on SOLR-17405: Commit 7

Re: [PR] SOLR-15751: Modify v2 `GET /collections/collName` to support full ColStatus response [solr]

2024-12-23 Thread via GitHub
gerlowskija commented on code in PR #2912: URL: https://github.com/apache/solr/pull/2912#discussion_r1895634779 ## solr/api/src/java/org/apache/solr/client/api/model/CollectionStatusResponse.java: ## @@ -0,0 +1,249 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[jira] [Assigned] (SOLR-17541) LBSolrClient implementations should agree on 'getClient()' semantics

2024-12-23 Thread James Dyer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Dyer reassigned SOLR-17541: - Fix Version/s: main (10.0) Assignee: James Dyer > LBSolrClient implementations should a

Re: [PR] SOLR-17541: LBSolrClient implementations should agree on 'getClient()' semantics [solr]

2024-12-23 Thread via GitHub
jdyer1 merged PR #2899: URL: https://github.com/apache/solr/pull/2899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-17541) LBSolrClient implementations should agree on 'getClient()' semantics

2024-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907889#comment-17907889 ] ASF subversion and git services commented on SOLR-17541: Commit d

Re: [PR] SOLR-17405: allow a single thread to reestablish ZK session [solr]

2024-12-23 Thread via GitHub
epugh commented on PR #2914: URL: https://github.com/apache/solr/pull/2914#issuecomment-2560159763 I actually think we won't see a 9.8 release get moving until after the new year, so we have time ;-). -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Deprecate MapWriter.append [solr]

2024-12-23 Thread via GitHub
epugh commented on code in PR #2919: URL: https://github.com/apache/solr/pull/2919#discussion_r1896037341 ## solr/solrj/src/java/org/apache/solr/common/MapWriter.java: ## @@ -70,8 +74,7 @@ public MapWriter.EntryWriter put(CharSequence k, Object v) { writer.endObject(); }

[jira] [Commented] (SOLR-17602) Maintain final JAR dependencies in source control to track changes

2024-12-23 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907933#comment-17907933 ] Christos Malliaridis commented on SOLR-17602: - I like the idea and I would lo

[jira] [Commented] (SOLR-17602) Maintain final JAR dependencies in source control to track changes

2024-12-23 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907945#comment-17907945 ] Christos Malliaridis commented on SOLR-17602: - I've reviewed the versions.loc

[jira] [Comment Edited] (SOLR-17602) Maintain final JAR dependencies in source control to track changes

2024-12-23 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907945#comment-17907945 ] Christos Malliaridis edited comment on SOLR-17602 at 12/23/24 8:55 PM:

[jira] [Updated] (SOLR-17602) Maintain final JAR dependencies in source control to track changes

2024-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17602: -- Labels: pull-request-available (was: ) > Maintain final JAR dependencies in source control to

[PR] SOLR-17602: Per-Module Dependency Locking [solr]

2024-12-23 Thread via GitHub
malliaridis opened a new pull request, #2925: URL: https://github.com/apache/solr/pull/2925 https://issues.apache.org/jira/browse/SOLR-17602 # Description To improve the developer experience of the dependency management, we are looking for solutions to make the dependency lock

[PR] SOLR-17589 First use of PUT/POST request with HttpJdkSolrClient generates error log entry on solr server due to initial HEAD request [solr]

2024-12-23 Thread via GitHub
Paul-Blanchaert opened a new pull request, #2926: URL: https://github.com/apache/solr/pull/2926 [https://issues.apache.org/jira/browse/SOLR-17589](https://issues.apache.org/jira/browse/SOLR-17589) # Description Adding header "Content-Type"="application/json" to HEAD request pre

[jira] [Updated] (SOLR-17589) First use of PUT/POST request with HttpJdkSolrClient generates error log entry on solr server due to initial HEAD request

2024-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17589: -- Labels: pull-request-available (was: ) > First use of PUT/POST request with HttpJdkSolrClient

[PR] SOLR-16903: Migrate off java.io.File to java.nio.file.Path from core files [solr]

2024-12-23 Thread via GitHub
mlbiscoc opened a new pull request, #2924: URL: https://github.com/apache/solr/pull/2924 https://issues.apache.org/jira/browse/SOLR-16903 # Description Still in draft. Tests seem to pass locally but a lot can still be refactored better around Path. This should remove all

Re: [PR] Optimize dependency resolution via platform module [solr]

2024-12-23 Thread via GitHub
malliaridis commented on PR #2915: URL: https://github.com/apache/solr/pull/2915#issuecomment-2560092738 > SolrJ depends on "api" module too; so does this mean we unwittingly add dependencies for SolrJ users which they previously didn't have? We have to distinguish between constraints

Re: [PR] SOLR-16903: Migrate off java.io.File to java.nio.file.Path from core files [solr]

2024-12-23 Thread via GitHub
epugh commented on code in PR #2924: URL: https://github.com/apache/solr/pull/2924#discussion_r1896082729 ## solr/core/src/java/org/apache/solr/core/CoreDescriptor.java: ## @@ -64,7 +63,7 @@ public class CoreDescriptor { public static final String SOLR_CORE_PROP_PREFIX = "sol

Re: [PR] SOLR-16903: Migrate off java.io.File to java.nio.file.Path from core files [solr]

2024-12-23 Thread via GitHub
mlbiscoc commented on code in PR #2924: URL: https://github.com/apache/solr/pull/2924#discussion_r1896089926 ## solr/core/src/java/org/apache/solr/core/CoreDescriptor.java: ## @@ -64,7 +63,7 @@ public class CoreDescriptor { public static final String SOLR_CORE_PROP_PREFIX = "

[jira] [Commented] (SOLR-17541) LBSolrClient implementations should agree on 'getClient()' semantics

2024-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907962#comment-17907962 ] ASF subversion and git services commented on SOLR-17541: Commit 7

Re: [PR] SOLR-17589 First use of PUT/POST request with HttpJdkSolrClient generates error log entry on solr server due to initial HEAD request [solr]

2024-12-23 Thread via GitHub
jdyer1 commented on PR #2926: URL: https://github.com/apache/solr/pull/2926#issuecomment-2560434916 This is good. Is there any possibility you can add an assert somewhere to `HttpJdkSolrClientTest` to test the change? -- This is an automated message from the Apache Git Service. To respon

[jira] [Reopened] (SOLR-17541) LBSolrClient implementations should agree on 'getClient()' semantics

2024-12-23 Thread James Dyer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Dyer reopened SOLR-17541: --- I have reverted PR #2899 as it was causing test failures I had not caught earlier. It may be a little w

[jira] [Commented] (SOLR-17541) LBSolrClient implementations should agree on 'getClient()' semantics

2024-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907964#comment-17907964 ] ASF subversion and git services commented on SOLR-17541: Commit a