Re: [PR] SOLR-17151 Check limits between calls to components in SearchHandler [solr]

2024-11-08 Thread via GitHub
fsparv commented on code in PR #2801: URL: https://github.com/apache/solr/pull/2801#discussion_r1834560447 ## solr/core/src/test/org/apache/solr/core/ExitableDirectoryReaderTest.java: ## @@ -70,9 +70,12 @@ public void testPrefixQuery() throws Exception { // this time we s

Re: [PR] SOLR-17151 Check limits between calls to components in SearchHandler [solr]

2024-11-08 Thread via GitHub
fsparv commented on code in PR #2801: URL: https://github.com/apache/solr/pull/2801#discussion_r1834565410 ## solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java: ## @@ -626,44 +697,97 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse

Re: [PR] SOLR-17535: Deprecate ClusterState.forEachCollection [solr]

2024-11-08 Thread via GitHub
dsmiley commented on code in PR #2854: URL: https://github.com/apache/solr/pull/2854#discussion_r1834868691 ## solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java: ## @@ -425,7 +425,10 @@ public Stream collectionStream() { /** * Calls {@code consumer} with

Re: [PR] SOLR-17535: Deprecate ClusterState.forEachCollection [solr]

2024-11-08 Thread via GitHub
dsmiley commented on PR #2854: URL: https://github.com/apache/solr/pull/2854#issuecomment-2465480585 I'll merge this Monday in case there are any further comments, but I wouldn't anticipate any for this simple one. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Resolved] (SOLR-17453) Replace CloudUtil.waitForState and some TimeOut with ZkStateReader.waitForState

2024-11-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-17453. - Fix Version/s: 9.8 Resolution: Fixed Merged – thanks for contributing Pierre! > Replace C

Re: [PR] SOLR-17151 Check limits between calls to components in SearchHandler [solr]

2024-11-08 Thread via GitHub
fsparv commented on code in PR #2801: URL: https://github.com/apache/solr/pull/2801#discussion_r1834603826 ## solr/core/src/test/org/apache/solr/core/ExitableDirectoryReaderTest.java: ## @@ -70,9 +70,12 @@ public void testPrefixQuery() throws Exception { // this time we s

Re: [PR] SOLR-17151 Check limits between calls to components in SearchHandler [solr]

2024-11-08 Thread via GitHub
fsparv commented on code in PR #2801: URL: https://github.com/apache/solr/pull/2801#discussion_r1834603826 ## solr/core/src/test/org/apache/solr/core/ExitableDirectoryReaderTest.java: ## @@ -70,9 +70,12 @@ public void testPrefixQuery() throws Exception { // this time we s

[jira] [Assigned] (SOLR-17406) Introduce Gradle Version Catalogs

2024-11-08 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Malliaridis reassigned SOLR-17406: --- Assignee: Christos Malliaridis > Introduce Gradle Version Catalogs > ---

[jira] [Updated] (SOLR-17406) Introduce Gradle Version Catalogs

2024-11-08 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Malliaridis updated SOLR-17406: Status: Patch Available (was: Open) > Introduce Gradle Version Catalogs >

Re: [PR] SOLR-17151 Check limits between calls to components in SearchHandler [solr]

2024-11-08 Thread via GitHub
fsparv commented on code in PR #2801: URL: https://github.com/apache/solr/pull/2801#discussion_r1834649523 ## solr/core/src/test/org/apache/solr/core/ExitableDirectoryReaderTest.java: ## @@ -70,9 +70,12 @@ public void testPrefixQuery() throws Exception { // this time we s

[jira] [Commented] (SOLR-17453) Replace CloudUtil.waitForState and some TimeOut with ZkStateReader.waitForState

2024-11-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896774#comment-17896774 ] ASF subversion and git services commented on SOLR-17453: Commit 8

Re: [PR] SOLR-14673: Add bin/solr stream CLI [solr]

2024-11-08 Thread via GitHub
malliaridis commented on PR #2479: URL: https://github.com/apache/solr/pull/2479#issuecomment-2465603881 A few more notes: - [ ] `bin/solr stream --help` does not include any reference to the stream expression argument required at position 0 (or any other position that is valid) - [ ]

Re: [PR] SOLR-14673: Add bin/solr stream CLI [solr]

2024-11-08 Thread via GitHub
malliaridis commented on code in PR #2479: URL: https://github.com/apache/solr/pull/2479#discussion_r1834961429 ## solr/core/src/java/org/apache/solr/cli/StreamTool.java: ## @@ -0,0 +1,507 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribu

Re: [PR] SOLR-14673: Add bin/solr stream CLI [solr]

2024-11-08 Thread via GitHub
malliaridis commented on code in PR #2479: URL: https://github.com/apache/solr/pull/2479#discussion_r1834961429 ## solr/core/src/java/org/apache/solr/cli/StreamTool.java: ## @@ -0,0 +1,507 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribu

Re: [PR] SOLR-14673: Add bin/solr stream CLI [solr]

2024-11-08 Thread via GitHub
malliaridis commented on code in PR #2479: URL: https://github.com/apache/solr/pull/2479#discussion_r1834874458 ## solr/core/src/java/org/apache/solr/cli/StreamTool.java: ## @@ -0,0 +1,507 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribu

[jira] [Created] (SOLR-17550) preferred Overseer might not work

2024-11-08 Thread David Smiley (Jira)
David Smiley created SOLR-17550: --- Summary: preferred Overseer might not work Key: SOLR-17550 URL: https://issues.apache.org/jira/browse/SOLR-17550 Project: Solr Issue Type: Bug Security L

Re: [PR] SOLR-14680: Remove SimpleMap (affects NamedList) [solr]

2024-11-08 Thread via GitHub
dsmiley commented on code in PR #2856: URL: https://github.com/apache/solr/pull/2856#discussion_r1835195200 ## solr/core/src/java/org/apache/solr/util/DataConfigNode.java: ## @@ -54,31 +53,17 @@ public DataConfigNode(ConfigNode root) { e.setValue(List.copyOf(e.getValue(

[jira] [Updated] (SOLR-17551) zk upconfig command broken on Windows

2024-11-08 Thread Mingchun Zhao (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingchun Zhao updated SOLR-17551: - Attachment: SOLR-17551.patch > zk upconfig command broken on Windows > --

[jira] [Created] (SOLR-17552) NamedList.asShallowMap improvements

2024-11-08 Thread David Smiley (Jira)
David Smiley created SOLR-17552: --- Summary: NamedList.asShallowMap improvements Key: SOLR-17552 URL: https://issues.apache.org/jira/browse/SOLR-17552 Project: Solr Issue Type: Improvement

[jira] [Created] (SOLR-17551) zk upconfig command broken on Windows

2024-11-08 Thread Mingchun Zhao (Jira)
Mingchun Zhao created SOLR-17551: Summary: zk upconfig command broken on Windows Key: SOLR-17551 URL: https://issues.apache.org/jira/browse/SOLR-17551 Project: Solr Issue Type: Bug Secu

Re: [PR] chore(deps): update io.netty:* to v4.1.114.final [solr]

2024-11-08 Thread via GitHub
malliaridis commented on PR #2702: URL: https://github.com/apache/solr/pull/2702#issuecomment-2465468387 We could introduce in this PR netty BOM https://mvnrepository.com/artifact/io.netty/netty-bom/4.1.114.Final to sync all netty libs based on the BOM. -- This is an automated message fr

[PR] SOLR-16116: Fix various issues with Curator [solr]

2024-11-08 Thread via GitHub
HoustonPutman opened a new pull request, #2855: URL: https://github.com/apache/solr/pull/2855 https://issues.apache.org/jira/browse/SOLR-16116 Will eventually post a list of fixed tests -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-08 Thread via GitHub
cpoerschke commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1834066298 ## solr/modules/llm/src/java/org/apache/solr/llm/embedding/SolrEmbeddingModel.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-08 Thread via GitHub
cpoerschke commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r183404 ## solr/modules/llm/src/java/org/apache/solr/llm/embedding/SolrEmbeddingModel.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-08 Thread via GitHub
cpoerschke commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1834068088 ## solr/modules/llm/src/java/org/apache/solr/llm/embedding/SolrEmbeddingModel.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-08 Thread via GitHub
cpoerschke commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1834068534 ## solr/modules/llm/src/java/org/apache/solr/llm/embedding/SolrEmbeddingModel.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-08 Thread via GitHub
cpoerschke commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1834068534 ## solr/modules/llm/src/java/org/apache/solr/llm/embedding/SolrEmbeddingModel.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-08 Thread via GitHub
cpoerschke commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1834073353 ## solr/modules/llm/src/java/org/apache/solr/llm/embedding/SolrEmbeddingModel.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-08 Thread via GitHub
cpoerschke commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1834162601 ## solr/modules/llm/src/java/org/apache/solr/llm/embedding/SolrEmbeddingModel.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-08 Thread via GitHub
cpoerschke commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1834169995 ## solr/modules/llm/src/test/org/apache/solr/llm/embedding/DummyEmbeddingModel.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-11-08 Thread via GitHub
cpoerschke commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1834211925 ## solr/modules/monitor/src/java/org/apache/solr/monitor/search/SolrMonitorQueryCollector.java: ## @@ -0,0 +1,106 @@ +/* + * + * * Licensed to the Apache Software Foun

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-11-08 Thread via GitHub
cpoerschke commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1834333404 ## solr/modules/monitor/build.gradle: ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements.

[jira] [Resolved] (SOLR-17495) Change CLI DeleteTool deleting of configs to opt in instead of default behavior

2024-11-08 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17495. -- Fix Version/s: main (10.0) Resolution: Fixed > Change CLI DeleteTool deleting of configs to opt

[jira] [Commented] (SOLR-17495) Change CLI DeleteTool deleting of configs to opt in instead of default behavior

2024-11-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896660#comment-17896660 ] ASF subversion and git services commented on SOLR-17495: Commit b

Re: [PR] SOLR-17495: Change CLI delete command to not delete configs by default. [solr]

2024-11-08 Thread via GitHub
epugh merged PR #2761: URL: https://github.com/apache/solr/pull/2761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update creation of URL to avoid deprecation message [solr]

2024-11-08 Thread via GitHub
epugh commented on PR #2851: URL: https://github.com/apache/solr/pull/2851#issuecomment-2464671567 I tested by checking the build output messages on github running this PR against others, and I no longer see the message. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Update creation of URL to avoid deprecation message [solr]

2024-11-08 Thread via GitHub
epugh merged PR #2851: URL: https://github.com/apache/solr/pull/2851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17151 Check limits between calls to components in SearchHandler [solr]

2024-11-08 Thread via GitHub
sigram commented on code in PR #2801: URL: https://github.com/apache/solr/pull/2801#discussion_r1834075014 ## solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java: ## @@ -626,44 +697,97 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse

Re: [PR] SOLR-17535: Deprecate ClusterState.forEachCollection [solr]

2024-11-08 Thread via GitHub
murblanc commented on code in PR #2854: URL: https://github.com/apache/solr/pull/2854#discussion_r1834511103 ## solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java: ## @@ -425,7 +425,10 @@ public Stream collectionStream() { /** * Calls {@code consumer} with

[jira] [Updated] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2024-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-14680: -- Labels: clean-api pull-request-available (was: clean-api) > Provide simple interfaces to our c