[
https://issues.apache.org/jira/browse/SOLR-16757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895274#comment-17895274
]
Eric Pugh commented on SOLR-16757:
--
We are getting to the close of this effort. I check
[
https://issues.apache.org/jira/browse/SOLR-17497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895320#comment-17895320
]
Jason Gerlowski commented on SOLR-17497:
Hey [~sanjaydutt] - I'm going to backpor
psalagnac commented on PR #2737:
URL: https://github.com/apache/solr/pull/2737#issuecomment-2454956000
> One thought, is there a way to enforce the use of waitForState() pattern
via any of our code quality tools?
Not sure how we can automate decision on whether usages of `Timeout` are
murblanc commented on code in PR #2834:
URL: https://github.com/apache/solr/pull/2834#discussion_r1827321369
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -400,29 +402,14 @@ public Set getHostAllowList() {
return hostAllowList;
}
- /**
-
murblanc commented on code in PR #2834:
URL: https://github.com/apache/solr/pull/2834#discussion_r1827926712
##
solr/core/src/java/org/apache/solr/handler/designer/SchemaDesignerConfigSetHelper.java:
##
@@ -168,24 +167,12 @@ Map analyzeField(String configSet, String
fieldName,
[
https://issues.apache.org/jira/browse/SOLR-17497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895334#comment-17895334
]
ASF subversion and git services commented on SOLR-17497:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895333#comment-17895333
]
ASF subversion and git services commented on SOLR-17448:
Commit 4
dsmiley commented on code in PR #2834:
URL: https://github.com/apache/solr/pull/2834#discussion_r182794
##
solr/core/src/java/org/apache/solr/handler/designer/SchemaDesignerConfigSetHelper.java:
##
@@ -168,24 +167,12 @@ Map analyzeField(String configSet, String
fieldName, S
HoustonPutman commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-2455058672
Yes, that is absolutely related, but I thoroughly tested that before
pushing 🙄 I'll take a look.
--
This is an automated message from the Apache Git Service.
To respond to the mess
dsmiley commented on code in PR #2834:
URL: https://github.com/apache/solr/pull/2834#discussion_r1827951977
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -382,6 +383,7 @@ void setLiveNodes(Set liveNodes) {
* Be aware that this may return collec
[
https://issues.apache.org/jira/browse/SOLR-17487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Salagnac updated SOLR-17487:
---
Attachment: image.png
> Can't POST a dense vector that contains two or more occurences of the
[
https://issues.apache.org/jira/browse/SOLR-17487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Salagnac updated SOLR-17487:
---
Attachment: (was: image.png)
> Can't POST a dense vector that contains two or more occure
dsmiley commented on code in PR #2828:
URL: https://github.com/apache/solr/pull/2828#discussion_r1827982607
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBSolrClient.java:
##
@@ -699,11 +699,20 @@ public NamedList request(
if (e.getRootCause() instanceof IOE
dsmiley commented on code in PR #2832:
URL: https://github.com/apache/solr/pull/2832#discussion_r1827994098
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -233,6 +240,11 @@ public Builder(List zkHosts, Optional
zkChroot) {
if (z
malliaridis commented on PR #2725:
URL: https://github.com/apache/solr/pull/2725#issuecomment-2455326616
@epugh this one is ready I believe. The merge with main was ugly. >.<
I ended up with more lines added than removed, even though I have simplified
and removed redundant elements. T
malliaridis commented on PR #2725:
URL: https://github.com/apache/solr/pull/2725#issuecomment-2455332282
I didn't find any options that are mutually exclusive to use groups. This
was relevant for the deprecated options to simplify the `getOptionValue` with a
single option group. But since w
[
https://issues.apache.org/jira/browse/SOLR-15929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895377#comment-17895377
]
Christos Malliaridis commented on SOLR-15929:
-
We should also make sure that
Ivo Janssen created SOLR-17542:
--
Summary: AccessControlException when attempting to post document
Key: SOLR-17542
URL: https://issues.apache.org/jira/browse/SOLR-17542
Project: Solr
Issue Type:
dsmiley merged PR #2826:
URL: https://github.com/apache/solr/pull/2826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
malliaridis merged PR #2617:
URL: https://github.com/apache/solr/pull/2617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
[
https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895278#comment-17895278
]
Eric Pugh commented on SOLR-7871:
-
Hi all.. I'd like to take to another, but fresh run,
gerlowskija commented on code in PR #2811:
URL: https://github.com/apache/solr/pull/2811#discussion_r1827843121
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBSolrClient.java:
##
@@ -480,14 +480,35 @@ private static boolean isTimeExceeded(long
timeAllowedNano, long
gerlowskija commented on PR #2811:
URL: https://github.com/apache/solr/pull/2811#issuecomment-2454900565
> I know it's out of scope... sort of... but @iamsanjay recently updated
SolrClientNodeStateProvider.invoke to not call setBasePath but the result is
more lines of code / complexity than
psalagnac commented on code in PR #2737:
URL: https://github.com/apache/solr/pull/2737#discussion_r1827843673
##
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java:
##
@@ -221,24 +223,19 @@ public void call(ClusterState clusterState, ZkNodeProps
m
psalagnac commented on code in PR #2737:
URL: https://github.com/apache/solr/pull/2737#discussion_r1827855744
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractDistribZkTestBase.java:
##
@@ -242,45 +240,15 @@ public static void waitForCollectionToDisappear(
log.
psalagnac commented on code in PR #2737:
URL: https://github.com/apache/solr/pull/2737#discussion_r1827860425
##
solr/core/src/test/org/apache/solr/cloud/TestRebalanceLeaders.java:
##
@@ -604,74 +572,61 @@ private void forceUpdateCollectionStatus() {
// Since we have to res
jdyer1 commented on code in PR #2828:
URL: https://github.com/apache/solr/pull/2828#discussion_r1827873836
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java:
##
@@ -173,8 +173,8 @@ public NamedList request(SolrRequest
solrRequest, String collection
[
https://issues.apache.org/jira/browse/SOLR-16790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895260#comment-17895260
]
Eric Pugh commented on SOLR-16790:
--
I want to do a bit of Jira tidying, and get rid of t
[
https://issues.apache.org/jira/browse/SOLR-16790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-16790.
--
Resolution: Duplicate
I am marking this as a duplicate of SOLR-16757 and moved the child tickets over
Jason Gerlowski created SOLR-17541:
--
Summary: LBSolrClient implementations should agree on
'getClient()' semantics
Key: SOLR-17541
URL: https://issues.apache.org/jira/browse/SOLR-17541
Project: Solr
malliaridis opened a new pull request, #2845:
URL: https://github.com/apache/solr/pull/2845
* Update org.hamcrest:* to v3
* Update hamcrest license file
-
Co-authored-by: Christos Malliaridis
(cherry picked from commit f216c984d348c12cc4c4c24e24ee6bf014cc9b01)
murblanc commented on code in PR #2834:
URL: https://github.com/apache/solr/pull/2834#discussion_r1827322144
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -400,29 +402,14 @@ public Set getHostAllowList() {
return hostAllowList;
}
- /**
-
[
https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski reassigned SOLR-17256:
--
Assignee: Jason Gerlowski
> Remove SolrRequest.getBasePath setBasePath
> -
gerlowskija commented on PR #2811:
URL: https://github.com/apache/solr/pull/2811#issuecomment-2455573937
Tests and 'check' all look good; will aim to merge tomorrow pending any last
comments! Thanks @dsmiley for all the review!
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/SOLR-15929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895429#comment-17895429
]
Jan Høydahl edited comment on SOLR-15929 at 11/4/24 9:22 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-15929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895429#comment-17895429
]
Jan Høydahl edited comment on SOLR-15929 at 11/4/24 9:27 PM:
-
dsmiley merged PR #2762:
URL: https://github.com/apache/solr/pull/2762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley merged PR #2774:
URL: https://github.com/apache/solr/pull/2774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-17456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895443#comment-17895443
]
ASF subversion and git services commented on SOLR-17456:
Commit e
[
https://issues.apache.org/jira/browse/SOLR-17487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895390#comment-17895390
]
David Smiley commented on SOLR-17487:
-
Solr's [default
solrconfig.xml|https://github
malliaridis commented on code in PR #2725:
URL: https://github.com/apache/solr/pull/2725#discussion_r1828214894
##
solr/core/src/java/org/apache/solr/cli/ApiTool.java:
##
@@ -36,6 +36,16 @@
* Used to send an arbitrary HTTP request to a Solr API endpoint.
*/
public class Api
epugh commented on PR #2725:
URL: https://github.com/apache/solr/pull/2725#issuecomment-2455461246
I go back and forth on making everything a Java object.
`cli.getOption("my-option")` to me reads better than
`cli.getOption(MY_OPTION)`, having said that, I think the enhanced IDE
integratio
[
https://issues.apache.org/jira/browse/SOLR-15929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895417#comment-17895417
]
Christos Malliaridis commented on SOLR-15929:
-
What is the correct way for "M
[
https://issues.apache.org/jira/browse/SOLR-17487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Jactat closed SOLR-17487.
---
> Can't POST a dense vector that contains two or more occurences of the same
> float value
> ---
dsmiley commented on PR #2737:
URL: https://github.com/apache/solr/pull/2737#issuecomment-2455879410
Probably just a one-liner left and I'll merge away :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/SOLR-17456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895451#comment-17895451
]
ASF subversion and git services commented on SOLR-17456:
Commit 9
[
https://issues.apache.org/jira/browse/SOLR-17390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895446#comment-17895446
]
ASF subversion and git services commented on SOLR-17390:
Commit c
dsmiley commented on code in PR #2737:
URL: https://github.com/apache/solr/pull/2737#discussion_r1828513954
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractDistribZkTestBase.java:
##
@@ -242,45 +240,15 @@ public static void waitForCollectionToDisappear(
log.in
[
https://issues.apache.org/jira/browse/SOLR-17390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-17390.
-
Fix Version/s: 9.8
Resolution: Fixed
> EmbeddedSolrServer should support a ResponseParser
[
https://issues.apache.org/jira/browse/SOLR-17456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-17456.
-
Fix Version/s: 9.8
Assignee: David Smiley
Resolution: Fixed
> TransactionLog NPE
[
https://issues.apache.org/jira/browse/SOLR-17390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895452#comment-17895452
]
ASF subversion and git services commented on SOLR-17390:
Commit 3
malliaridis commented on PR #2725:
URL: https://github.com/apache/solr/pull/2725#issuecomment-2455611441
> I go back and forth on making everything a Java object.
cli.getOption("my-option") to me reads better than cli.getOption(MY_OPTION)
I agree on that, but I also feel that having l
[
https://issues.apache.org/jira/browse/SOLR-15929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895429#comment-17895429
]
Jan Høydahl edited comment on SOLR-15929 at 11/4/24 9:05 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-15929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895429#comment-17895429
]
Jan Høydahl commented on SOLR-15929:
I think we may need a spreadsheet with a line pe
[
https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895424#comment-17895424
]
Jan Høydahl commented on SOLR-7871:
---
As long as the bike shed is yaml I’m all in 🤣🤣🤣 Not
dsmiley commented on code in PR #2834:
URL: https://github.com/apache/solr/pull/2834#discussion_r1827774012
##
solr/core/src/java/org/apache/solr/handler/designer/SchemaDesignerConfigSetHelper.java:
##
@@ -168,24 +167,12 @@ Map analyzeField(String configSet, String
fieldName, S
dsmiley commented on code in PR #2811:
URL: https://github.com/apache/solr/pull/2811#discussion_r1827794290
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBSolrClient.java:
##
@@ -480,14 +480,35 @@ private static boolean isTimeExceeded(long
timeAllowedNano, long time
gerlowskija commented on code in PR #2811:
URL: https://github.com/apache/solr/pull/2811#discussion_r1827753327
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBSolrClient.java:
##
@@ -480,14 +480,35 @@ private static boolean isTimeExceeded(long
timeAllowedNano, long
gerlowskija commented on code in PR #2811:
URL: https://github.com/apache/solr/pull/2811#discussion_r1827753327
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBSolrClient.java:
##
@@ -480,14 +480,35 @@ private static boolean isTimeExceeded(long
timeAllowedNano, long
dsmiley commented on code in PR #2834:
URL: https://github.com/apache/solr/pull/2834#discussion_r1827771870
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -400,29 +402,14 @@ public Set getHostAllowList() {
return hostAllowList;
}
- /**
-
60 matches
Mail list logo
