jdyer1 commented on code in PR #2828:
URL: https://github.com/apache/solr/pull/2828#discussion_r1827873836
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java:
##########
@@ -173,8 +173,8 @@ public NamedList<Object> request(SolrRequest<?>
solrRequest, String collection)
"Timeout occurred while waiting response from server at: " +
pReq.url, e);
} catch (SolrException se) {
throw se;
- } catch (RuntimeException re) {
- throw new SolrServerException(re);
+ } catch (IOException | RuntimeException e) {
Review Comment:
Indeed, the doc-comment on the `LBSolrClient` request method says,
> If a request fails due to an IOException, the server is moved to the dead
pool
So I restored the previous behavior in `HttpJdkSolrClient` and made the
modification in `LBSolrClient`. This new behavior is covered by
`LBHttp2SolrClientIntegrationTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
