Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-09-14 Thread via GitHub
Willdotwhite commented on PR #2712: URL: https://github.com/apache/solr/pull/2712#issuecomment-2350932827 > We can put a call out to the community for testing on Windows... @Willdotwhite would you be interested in taking this PR for a spin on Windows? I'd be happy to, although I'm awa

Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-09-14 Thread via GitHub
epugh commented on PR #2712: URL: https://github.com/apache/solr/pull/2712#issuecomment-2350933829 > > We can put a call out to the community for testing on Windows... @Willdotwhite would you be interested in taking this PR for a spin on Windows? > > I'd be happy to, although I'm away

Re: [PR] Fix bugs in bin/solr in branch_9_7 [solr]

2024-09-14 Thread via GitHub
janhoy commented on code in PR #2710: URL: https://github.com/apache/solr/pull/2710#discussion_r1759754331 ## solr/core/src/java/org/apache/solr/cli/HealthcheckTool.java: ## @@ -170,7 +172,15 @@ protected void runCloudTool(CloudSolrClient cloudSolrClient, CommandLine cli) th

Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-09-14 Thread via GitHub
janhoy commented on code in PR #2712: URL: https://github.com/apache/solr/pull/2712#discussion_r1759757008 ## solr/core/src/java/org/apache/solr/cli/SolrProcessMgr.java: ## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribut

Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-09-14 Thread via GitHub
janhoy commented on code in PR #2712: URL: https://github.com/apache/solr/pull/2712#discussion_r1759757260 ## solr/core/src/java/org/apache/solr/cli/StatusTool.java: ## @@ -65,37 +74,119 @@ public String getName() { .desc("Wait up to the specified number of seconds to

Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-09-14 Thread via GitHub
janhoy commented on code in PR #2712: URL: https://github.com/apache/solr/pull/2712#discussion_r1759757460 ## solr/core/src/java/org/apache/solr/cli/StatusTool.java: ## @@ -65,37 +74,119 @@ public String getName() { .desc("Wait up to the specified number of seconds to

Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-09-14 Thread via GitHub
janhoy commented on code in PR #2712: URL: https://github.com/apache/solr/pull/2712#discussion_r1759758008 ## solr/core/src/java/org/apache/solr/cli/SolrProcessMgr.java: ## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribut

Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-09-14 Thread via GitHub
janhoy commented on PR #2712: URL: https://github.com/apache/solr/pull/2712#issuecomment-2351044545 I removed the RuntimePermission for `manageProcess` for runtime since I suspect it is only needed for tests, where we actually do spawn processes... Will revert that commit if the test fails.

Re: [PR] SOLR-17448: Audit usage of ExecutorService#submit in Solr codebase [solr]

2024-09-14 Thread via GitHub
AndreyBozhko commented on code in PR #2707: URL: https://github.com/apache/solr/pull/2707#discussion_r1759847806 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -729,14 +729,16 @@ public void preClose() { try { synchronized (collectionToTerms)

Re: [PR] SOLR-17448: Audit usage of ExecutorService#submit in Solr codebase [solr]

2024-09-14 Thread via GitHub
AndreyBozhko commented on code in PR #2707: URL: https://github.com/apache/solr/pull/2707#discussion_r1759847952 ## solr/core/src/test/org/apache/solr/cloud/TestConfigSetsAPI.java: ## @@ -936,7 +936,7 @@ private void testNewSingleFileAfterSchemaAPI(boolean v2) throws Exception

[jira] [Updated] (SOLR-13360) StringIndexOutOfBoundsException: String index out of range: -3

2024-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-13360: -- Labels: pull-request-available (was: ) > StringIndexOutOfBoundsException: String index out of

Re: [PR] SOLR-13360: Collation code fails with non-increasing token order [solr]

2024-09-14 Thread via GitHub
github-actions[bot] commented on PR #210: URL: https://github.com/apache/solr/pull/210#issuecomment-2351231656 This PR has had no activity for 60 days and is now labeled as stale. Any new activity or converting it to draft will remove the stale label. To attract more reviewers, please tag

[jira] [Commented] (SOLR-17449) bboxField subfield Error in atomic updating

2024-09-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881838#comment-17881838 ] David Smiley commented on SOLR-17449: - Thanks for reporting the bug. docValues isn't

Re: [PR] SOLR-17432: Allow OTel Java Agent [solr]

2024-09-14 Thread via GitHub
dsmiley commented on PR #2687: URL: https://github.com/apache/solr/pull/2687#issuecomment-2351370178 When I run the agent, I provide an Otel properties file with: (an excerpt) ``` otel.metrics.exporter=none otel.logs.exporter=none otel.instrumentation.common.default-enabled=false

Re: [PR] SOLR-17432: Allow OTel Java Agent [solr]

2024-09-14 Thread via GitHub
dsmiley commented on PR #2687: URL: https://github.com/apache/solr/pull/2687#issuecomment-2351373380 I'm a little unhappy with keeping TracerConfigurator named this while having it return an OpenTelemetry. Really; we're embracing OpenTelemetry here. I would love to use OpenTelemetry for m

Re: [PR] SOLR-6962: bin/solr stop/start/restart should complain about missing value for options that expect a value. [solr]

2024-09-14 Thread via GitHub
rahulgoswami commented on PR #2671: URL: https://github.com/apache/solr/pull/2671#issuecomment-2351383279 Opened PR https://github.com/epugh/solr/pull/10 against this branch currently below usage of -a in solr start doesn't raise any alert and starts solr successfully: solr st