AndreyBozhko commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1759847952


##########
solr/core/src/test/org/apache/solr/cloud/TestConfigSetsAPI.java:
##########
@@ -936,7 +936,7 @@ private void testNewSingleFileAfterSchemaAPI(boolean v2) 
throws Exception {
     String collectionName = "newcollection";
     String configsetName = "regular";
     String configsetSuffix = "testSinglePathNew-1-" + v2;
-    createConfigSet(null, configsetName + configsetSuffix, null, 
cluster.getSolrClient(), "solr");
+    uploadConfigSetWithAssertions(configsetName, configsetSuffix, "solr");

Review Comment:
   Good point @dsmiley  - my guess was wrong here.
   
   After looking into the test failure more, I realized the issue happens 
because the test adds a field to the schema. The schema modification triggers 
the ZkIndexSchemaReader$SchemaWatcher watch - but while the watch is running, 
the test may already finish and the test suite may start deleting configsets 
from ZK.
   
   I reverted the change to the test, and instead modified the SchemaWatcher 
code to gracefully handle such scenario.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to