Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-05-11 Thread via GitHub
kotman12 commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1597254706 ## solr/modules/monitor/src/java/org/apache/solr/monitor/update/MonitorUpdateRequestProcessor.java: ## @@ -0,0 +1,257 @@ +/* + * + * * Licensed to the Apache Software Fo

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-05-11 Thread via GitHub
kotman12 commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1597250682 ## solr/modules/monitor/src/java/org/apache/solr/monitor/update/MonitorUpdateRequestProcessor.java: ## @@ -0,0 +1,257 @@ +/* + * + * * Licensed to the Apache Software Fo

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-05-11 Thread via GitHub
kotman12 commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1597250682 ## solr/modules/monitor/src/java/org/apache/solr/monitor/update/MonitorUpdateRequestProcessor.java: ## @@ -0,0 +1,257 @@ +/* + * + * * Licensed to the Apache Software Fo

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-05-11 Thread via GitHub
kotman12 commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1597436656 ## solr/modules/monitor/src/java/org/apache/solr/monitor/update/MonitorUpdateRequestProcessor.java: ## @@ -0,0 +1,257 @@ +/* + * + * * Licensed to the Apache Software Fo

Re: [PR] Fix EncryptionUpdateLog.encryptLog() and its test. [solr-sandbox]

2024-05-11 Thread via GitHub
bruno-roustant commented on code in PR #105: URL: https://github.com/apache/solr-sandbox/pull/105#discussion_r1597443830 ## encryption/src/main/java/org/apache/solr/encryption/EncryptionTransactionLog.java: ## @@ -156,7 +169,7 @@ private static int readBEInt(ReadableByteChannel

Re: [PR] Refactore preparePutOrPost in HttpJdkSolrClient [solr]

2024-05-11 Thread via GitHub
andywebb1975 commented on code in PR #2454: URL: https://github.com/apache/solr/pull/2454#discussion_r1597474808 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java: ## @@ -299,10 +299,19 @@ private PreparedRequest preparePutOrPost( InputStream

[jira] [Updated] (SOLR-17263) HttpJdkSolrClient doesn't encode curly braces etc

2024-05-11 Thread Andy Webb (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Webb updated SOLR-17263: - Status: Patch Available (was: Open) > HttpJdkSolrClient doesn't encode curly braces etc > --

[jira] [Updated] (SOLR-17263) HttpJdkSolrClient doesn't encode curly braces etc

2024-05-11 Thread Andy Webb (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Webb updated SOLR-17263: - Fix Version/s: 9.6.1 > HttpJdkSolrClient doesn't encode curly braces etc > --

[jira] [Commented] (SOLR-17263) HttpJdkSolrClient doesn't encode curly braces etc

2024-05-11 Thread Andy Webb (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845630#comment-17845630 ] Andy Webb commented on SOLR-17263: -- [https://github.com/apache/solr/pull/2433] has a fix

[jira] [Commented] (SOLR-599) Lightweight SolrJ client

2024-05-11 Thread Andy Webb (Jira)
[ https://issues.apache.org/jira/browse/SOLR-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845631#comment-17845631 ] Andy Webb commented on SOLR-599: I've a fix ready in SOLR-17263 but I'm not sure how to pro

[PR] SOLR-17066 Fix ShardSplitTest & StressHdfsTest [solr]

2024-05-11 Thread via GitHub
dsmiley opened a new pull request, #2457: URL: https://github.com/apache/solr/pull/2457 SOLR-17066 broke some tests marked Nightly since the beginning of February; they didn't fail previously then they fail always. It's so sad we don't have mechanisms to bring our attention to something th