bruno-roustant commented on code in PR #105:
URL: https://github.com/apache/solr-sandbox/pull/105#discussion_r1597443830
##########
encryption/src/main/java/org/apache/solr/encryption/EncryptionTransactionLog.java:
##########
@@ -156,7 +169,7 @@ private static int readBEInt(ReadableByteChannel channel,
ByteBuffer readBuffer)
}
/** Supplies and releases {@link EncryptionDirectory}. */
- protected interface EncryptionDirectorySupplier {
+ public interface EncryptionDirectorySupplier {
Review Comment:
Not in this case, this interface is here to isolate the SolrCore needed to
get the EncryptionDirectory.
EncryptionUpdateLog knows the SolrCore, but does not pass it to the
EncryptionTransactionLog, instead it passes this interface. And the release
method calls DirectoryFactory.release(Directory), required when done with the
Directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
