epugh merged PR #2446:
URL: https://github.com/apache/solr/pull/2446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on PR #2446:
URL: https://github.com/apache/solr/pull/2446#issuecomment-2099880981
Code failure in precommit is also present in main, and known issue.. Thank
you for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
[
https://issues.apache.org/jira/browse/SOLR-17282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh reassigned SOLR-17282:
Assignee: Eric Pugh
> Update basic-authentication-plugin.adoc
> --
[
https://issues.apache.org/jira/browse/SOLR-17282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-17282.
--
Fix Version/s: 9.7
Resolution: Fixed
thank you for your attention to detail!
> Update basic-aut
epugh opened a new pull request, #2447:
URL: https://github.com/apache/solr/pull/2447
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Plea
hgdharold opened a new pull request, #2448:
URL: https://github.com/apache/solr/pull/2448
# Description
old code:
```// Checks if this node is the first (alphabetically) for a given host.
Used to decide rowspan in table
$scope.isFirstNodeForHost = function(node) {
var h
hgdharold closed pull request #2448: Solr Admin UI: fixed node list display bug
caused by different hostname with same front part
URL: https://github.com/apache/solr/pull/2448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
cpoerschke commented on PR #2308:
URL: https://github.com/apache/solr/pull/2308#issuecomment-2100327907
Looks like this matches https://issues.apache.org/jira/browse/SOLR-17283
ticket now then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
hgdharold opened a new pull request, #2449:
URL: https://github.com/apache/solr/pull/2449
# Description
old code:
```// Checks if this node is the first (alphabetically) for a given host.
Used to decide rowspan in table
$scope.isFirstNodeForHost = function(node) {
var hostN
Eric Pugh created SOLR-17284:
Summary: Remove deprecated Blobapi and runtime lib
Key: SOLR-17284
URL: https://issues.apache.org/jira/browse/SOLR-17284
Project: Solr
Issue Type: Improvement
epugh commented on PR #2447:
URL: https://github.com/apache/solr/pull/2447#issuecomment-2100532130
This started with me spelunking around the code base and chasing some small
typos, and then realized that this code was deprecated and we should remove it!
--
This is an automated message fr
epugh opened a new pull request, #2450:
URL: https://github.com/apache/solr/pull/2450
Fixing the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
gerlowskija commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1594016753
##
solr/core/src/test-files/solr/configsets/cloud-minimal-field-limiting/conf/solrconfig.xml:
##
@@ -0,0 +1,73 @@
+
+
+
+
+
+
+
+
+ ${solr.data.dir:}
+
+
+
+
+ $
dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1594018250
##
solr/core/src/test-files/solr/collection1/conf/solrconfig-follower-auth.xml:
##
Review Comment:
I won't push this point further because your ...WithAuth test uses
gerlowskija commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1594022421
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessorFactory.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software
epugh merged PR #2450:
URL: https://github.com/apache/solr/pull/2450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
cpoerschke commented on PR #2449:
URL: https://github.com/apache/solr/pull/2449#issuecomment-2100565504
Thanks for this contribution!
The `Gradle Precommit` CI failure looks unrelated and pre-existing and
@epugh is fixing it in #2450 pull request. Just FYI.
--
This is an automated
gerlowskija commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1594022421
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessorFactory.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software
epugh commented on PR #2450:
URL: https://github.com/apache/solr/pull/2450#issuecomment-2100567354
I am about to board plane home from LHR (@epugh :wave at @cpoerschke ) and I
*think* I have it sorted! Will check in a 6 hours ;-)
--
This is an automated message from the Apache Git Servic
gerlowskija commented on PR #2395:
URL: https://github.com/apache/solr/pull/2395#issuecomment-2100578628
Thanks for the change David - apologies for the back and forth trying to
understand what you were suggesting. I've merged your PR into this branch.
With that wrapped up, I'm going
rseitz commented on PR #2445:
URL: https://github.com/apache/solr/pull/2445#issuecomment-2100670514
@epugh About the name, I started with `SecurityUtils` but it seemed to
suggest a more general purpose than the intent of this class, and there are
zookeeper and eclipse classes with that same
dsmiley commented on PR #2276:
URL: https://github.com/apache/solr/pull/2276#issuecomment-2100741552
The most important part of Http2SolrClient to be re-used (instead of
re-created) is Jetty's HttpClient. Creating another Http2SolrClient that uses
an existing HttpClient isn't too bad but y
dsmiley commented on PR #2395:
URL: https://github.com/apache/solr/pull/2395#issuecomment-2100767344
Cool; please remember to mention me in CHANGES.txt. And thanks for adding
this protection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
gerlowskija merged PR #2395:
URL: https://github.com/apache/solr/pull/2395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
[
https://issues.apache.org/jira/browse/SOLR-17192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844702#comment-17844702
]
ASF subversion and git services commented on SOLR-17192:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-17192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844710#comment-17844710
]
ASF subversion and git services commented on SOLR-17192:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-17192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski resolved SOLR-17192.
Fix Version/s: main (10.0)
9.7
Resolution: Fixed
> Maximum-fields
dsmiley commented on PR #2276:
URL: https://github.com/apache/solr/pull/2276#issuecomment-2101217845
Unless I hear to the contrary, I'll commit this tonight like midnight EST.
Just "main" for a bit.
The CHANGES.txt is currently:
> SOLR-16505: Switch UpdateShardHandler.getReco
dsmiley commented on code in PR #105:
URL: https://github.com/apache/solr-sandbox/pull/105#discussion_r1594502634
##
encryption/src/main/java/org/apache/solr/encryption/EncryptionUpdateLog.java:
##
@@ -137,27 +151,45 @@ public synchronized boolean
areAllLogsEncryptedWithKeyId(S
[
https://issues.apache.org/jira/browse/SOLR-17192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844785#comment-17844785
]
David Smiley commented on SOLR-17192:
-
I saw that you listed my name first in CHANGES
janhoy merged PR #2308:
URL: https://github.com/apache/solr/pull/2308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
[
https://issues.apache.org/jira/browse/SOLR-17283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reassigned SOLR-17283:
--
Assignee: Jan Høydahl
> CVE-2024-25710: Upgrade Apache Commons Compress to 1.26
>
[
https://issues.apache.org/jira/browse/SOLR-17283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-17283.
Fix Version/s: 9.7
Resolution: Fixed
Fixed by solrBot PR, backported to branch_9x and branch
janhoy merged PR #2341:
URL: https://github.com/apache/solr/pull/2341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
eukaryote opened a new pull request, #2451:
URL: https://github.com/apache/solr/pull/2451
Fixes problems with the JsonLoader's parsing of atomic update values that
use multiple modifiers in a single update or reference a field name that
matches a modifier (like `set` or `add`).
https
[
https://issues.apache.org/jira/browse/SOLR-17274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844820#comment-17844820
]
Calvin Smith commented on SOLR-17274:
-
I made a PR: [https://github.com/apache/solr/p
kotman12 commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1594844585
##
solr/modules/monitor/src/java/org/apache/solr/monitor/search/ReverseSearchComponent.java:
##
@@ -0,0 +1,192 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundatio
kotman12 commented on PR #2382:
URL: https://github.com/apache/solr/pull/2382#issuecomment-2101745053
> > ... Tangentially, I'd like to also support additional query parameters
on top of the query string, i.e. the `df` default field param, but I haven't
gotten to that yet (you'll notice tha
dsmiley commented on code in PR #2451:
URL: https://github.com/apache/solr/pull/2451#discussion_r1594846634
##
solr/core/src/test/org/apache/solr/update/processor/AtomicUpdatesJsonTest.java:
##
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
dsmiley commented on code in PR #1793:
URL: https://github.com/apache/solr/pull/1793#discussion_r1594858131
##
solr/solrj/build.gradle:
##
@@ -85,3 +94,73 @@ dependencies {
testImplementation 'org.apache.commons:commons-lang3'
testImplementation 'io.dropwizard.metrics:metr
dsmiley merged PR #2276:
URL: https://github.com/apache/solr/pull/2276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844857#comment-17844857
]
ASF subversion and git services commented on SOLR-16505:
Commit e
[
https://issues.apache.org/jira/browse/SOLR-17196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-17196.
-
Resolution: Duplicate
> Update IndexFetcher Class to Use Http2SolrClient
> --
[
https://issues.apache.org/jira/browse/SOLR-17196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844861#comment-17844861
]
David Smiley commented on SOLR-17196:
-
In retrospect, SOLR-16505 was so much work tha
David Smiley created SOLR-17285:
---
Summary: Move RemoteSolrException to SolrClient in v10
Key: SOLR-17285
URL: https://issues.apache.org/jira/browse/SOLR-17285
Project: Solr
Issue Type: Sub-task
45 matches
Mail list logo
