rseitz commented on PR #2445: URL: https://github.com/apache/solr/pull/2445#issuecomment-2100670514
@epugh About the name, I started with `SecurityUtils` but it seemed to suggest a more general purpose than the intent of this class, and there are zookeeper and eclipse classes with that same name. Some other ideas that come to mind are `SampleSecurityJson`, `SecurityJsonTestUtils`, `SecurityJsonUtils`, `SecurityJsonConstants`, `SecurityConstants`, `SecurityTestConstants` and so on. Some of those would mean a longer name for the actual string constant containing the json, for example, if we go with `SecurityConstants` as the class name, we'd need something like `SecurityConstants.SIMPLE_SECURITY_JSON` I figured that SecurityJson.SIMPLE was the most concise and someone could further understand the intent by seeing "util" in the package name and seeing that it's in the "test-framework" tree. If I had to pick one of the other options, I think I'd pick `SecurityJsonConstants`. Let me know if you have a preference or any other suggestions. Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
