mariemat commented on code in PR #286:
URL: https://github.com/apache/solr/pull/286#discussion_r1507246777
##
solr/core/src/test/org/apache/solr/cloud/TestShardsInfoResponse.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
psalagnac commented on code in PR #286:
URL: https://github.com/apache/solr/pull/286#discussion_r1507250522
##
solr/core/src/test/org/apache/solr/cloud/TestShardsInfoResponse.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
[
https://issues.apache.org/jira/browse/SOLR-17160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822029#comment-17822029
]
Pierre Salagnac commented on SOLR-17160:
I added a max limit at 10K tracked reque
[
https://issues.apache.org/jira/browse/SOLR-17057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822031#comment-17822031
]
Dawid Weiss commented on SOLR-17057:
Thank you for fixing this, [~dsmiley]
> JSON Q
sigram merged PR #2290:
URL: https://github.com/apache/solr/pull/2290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
[
https://issues.apache.org/jira/browse/SOLR-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822101#comment-17822101
]
ASF subversion and git services commented on SOLR-17172:
Commit 2
tuannh982 opened a new pull request, #2322:
URL: https://github.com/apache/solr/pull/2322
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
sigram opened a new pull request, #2323:
URL: https://github.com/apache/solr/pull/2323
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
epugh merged PR #2319:
URL: https://github.com/apache/solr/pull/2319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on PR #2319:
URL: https://github.com/apache/solr/pull/2319#issuecomment-1971204679
Thanks for this, I've merged it! Keep those fixes coming!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
[
https://issues.apache.org/jira/browse/SOLR-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrzej Bialecki updated SOLR-17172:
Fix Version/s: 9.6.0
> Add QueryLimits termination to existing heavy SearchComponent-s
> --
[
https://issues.apache.org/jira/browse/SOLR-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrzej Bialecki updated SOLR-17172:
Component/s: Query Limits
> Add QueryLimits termination to existing heavy SearchComponent-s
[
https://issues.apache.org/jira/browse/SOLR-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrzej Bialecki resolved SOLR-17172.
-
Resolution: Fixed
> Add QueryLimits termination to existing heavy SearchComponent-s
> ---
[
https://issues.apache.org/jira/browse/SOLR-17182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrzej Bialecki updated SOLR-17182:
Component/s: Query Limits
> Eliminate the need for 'solr.useExitableDirectoryReader' syspro
VickieKarasic commented on PR #2319:
URL: https://github.com/apache/solr/pull/2319#issuecomment-1971413545
> Thanks for this, I've merged it! Keep those fixes coming!
Thanks @epugh!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
tuannh982 commented on code in PR #2322:
URL: https://github.com/apache/solr/pull/2322#discussion_r1507851176
##
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##
@@ -1166,6 +1166,181 @@ public static class ProcessedFilter {
* resolved against the filter c
tuannh982 commented on code in PR #2322:
URL: https://github.com/apache/solr/pull/2322#discussion_r1507851868
##
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##
@@ -1389,6 +1564,9 @@ private DocSet getResult(DocsEnumState deState, int
largestPossible) throw
janhoy closed pull request #1911: Update org.eclipse.jetty*:* (major)
URL: https://github.com/apache/solr/pull/1911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
janhoy commented on PR #1911:
URL: https://github.com/apache/solr/pull/1911#issuecomment-1971523097
Closing, as we'll upgrade to jetty 11 manually #1509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
janhoy merged PR #2267:
URL: https://github.com/apache/solr/pull/2267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy commented on PR #2047:
URL: https://github.com/apache/solr/pull/2047#issuecomment-1971765269
This upgrade was tricky. First, it did not compile unless upgrading
biz.aQute.bnd to v7.0.0. After that, the build fails, complaining about class
versions:
```
/home/runner/.gradle
epugh commented on code in PR #2321:
URL: https://github.com/apache/solr/pull/2321#discussion_r1508063854
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/expr/StreamExpressionParser.java:
##
@@ -132,17 +132,17 @@ private static StreamExpressionNamedParame
epugh commented on PR #2321:
URL: https://github.com/apache/solr/pull/2321#issuecomment-1971778835
Looking good...I see additional fix... I am running the tests... Let
me know when you feel it's "done done" ;-). and if the tests pass I'll commit.
--
This is an automated message f
rahulgoswami commented on PR #2321:
URL: https://github.com/apache/solr/pull/2321#issuecomment-1971788547
Yep that was the last bit. Good to go from my side unless there are
additional comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
rahulgoswami commented on PR #2321:
URL: https://github.com/apache/solr/pull/2321#issuecomment-1971794045
And thanks for taking time to review this Eric!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dsmiley commented on code in PR #2290:
URL: https://github.com/apache/solr/pull/2290#discussion_r1508080692
##
solr/core/src/java/org/apache/solr/handler/component/HighlightComponent.java:
##
@@ -164,6 +165,8 @@ public void process(ResponseBuilder rb) throws IOException {
dsmiley commented on code in PR #2290:
URL: https://github.com/apache/solr/pull/2290#discussion_r1508083954
##
solr/core/src/java/org/apache/solr/handler/component/ExpandComponent.java:
##
Review Comment:
You and I are old-timers here; we know getSlowAtomicReader won't be a
dsmiley merged PR #2318:
URL: https://github.com/apache/solr/pull/2318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
tuannh982 commented on code in PR #2322:
URL: https://github.com/apache/solr/pull/2322#discussion_r1507851176
##
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##
@@ -1166,6 +1166,181 @@ public static class ProcessedFilter {
* resolved against the filter c
tuannh982 closed pull request #2322: Draft - PoC execute FQs in parallel
URL: https://github.com/apache/solr/pull/2322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1508136097
##
solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java:
##
@@ -630,11 +628,8 @@ public final void doSyncOrReplicateRecovery(SolrCore core)
throws Exception {
dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1508138037
##
solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java:
##
@@ -175,8 +175,6 @@ public final void setRecoveringAfterStartup(boolean
recoveringAfterStartup) {
janhoy commented on PR #2047:
URL: https://github.com/apache/solr/pull/2047#issuecomment-1971897109
I see from https://github.com/apache/logging-log4j2/issues/2232 and other
discussions that log4j now tells users to include Log4j as `runtime` scope, not
compile scope, and not to interact pr
solrbot commented on PR #2047:
URL: https://github.com/apache/solr/pull/2047#issuecomment-1971903843
### Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not
recognize the last commit author and assumes somebody else may have edited the
PR.
solrbot opened a new pull request, #2324:
URL: https://github.com/apache/solr/pull/2324
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [org.eclipse.jetty.http2:http2-server](https://eclipse.dev/jetty)
([source](https://togithub.c
solrbot commented on PR #2324:
URL: https://github.com/apache/solr/pull/2324#issuecomment-1971911335
### ⚠ Artifact update problem
Renovate failed to update artifacts related to this branch. You probably do
not want to merge this PR as-is.
♻ Renovate will retry this branch, inc
janhoy closed pull request #2324: Update org.eclipse.jetty*:* (major)
URL: https://github.com/apache/solr/pull/2324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
github-actions[bot] commented on PR #1246:
URL: https://github.com/apache/solr/pull/1246#issuecomment-1972174490
This PR had no visible activity in the past 60 days, labeling it as stale.
Any new activity will remove the stale label. To attract more reviewers, please
tag someone or notify t
solrbot opened a new pull request, #2325:
URL: https://github.com/apache/solr/pull/2325
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [org.mockito:mockito-subclass](https://togithub.com/mockito/mockito) |
test | minor | `5.8.0`
solrbot opened a new pull request, #2326:
URL: https://github.com/apache/solr/pull/2326
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [org.eclipse.jetty.http2:http2-server](https://eclipse.dev/jetty)
([source](https://togithub.c
solrbot commented on PR #2326:
URL: https://github.com/apache/solr/pull/2326#issuecomment-1972282635
### ⚠ Artifact update problem
Renovate failed to update artifacts related to this branch. You probably do
not want to merge this PR as-is.
♻ Renovate will retry this branch, inc
David Smiley created SOLR-17189:
---
Summary: DockMakerTest.testRealisticUnicode fails from whitespace
assumption
Key: SOLR-17189
URL: https://issues.apache.org/jira/browse/SOLR-17189
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-17189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17189:
Description:
DockMakerTest.testRealisticUnicode fails 1-2% of the time --
[link|https://ge.apache.
dsmiley opened a new pull request, #2327:
URL: https://github.com/apache/solr/pull/2327
https://issues.apache.org/jira/browse/SOLR-17189
-Dsolr.bench.seed=1392507964231541
WIP. Didn't fix the problem yet but just tried to make the benchmark tests
actually repeatabl
dsmiley commented on code in PR #286:
URL: https://github.com/apache/solr/pull/286#discussion_r1508509359
##
solr/core/src/test/org/apache/solr/cloud/TestShardsInfoResponse.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * c
[
https://issues.apache.org/jira/browse/SOLR-11780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822391#comment-17822391
]
Nikhil commented on SOLR-11780:
---
Hi [~elyograg] [~janhoy]
Can you please review this
[
https://issues.apache.org/jira/browse/SOLR-17085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822393#comment-17822393
]
David Smiley commented on SOLR-17085:
-
What is the use-case where this is needed? I
[
https://issues.apache.org/jira/browse/SOLR-11780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822426#comment-17822426
]
Jan Høydahl commented on SOLR-11780:
Hi. Since httpcomponents is deprecated in solr a
48 matches
Mail list logo
