dsmiley commented on code in PR #2290:
URL: https://github.com/apache/solr/pull/2290#discussion_r1508080692
##########
solr/core/src/java/org/apache/solr/handler/component/HighlightComponent.java:
##########
@@ -164,6 +165,8 @@ public void process(ResponseBuilder rb) throws IOException {
// TODO ???? add this directly to the response?
rb.rsp.add(highlightingResponseField(), convertHighlights(sumData));
}
+ QueryLimits queryLimits = QueryLimits.getCurrentLimits();
+ queryLimits.maybeExitWithPartialResults("Highlighting process");
Review Comment:
If we add checks to SearchHandler for SearchComponent loops (as we agree
should happen) then it obsoletes your addition here in HighlightComponent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
