sigram commented on PR #81:
URL: https://github.com/apache/solr-sandbox/pull/81#issuecomment-1790406978
@markrmiller I'm not sure I understand everything of what's going on in
`sendBatch` with workUnit. However, using executor here seems wrong because
Kafka client is NOT thread-safe. If I'm
markrmiller commented on PR #81:
URL: https://github.com/apache/solr-sandbox/pull/81#issuecomment-1790415703
Been a little while since I've looked at that code, but ...
Yes, the Kafka client is not thread safe. The design is a single thread
polls the queue and hands off records to an
cpoerschke commented on PR #2030:
URL: https://github.com/apache/solr/pull/2030#issuecomment-1790659304
> ... only the file is stored as compacted ... model-store endpoint will
return a formatted JSON. ...
You're right. I'd assumed users would 'look' directly in ZooKeeper and
forgot
[
https://issues.apache.org/jira/browse/SOLR-17064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17064:
Description: See SOLR-15603 for background but didn't enable it. Here we
enable it. (was: See SOL
dsmiley commented on PR #2042:
URL: https://github.com/apache/solr/pull/2042#issuecomment-1790693082
It'd be nice if the target path for the scan could be configurable.
What's involved in having tests balance better across runners? Would that
make sense in a separate PR?
--
This i
clayburn commented on PR #2042:
URL: https://github.com/apache/solr/pull/2042#issuecomment-1790701240
> It'd be nice if the target path for the scan could be configurable.
As of now, the storage of the previous scan is really an implementation
detail to support the `buildScanPublishPr
dsmiley commented on PR #2042:
URL: https://github.com/apache/solr/pull/2042#issuecomment-1790738569
Cool; I'll merge tomorrow if I don't get any +1 sooner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
janhoy commented on PR #2059:
URL: https://github.com/apache/solr/pull/2059#issuecomment-1790874704
Thanks for review, will merge tomorrow (friday)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
janhoy commented on code in PR #2040:
URL: https://github.com/apache/solr/pull/2040#discussion_r1380254600
##
solr/core/src/java/org/apache/solr/security/Permission.java:
##
@@ -52,18 +53,21 @@ static Permission load(Map m) {
p.role = readValueAsSet(m, "role");
if (Per
epugh commented on PR #2030:
URL: https://github.com/apache/solr/pull/2030#issuecomment-1791121376
we really don't want our users actually poking around in ZooKeeper...It
really should be mediated by APIs and treated as an internal "implementation
details"!
--
This is an automate
[
https://issues.apache.org/jira/browse/SOLR-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782248#comment-17782248
]
Alex Deparvu commented on SOLR-6213:
adding to a very very old jira, but I just saw th
stillalex closed pull request #2026: [WIP] SOLR-17040 UpdateLog refactor to use
read/write locks
URL: https://github.com/apache/solr/pull/2026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
stillalex commented on PR #2026:
URL: https://github.com/apache/solr/pull/2026#issuecomment-1791360174
closing. benchmarks do not show improvements on this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
[
https://issues.apache.org/jira/browse/SOLR-17040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu resolved SOLR-17040.
-
Resolution: Won't Fix
> UpdateLog refactor to use read/write locks
>
[
https://issues.apache.org/jira/browse/SOLR-17040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782300#comment-17782300
]
Alex Deparvu commented on SOLR-17040:
-
thank you [~krisden] for the help here (especi
stillalex opened a new pull request, #2061:
URL: https://github.com/apache/solr/pull/2061
https://issues.apache.org/jira/browse/SOLR-16252
# Description
Trivial change to introduce a system property
`solr.schemaUpdateTimeoutSeconds` that defaults to original value `
[
https://issues.apache.org/jira/browse/SOLR-16252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu reassigned SOLR-16252:
---
Assignee: Alex Deparvu
> Server admins cannot override default value for UPDATE_TIMEOUT_SECS
[
https://issues.apache.org/jira/browse/SOLR-16252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16252:
Issue Type: Improvement (was: Bug)
> Server admins cannot override default value for UPDATE_TIMEOU
stillalex commented on code in PR #2041:
URL: https://github.com/apache/solr/pull/2041#discussion_r1380812192
##
solr/core/src/java/org/apache/solr/util/tracing/SolrHttpRequestCarrier.java:
##
Review Comment:
class renamed
##
solr/core/src/java/org/apache/solr/ut
stillalex commented on PR #2041:
URL: https://github.com/apache/solr/pull/2041#issuecomment-1791660915
did some manual testing and it looks ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dsmiley commented on code in PR #2041:
URL: https://github.com/apache/solr/pull/2041#discussion_r1381160995
##
solr/core/src/java/org/apache/solr/util/tracing/SolrJettyRequestCarrier.java:
##
@@ -22,13 +22,13 @@
import java.util.Map;
import org.eclipse.jetty.client.api.Request
[
https://issues.apache.org/jira/browse/SOLR-15782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782415#comment-17782415
]
David Smiley commented on SOLR-15782:
-
Perhaps we could establish that the following
22 matches
Mail list logo
