markrmiller commented on PR #81: URL: https://github.com/apache/solr-sandbox/pull/81#issuecomment-1790415703
Been a little while since I've looked at that code, but ... Yes, the Kafka client is not thread safe. The design is a single thread polls the queue and hands off records to an executor. That same polling queue also looks for work units that have finished. When all the work units before any given work unit is finished, the offsets are committed for that work unit. There shouldn't multiple threads using the client. The Kafka client is actually protected by a lock. It's just a lock that throws an exception if another thread has the lock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
