[PR] Prometheus Exporter: do not throw NullPointerException. [solr]

2023-11-01 Thread via GitHub
dsmiley opened a new pull request, #2057: URL: https://github.com/apache/solr/pull/2057 A minor improvement to avoid throwing an NPE and instead more clearly log an error. I've seen NPEs when trying to use "queryResponse" if we can't reach Solr, and I've noticed the same NPE reported

[jira] [Commented] (SOLR-17059) When ran Backup API, it doesn't create backup.properties file in backup path

2023-11-01 Thread Anusha R (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781760#comment-17781760 ] Anusha R commented on SOLR-17059: - We could see this error in logs while running backup a

[jira] [Comment Edited] (SOLR-17059) When ran Backup API, it doesn't create backup.properties file in backup path

2023-11-01 Thread Anusha R (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781760#comment-17781760 ] Anusha R edited comment on SOLR-17059 at 11/1/23 2:35 PM: -- We co

Re: [PR] SOLR-16907: Reserve some 8.x security permission names [solr]

2023-11-01 Thread via GitHub
janhoy commented on PR #2040: URL: https://github.com/apache/solr/pull/2040#issuecomment-1789075290 > In the issue you wanted to add a warning of an unknown permission occurred. Should we add this, too? Agree. The updated PR now instead of maintaining a list of old "reserved" permiss

[jira] [Commented] (SOLR-16907) Strange behaviour after upgrade to 9.x when security json has no longer existing permission

2023-11-01 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781768#comment-17781768 ] Jan Høydahl commented on SOLR-16907: Updated the PR with a generic approach of failin

[jira] [Created] (SOLR-17063) Do not buffer raw log params in LogWatcher

2023-11-01 Thread Michael Gibney (Jira)
Michael Gibney created SOLR-17063: - Summary: Do not buffer raw log params in LogWatcher Key: SOLR-17063 URL: https://issues.apache.org/jira/browse/SOLR-17063 Project: Solr Issue Type: Improve

[PR] SOLR-16961 Remove deprecated CircuitBreakerManager in 10.0 [solr]

2023-11-01 Thread via GitHub
janhoy opened a new pull request, #2059: URL: https://github.com/apache/solr/pull/2059 https://issues.apache.org/jira/browse/SOLR-16961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] SOLR-16397: Swap core v2 endpoints have been updated to be more REST-ful [solr]

2023-11-01 Thread via GitHub
iamsanjay opened a new pull request, #2060: URL: https://github.com/apache/solr/pull/2060 https://issues.apache.org/jira/browse/SOLR-16397 # Description V2(JAX-RS) Endpoints for core admin op "SWAP". # Solution Removed the older `SwapCoresAPI.java` clas

[jira] [Commented] (SOLR-16777) Schema Designer blindly "trusts" potentially malicious configset

2023-11-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781822#comment-17781822 ] ASF subversion and git services commented on SOLR-16777: Commit 4

Re: [PR] SOLR-16907: Reserve some 8.x security permission names [solr]

2023-11-01 Thread via GitHub
uschindler commented on code in PR #2040: URL: https://github.com/apache/solr/pull/2040#discussion_r1379023438 ## solr/core/src/java/org/apache/solr/security/Permission.java: ## @@ -160,7 +164,12 @@ public String toString() { return Utils.toJSONString(originalConfig); }

[jira] [Commented] (SOLR-16777) Schema Designer blindly "trusts" potentially malicious configset

2023-11-01 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781826#comment-17781826 ] Ishan Chattopadhyaya commented on SOLR-16777: - The other fix here by Houston

Re: [PR] SOLR-16907: Reserve some 8.x security permission names [solr]

2023-11-01 Thread via GitHub
uschindler commented on PR #2040: URL: https://github.com/apache/solr/pull/2040#issuecomment-1789319269 I font know internals of how the permissions work, so I only checked the code under the assumption that you know what a correct permission name looks like. Maybe cross check with @risdenk

[jira] [Reopened] (SOLR-17046) SchemaCodecFactory should be the implicit default if no is configured

2023-11-01 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter reopened SOLR-17046: --- Gah! ... i can't believe i forgot to update the ref-guide as part of this issue!?!?!?!?

Re: [PR] SOLR-15857: Add AWS Secret Manager support for ZK ACL credentials [solr]

2023-11-01 Thread via GitHub
laminelam commented on code in PR #1994: URL: https://github.com/apache/solr/pull/1994#discussion_r1366016833 ## solr/modules/aws-secret-provider/src/test/org/apache/solr/secret/zk/AWSSecretCredentialsProviderTest.java: ## @@ -0,0 +1,440 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Capture build scans on ge.apache.org to benefit from deep build insights [solr]

2023-11-01 Thread via GitHub
dsmiley commented on PR #2042: URL: https://github.com/apache/solr/pull/2042#issuecomment-1789737255 I see this enables [the build cache](https://docs.gradle.org/current/userguide/build_cache.html) by default, which hopefully is a big positive benefit, at the expense of some local disk and

Re: [PR] SOLR-16907: Reserve some 8.x security permission names [solr]

2023-11-01 Thread via GitHub
janhoy commented on code in PR #2040: URL: https://github.com/apache/solr/pull/2040#discussion_r1379365149 ## solr/core/src/java/org/apache/solr/security/Permission.java: ## @@ -52,18 +53,21 @@ static Permission load(Map m) { p.role = readValueAsSet(m, "role"); if (Per

[jira] [Commented] (SOLR-17046) SchemaCodecFactory should be the implicit default if no is configured

2023-11-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781906#comment-17781906 ] ASF subversion and git services commented on SOLR-17046: Commit e

[jira] [Created] (SOLR-17064) Build: Enable org.gradle.caching by default

2023-11-01 Thread David Smiley (Jira)
David Smiley created SOLR-17064: --- Summary: Build: Enable org.gradle.caching by default Key: SOLR-17064 URL: https://issues.apache.org/jira/browse/SOLR-17064 Project: Solr Issue Type: Improvemen

Re: [PR] Capture build scans on ge.apache.org to benefit from deep build insights [solr]

2023-11-01 Thread via GitHub
clayburn commented on PR #2042: URL: https://github.com/apache/solr/pull/2042#issuecomment-1789740972 > I see this enables [the build cache](https://docs.gradle.org/current/userguide/build_cache.html) by default, which hopefully is a big positive benefit, at the expense of some local disk

Re: [PR] SOLR-16907: Reserve some 8.x security permission names [solr]

2023-11-01 Thread via GitHub
uschindler commented on code in PR #2040: URL: https://github.com/apache/solr/pull/2040#discussion_r1379386158 ## solr/core/src/java/org/apache/solr/security/Permission.java: ## @@ -52,18 +53,21 @@ static Permission load(Map m) { p.role = readValueAsSet(m, "role"); if

Re: [PR] SOLR-16907: Reserve some 8.x security permission names [solr]

2023-11-01 Thread via GitHub
uschindler commented on code in PR #2040: URL: https://github.com/apache/solr/pull/2040#discussion_r1379387924 ## solr/core/src/java/org/apache/solr/security/Permission.java: ## @@ -52,18 +53,21 @@ static Permission load(Map m) { p.role = readValueAsSet(m, "role"); if

Re: [PR] SOLR-16907: Reserve some 8.x security permission names [solr]

2023-11-01 Thread via GitHub
uschindler commented on code in PR #2040: URL: https://github.com/apache/solr/pull/2040#discussion_r1379387924 ## solr/core/src/java/org/apache/solr/security/Permission.java: ## @@ -52,18 +53,21 @@ static Permission load(Map m) { p.role = readValueAsSet(m, "role"); if

Re: [PR] SOLR-16907: Reserve some 8.x security permission names [solr]

2023-11-01 Thread via GitHub
uschindler commented on PR #2040: URL: https://github.com/apache/solr/pull/2040#issuecomment-1789769580 Thanks for the change, looks fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[jira] [Commented] (SOLR-17046) SchemaCodecFactory should be the implicit default if no is configured

2023-11-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781918#comment-17781918 ] ASF subversion and git services commented on SOLR-17046: Commit 4

Re: [PR] SOLR-15857: Add AWS Secret Manager support for ZK ACL credentials [solr]

2023-11-01 Thread via GitHub
laminelam commented on code in PR #1994: URL: https://github.com/apache/solr/pull/1994#discussion_r1366016833 ## solr/modules/aws-secret-provider/src/test/org/apache/solr/secret/zk/AWSSecretCredentialsProviderTest.java: ## @@ -0,0 +1,440 @@ +/* + * Licensed to the Apache Softwar

[jira] [Resolved] (SOLR-17046) SchemaCodecFactory should be the implicit default if no is configured

2023-11-01 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter resolved SOLR-17046. --- Resolution: Fixed > SchemaCodecFactory should be the implicit default if no is > co

[jira] [Updated] (SOLR-17059) When ran Backup API, it doesn't create backup.properties file in backup path

2023-11-01 Thread Anusha R (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anusha R updated SOLR-17059: Description:   We are trying to backup indexes in Prod. It created snapshots in mentioned location. But it

[jira] [Updated] (SOLR-17059) When ran Backup API, it doesn't create backup.properties file in backup path

2023-11-01 Thread Anusha R (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anusha R updated SOLR-17059: Description:   We are trying to backup indexes in Prod. It created snapshots in mentioned location. But it

[jira] [Commented] (SOLR-16911) Strip out configurable hostContext

2023-11-01 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781707#comment-17781707 ] Jason Gerlowski commented on SOLR-16911: Created a PR to remove that one dangling