janhoy commented on PR #2040:
URL: https://github.com/apache/solr/pull/2040#issuecomment-1789075290
> In the issue you wanted to add a warning of an unknown permission
occurred. Should we add this, too?
Agree. The updated PR now instead of maintaining a list of old "reserved"
permission names, now adds a validation when parsing a permission that is not a
predefined one. The requirement is that it must contain one of these keys:
"method", "path", "params". I believe it is correct to assume that every custom
permission must contain one of those, am I correct.
In other words, a permission like this would be invalid:
```json
{ "name": "hello", "role": "admin", "collection": "test", "index": 1 }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
