janhoy commented on code in PR #1791:
URL: https://github.com/apache/solr/pull/1791#discussion_r1296859919
##
solr/webapp/web/js/angular/controllers/login.js:
##
@@ -60,92 +60,169 @@ solrAdminApp.controller('LoginController',
var hp = AuthenticationService.decodeHas
janhoy commented on code in PR #1791:
URL: https://github.com/apache/solr/pull/1791#discussion_r1296859919
##
solr/webapp/web/js/angular/controllers/login.js:
##
@@ -60,92 +60,169 @@ solrAdminApp.controller('LoginController',
var hp = AuthenticationService.decodeHas
janhoy commented on PR #1846:
URL: https://github.com/apache/solr/pull/1846#issuecomment-1682032468
> @janhoy just fyi. do you think it's worth backporting this to 9.x?
Yes, please do. Also, remember to add a CHANGES.txt entry under "Dependency
Upgrades", both on main branch and branc
janhoy commented on code in PR #1791:
URL: https://github.com/apache/solr/pull/1791#discussion_r1297041120
##
solr/webapp/web/js/angular/controllers/login.js:
##
@@ -60,92 +60,169 @@ solrAdminApp.controller('LoginController',
var hp = AuthenticationService.decodeHas
janhoy commented on code in PR #1791:
URL: https://github.com/apache/solr/pull/1791#discussion_r1296859919
##
solr/webapp/web/js/angular/controllers/login.js:
##
@@ -60,92 +60,169 @@ solrAdminApp.controller('LoginController',
var hp = AuthenticationService.decodeHas
epugh commented on PR #1829:
URL: https://github.com/apache/solr/pull/1829#issuecomment-1682110638
@xtenzQ I saw your comment about "workaround", and are you aware of the
effort to roll out new "proper RESTful" api's for Solr? These new V2 apis use
the proper http verbs, so deleting a man
stillalex commented on PR #1846:
URL: https://github.com/apache/solr/pull/1846#issuecomment-1682175622
> Also, remember to add a CHANGES.txt entry under "Dependency Upgrades",
Is that still necessary? I was looking at the automated dependency updates
from Renovate bot we have and thos
stillalex commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1682180045
> PS: Did you do a broader review of tag name changes apart from the two we
covered, or should we put it up as a new JIRA?
No review yet. I was thinking I could do one as part of SOL
xtenzQ commented on PR #1829:
URL: https://github.com/apache/solr/pull/1829#issuecomment-1682193207
> @xtenzQ I saw your comment about "workaround", and are you aware of the
effort to roll out new "proper RESTful" api's for Solr? These new V2 apis use
the proper http verbs, so deleting a ma
epugh commented on PR #1829:
URL: https://github.com/apache/solr/pull/1829#issuecomment-1682199329
> > @xtenzQ I saw your comment about "workaround", and are you aware of the
effort to roll out new "proper RESTful" api's for Solr? These new V2 apis use
the proper http verbs, so deleting a m
stillalex opened a new pull request, #1847:
URL: https://github.com/apache/solr/pull/1847
https://issues.apache.org/jira/browse/SOLR-X
# Description
CHANGES.txt update for https://github.com/apache/solr/pull/1846
# Solution
Please provide a short de
stillalex merged PR #1847:
URL: https://github.com/apache/solr/pull/1847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
stillalex commented on PR #1846:
URL: https://github.com/apache/solr/pull/1846#issuecomment-1682204172
ok I had misunderstood how that works. I forgot to add that entry, added it
as https://github.com/apache/solr/pull/1847
will backport to 9.x shortly
--
This is an automated message fr
janhoy commented on PR #1829:
URL: https://github.com/apache/solr/pull/1829#issuecomment-1682208053
> I could totally imagine that when we were putting the list of apis that
need migration together, that this one was missed!
@epugh Well, this managed resource API is the only legacy V1
janhoy commented on PR #1846:
URL: https://github.com/apache/solr/pull/1846#issuecomment-1682229640
Yea, no probn. The rule is that if you commit/push a dependency upgrade
manually, you have to add the entry yourself. If you merely merge a PR from
@solrbot then it will be added to CHANGES i
[
https://issues.apache.org/jira/browse/SOLR-16935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755539#comment-17755539
]
Alex Deparvu commented on SOLR-16935:
-
leaving a note here to also review tag names a
janhoy commented on PR #1807:
URL: https://github.com/apache/solr/pull/1807#issuecomment-1682236613
Fails with
- License file missing
('io.netty:netty-tcnative-boringssl-static:2.0.61.Final'), expected it at:
/home/runner/work/solr/solr/solr/licenses/netty-tcnative-boringssl-static-L
stillalex merged PR #1841:
URL: https://github.com/apache/solr/pull/1841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
[
https://issues.apache.org/jira/browse/SOLR-16536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755540#comment-17755540
]
ASF subversion and git services commented on SOLR-16536:
Commit 9
[
https://issues.apache.org/jira/browse/SOLR-16536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu resolved SOLR-16536.
-
Fix Version/s: main (10.0)
Resolution: Fixed
> Replace OpenTracing instrumentation with Op
xtenzQ commented on PR #1829:
URL: https://github.com/apache/solr/pull/1829#issuecomment-1682258831
> Why would we decode the entire URI? If we know that user-data is encoded,
we can do urlPath.split('/') and grab the last component as the word, then
decode it to find the synonym.
Ye
[
https://issues.apache.org/jira/browse/SOLR-16935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu reassigned SOLR-16935:
---
Assignee: Alex Deparvu
> Add spans to cover gaps in query processing
> -
noblepaul merged PR #1845:
URL: https://github.com/apache/solr/pull/1845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
[
https://issues.apache.org/jira/browse/SOLR-16939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755574#comment-17755574
]
ASF subversion and git services commented on SOLR-16939:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-16939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755575#comment-17755575
]
ASF subversion and git services commented on SOLR-16939:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-16939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul resolved SOLR-16939.
---
Fix Version/s: 9.4
Resolution: Fixed
> CBOR format should support nested documents
>
epugh commented on PR #1829:
URL: https://github.com/apache/solr/pull/1829#issuecomment-1682426128
Agreed that we should focus on this bugfix ;-), thanks @janhoy for pointing
that out. As far as what to do with this long term (configset versus managed
resources), that is probably a good d
risdenk commented on PR #1829:
URL: https://github.com/apache/solr/pull/1829#issuecomment-1682439872
I haven't spent much time looking into this but I noticed there were
questions about `/` and url encoding. Be aware that `%2F` (url encoded `/`) is
handled very differently between webserver
Houston Putman created SOLR-16940:
-
Summary: Allow users to pass system properties when running the
Solr tool.
Key: SOLR-16940
URL: https://issues.apache.org/jira/browse/SOLR-16940
Project: Solr
Houston Putman created SOLR-16941:
-
Summary: Improve Solr Host defaulting in the SolrCLI
Key: SOLR-16941
URL: https://issues.apache.org/jira/browse/SOLR-16941
Project: Solr
Issue Type: Sub-ta
gerlowskija commented on PR #1832:
URL: https://github.com/apache/solr/pull/1832#issuecomment-1682800074
> I mean that we shouldn't even run the tests at all. Disabling the security
manager for tests and saying "hey look on JDK 20 on Mac tests pass" but we just
hide the fact that we disable
HoustonPutman opened a new pull request, #1848:
URL: https://github.com/apache/solr/pull/1848
https://issues.apache.org/jira/browse/SOLR-16940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
HoustonPutman opened a new pull request, #1849:
URL: https://github.com/apache/solr/pull/1849
https://issues.apache.org/jira/browse/SOLR-16941
I've also updated one of the SSL tests to show that this works (defaulting
the scheme at least)
--
This is an automated message from the Ap
[
https://issues.apache.org/jira/browse/SOLR-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16929:
Description:
The exception message included by the SolrStream can sometimes be the encoded
(javabi
[
https://issues.apache.org/jira/browse/SOLR-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16929:
Description:
The exception message included by the SolrStream can sometimes be the encoded
(javabi
[
https://issues.apache.org/jira/browse/SOLR-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16929:
Description:
The exception message included by the SolrStream can sometimes be the encoded
(javabi
gerlowskija commented on PR #1832:
URL: https://github.com/apache/solr/pull/1832#issuecomment-1682886382
Alright, I've updated the PR in line with my comment above and previous
feedback. With these changes, the whole test run now fails with:
```
$ export "RUNTIME_JAVA_HOME=/usr/lo
laminelam closed pull request #1792: add support of OAuth 2.0/OIDC 'code with
PKCE' flow (back-end)
URL: https://github.com/apache/solr/pull/1792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/SOLR-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16929:
Description:
SOLR-15451 introduced a change where the exception message included by the
SolrStream
laminelam commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1297744193
##
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTIssuerConfig.java:
##
@@ -315,6 +327,24 @@ public JWTIssuerConfig setAuthorizationEndpoint(String
auth
laminelam commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1297745407
##
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java:
##
@@ -847,9 +851,11 @@ protected String generateAuthDataHeader() {
Map data = ne
laminelam commented on PR #1792:
URL: https://github.com/apache/solr/pull/1792#issuecomment-1682979852
> Looks overall good.
>
> Please do a stab on RefGuide docs. The ref guide should encourage the use
of code flow and warn that implicit flow support is deprecated.
>
> Perhaps
epugh commented on code in PR #1849:
URL: https://github.com/apache/solr/pull/1849#discussion_r1297751569
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -97,13 +97,13 @@ public class SolrCLI implements CLIO {
.required(false)
.desc(
laminelam commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1297744193
##
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTIssuerConfig.java:
##
@@ -315,6 +327,24 @@ public JWTIssuerConfig setAuthorizationEndpoint(String
auth
epugh commented on code in PR #1849:
URL: https://github.com/apache/solr/pull/1849#discussion_r1297753161
##
solr/packaging/test/test_ssl.bats:
##
@@ -54,8 +54,8 @@ teardown() {
solr start -c
solr assert --started https://localhost:8983/solr --timeout 5000
- run curl --
janhoy commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1297811474
##
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java:
##
@@ -847,9 +851,11 @@ protected String generateAuthDataHeader() {
Map data = new H
igiguere commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1297843290
##
solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java:
##
@@ -135,4 +177,10 @@ public static ErrorInfo getTypedErrorInfo(Throwable ex,
Logger log) {
erro
[
https://issues.apache.org/jira/browse/SOLR-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755762#comment-17755762
]
Alex Deparvu commented on SOLR-16929:
-
I originally started working on reverting the
48 matches
Mail list logo
