laminelam commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1297744193
##########
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTIssuerConfig.java:
##########
@@ -315,6 +327,24 @@ public JWTIssuerConfig setAuthorizationEndpoint(String
authorizationEndpoint) {
return this;
}
+ public String getTokenEndpoint() {
+ return tokenEndpoint;
+ }
+
+ public JWTIssuerConfig setTokenEndpoint(String tokenEndpoint) {
+ this.tokenEndpoint = tokenEndpoint;
+ return this;
+ }
+
+ public String getAuthorizationFlow() {
+ return authorizationFlow;
+ }
+
+ public JWTIssuerConfig setAuthorizationFlow(String authorizationFlow) {
+ this.authorizationFlow = authorizationFlow;
Review Comment:
I've added a validation test to _setAuthorizationFlow_. The reason I am not
doing it earlier is:
- I am following the same logic/style than the other methods (like
_setJwksUrl_)
- Adding it earlier would lead to too much verbose code for such basic test.
I have also set _implict_ as default. Will change the front-end code too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
