[jira] [Commented] (SOLR-8803) Generalize OOME handling to work for any OS

2023-07-17 Thread Ovidiu Mihalcea (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743656#comment-17743656 ] Ovidiu Mihalcea commented on SOLR-8803: --- [~houston] please see this comment (5 days

[jira] [Comment Edited] (SOLR-8803) Generalize OOME handling to work for any OS

2023-07-17 Thread Ovidiu Mihalcea (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743656#comment-17743656 ] Ovidiu Mihalcea edited comment on SOLR-8803 at 7/17/23 7:54 AM:

[jira] [Comment Edited] (SOLR-16894) Configurable doc freq: Allow StatsCache instances to be ResourceLoaderAware

2023-07-17 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743596#comment-17743596 ] Noble Paul edited comment on SOLR-16894 at 7/17/23 10:46 AM: -

[GitHub] [solr] epugh merged pull request #1784: SOLR-16842: Make "version" just another Tool.

2023-07-17 Thread via GitHub
epugh merged PR #1784: URL: https://github.com/apache/solr/pull/1784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-16842) Eliminate special case code in solrCLI by introducing VersionTool

2023-07-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743772#comment-17743772 ] ASF subversion and git services commented on SOLR-16842: Commit a

[jira] [Updated] (SOLR-16842) Eliminate special case code in solrCLI by introducing VersionTool

2023-07-17 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16842: - Fix Version/s: main (10.0) > Eliminate special case code in solrCLI by introducing VersionTool >

[jira] [Commented] (SOLR-16842) Eliminate special case code in solrCLI by introducing VersionTool

2023-07-17 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743774#comment-17743774 ] Eric Pugh commented on SOLR-16842: -- I will backport this to 9x when I see a clean run on

[jira] [Created] (SOLR-16895) Ensure Major Changes in Solr 10 Updated for CLI Changes

2023-07-17 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-16895: Summary: Ensure Major Changes in Solr 10 Updated for CLI Changes Key: SOLR-16895 URL: https://issues.apache.org/jira/browse/SOLR-16895 Project: Solr Issue Type: Sub-

[jira] [Resolved] (SOLR-16845) BinaryResponseWriter should not attempt cast to Utf8CharSequence

2023-07-17 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16845. --- Fix Version/s: 9.4 Assignee: Houston Putman Resolution: Fixed > BinaryRespons

[GitHub] [solr] HoustonPutman commented on pull request #1787: SOLR-16753: Fix PRS state update for splitShard

2023-07-17 Thread via GitHub
HoustonPutman commented on PR #1787: URL: https://github.com/apache/solr/pull/1787#issuecomment-1638262572 Any thoughts @noblepaul or @chatman ? Trying to get the next RC out soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Commented] (SOLR-8803) Generalize OOME handling to work for any OS

2023-07-17 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743822#comment-17743822 ] Shawn Heisey commented on SOLR-8803: bq. we had great options to choose exactly the me

[jira] [Commented] (SOLR-8803) Generalize OOME handling to work for any OS

2023-07-17 Thread Ovidiu Mihalcea (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743826#comment-17743826 ] Ovidiu Mihalcea commented on SOLR-8803: --- [~elyograg] I was referring to the commit [

[GitHub] [solr-operator] HoustonPutman opened a new pull request, #592: Upgrade kubernetes API for crash

2023-07-17 Thread via GitHub
HoustonPutman opened a new pull request, #592: URL: https://github.com/apache/solr-operator/pull/592 Fixes #583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [solr] stillalex opened a new pull request, #1789: SOLR-16265 reduce memory usage of ContentWriter based requests in Http2SolrClient

2023-07-17 Thread via GitHub
stillalex opened a new pull request, #1789: URL: https://github.com/apache/solr/pull/1789 https://issues.apache.org/jira/browse/SOLR-16265 # Description Please provide a short description of the changes you're making with this pull request. # Solution

[GitHub] [solr] sonatype-lift[bot] commented on pull request #1789: SOLR-16265 reduce memory usage of ContentWriter based requests in Http2SolrClient

2023-07-17 Thread via GitHub
sonatype-lift[bot] commented on PR #1789: URL: https://github.com/apache/solr/pull/1789#issuecomment-1638406118 ## Sonatype Lift is retiring Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointme

[jira] [Commented] (SOLR-16265) reduce memory usage of ContentWriter based requests in Http2SolrClient

2023-07-17 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743852#comment-17743852 ] Alex Deparvu commented on SOLR-16265: - I posted a PR for this change https://github.c

[GitHub] [solr] stillalex commented on pull request #1789: SOLR-16265 reduce memory usage of ContentWriter based requests in Http2SolrClient

2023-07-17 Thread via GitHub
stillalex commented on PR #1789: URL: https://github.com/apache/solr/pull/1789#issuecomment-1638426454 Attaching memory footprint of client side during indexing benchmark. While perf numbers are very similar, memory footprint definitely sees a drop. * main branch https://github

[GitHub] [solr-operator] HoustonPutman merged pull request #592: Upgrade kubernetes API for crash

2023-07-17 Thread via GitHub
HoustonPutman merged PR #592: URL: https://github.com/apache/solr-operator/pull/592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr-operator] HoustonPutman closed issue #583: Operator crash after update to v0.7.0

2023-07-17 Thread via GitHub
HoustonPutman closed issue #583: Operator crash after update to v0.7.0 URL: https://github.com/apache/solr-operator/issues/583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [solr-operator] HoustonPutman commented on issue #583: Operator crash after update to v0.7.0

2023-07-17 Thread via GitHub
HoustonPutman commented on issue #583: URL: https://github.com/apache/solr-operator/issues/583#issuecomment-1638493426 Fixed this. I'll start a v0.7.1 release soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Commented] (SOLR-16859) Missing Proxy support for Http2SolrClient

2023-07-17 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743882#comment-17743882 ] Alex Deparvu commented on SOLR-16859: - [~arkay] or [~stefan.pieper] could one of you

[jira] [Commented] (SOLR-16889) Rate Limiter should stop processing on 429

2023-07-17 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743885#comment-17743885 ] Alex Deparvu commented on SOLR-16889: - took another look at the part that was confusi

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1773: SOLR-16886: Don't commit multi-part uploads that have been aborted

2023-07-17 Thread via GitHub
HoustonPutman commented on code in PR #1773: URL: https://github.com/apache/solr/pull/1773#discussion_r1265638400 ## solr/modules/s3-repository/src/java/org/apache/solr/s3/S3OutputStream.java: ## @@ -200,6 +202,10 @@ public MultipartUpload(String uploadId) { } void u

[GitHub] [solr] tflobbe commented on a diff in pull request #1773: SOLR-16886: Don't commit multi-part uploads that have been aborted

2023-07-17 Thread via GitHub
tflobbe commented on code in PR #1773: URL: https://github.com/apache/solr/pull/1773#discussion_r1265658173 ## solr/modules/s3-repository/src/test/org/apache/solr/s3/S3OutputStreamMockitoTest.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1773: SOLR-16886: Don't commit multi-part uploads that have been aborted

2023-07-17 Thread via GitHub
HoustonPutman commented on code in PR #1773: URL: https://github.com/apache/solr/pull/1773#discussion_r1265666701 ## solr/modules/s3-repository/src/test/org/apache/solr/s3/S3OutputStreamMockitoTest.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [solr-operator] HoustonPutman commented on issue #583: Operator crash after update to v0.7.0

2023-07-17 Thread via GitHub
HoustonPutman commented on issue #583: URL: https://github.com/apache/solr-operator/issues/583#issuecomment-1638582713 @angelprada The release candidate is out to try, please let me know if the docker image `apache/solr-operator:v0.7.1-rc1` works for you. It should be a drop-in replacement

[GitHub] [solr-operator] angelprada commented on issue #583: Operator crash after update to v0.7.0

2023-07-17 Thread via GitHub
angelprada commented on issue #583: URL: https://github.com/apache/solr-operator/issues/583#issuecomment-1638604734 @HoustonPutman Tried and worked as expected! ``` 2023-07-17T17:46:46Z INFOsetup solr-operator Version: v0.7.1 2023-07-17T17:46:46Z INFOsetup solr-operat

[GitHub] [solr] madrob commented on pull request #1721: Add CodeQL workflow

2023-07-17 Thread via GitHub
madrob commented on PR #1721: URL: https://github.com/apache/solr/pull/1721#issuecomment-1638612681 @dsmiley Also relevant, I just saw that Lift is going away, so we'll need some replacement anyway. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [solr] patsonluk commented on pull request #1782: SOLR-16890: More test cases for Coordinator node role

2023-07-17 Thread via GitHub
patsonluk commented on PR #1782: URL: https://github.com/apache/solr/pull/1782#issuecomment-1638706476 Added extra unit test cases for Coordinator node. @noblepaul would you mind to take a look? Many thanks! -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [solr] HoustonPutman merged pull request #1777: SOLR-16856: Set autoSoftCommit for built-in configSets

2023-07-17 Thread via GitHub
HoustonPutman merged PR #1777: URL: https://github.com/apache/solr/pull/1777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[jira] [Commented] (SOLR-16856) Use autoSoftCommit with the default configSet

2023-07-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743942#comment-17743942 ] ASF subversion and git services commented on SOLR-16856: Commit 0

[jira] [Commented] (SOLR-16856) Use autoSoftCommit with the default configSet

2023-07-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743944#comment-17743944 ] ASF subversion and git services commented on SOLR-16856: Commit 5

[jira] [Commented] (SOLR-16856) Use autoSoftCommit with the default configSet

2023-07-17 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743946#comment-17743946 ] Houston Putman commented on SOLR-16856: --- {quote}It could be interesting if Solr sea

[jira] [Resolved] (SOLR-16856) Use autoSoftCommit with the default configSet

2023-07-17 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16856. --- Fix Version/s: 9.4 Assignee: Houston Putman Resolution: Implemented Added an

[GitHub] [solr] HoustonPutman merged pull request #1787: SOLR-16753: Fix PRS state update for splitShard

2023-07-17 Thread via GitHub
HoustonPutman merged PR #1787: URL: https://github.com/apache/solr/pull/1787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[jira] [Commented] (SOLR-16753) SplitShardWithNodeRoleTest.testSolrClusterWithNodeRoleWithPull failures

2023-07-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743960#comment-17743960 ] ASF subversion and git services commented on SOLR-16753: Commit 0

[jira] [Commented] (SOLR-16753) SplitShardWithNodeRoleTest.testSolrClusterWithNodeRoleWithPull failures

2023-07-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743962#comment-17743962 ] ASF subversion and git services commented on SOLR-16753: Commit 4

[GitHub] [solr] tflobbe merged pull request #1773: SOLR-16886: Don't commit multi-part uploads that have been aborted

2023-07-17 Thread via GitHub
tflobbe merged PR #1773: URL: https://github.com/apache/solr/pull/1773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-16753) SplitShardWithNodeRoleTest.testSolrClusterWithNodeRoleWithPull failures

2023-07-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743963#comment-17743963 ] ASF subversion and git services commented on SOLR-16753: Commit 4

[jira] [Commented] (SOLR-16886) S3OutputStream attempts to complete multi-part uploads even after they are aborted

2023-07-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743964#comment-17743964 ] ASF subversion and git services commented on SOLR-16886: Commit 4

[jira] [Commented] (SOLR-16886) S3OutputStream attempts to complete multi-part uploads even after they are aborted

2023-07-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743966#comment-17743966 ] ASF subversion and git services commented on SOLR-16886: Commit 0

[jira] [Resolved] (SOLR-16886) S3OutputStream attempts to complete multi-part uploads even after they are aborted

2023-07-17 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe resolved SOLR-16886. -- Fix Version/s: main (10.0) 9.4 Resolut

[GitHub] [solr] HoustonPutman merged pull request #1783: SOLR-16891: Fix blank Cloud graph screen in UI

2023-07-17 Thread via GitHub
HoustonPutman merged PR #1783: URL: https://github.com/apache/solr/pull/1783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[jira] [Commented] (SOLR-16891) Solr Cloud Graph screen blank

2023-07-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743971#comment-17743971 ] ASF subversion and git services commented on SOLR-16891: Commit 9

[jira] [Resolved] (SOLR-16753) SplitShardWithNodeRoleTest.testSolrClusterWithNodeRoleWithPull failures

2023-07-17 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16753. --- Assignee: Houston Putman (was: Noble Paul) Resolution: Fixed > SplitShardWithNodeRoleT

[jira] [Commented] (SOLR-16891) Solr Cloud Graph screen blank

2023-07-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743973#comment-17743973 ] ASF subversion and git services commented on SOLR-16891: Commit 8

[jira] [Commented] (SOLR-16891) Solr Cloud Graph screen blank

2023-07-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743974#comment-17743974 ] ASF subversion and git services commented on SOLR-16891: Commit d

[jira] [Resolved] (SOLR-16891) Solr Cloud Graph screen blank

2023-07-17 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16891. --- Assignee: Houston Putman Resolution: Fixed > Solr Cloud Graph screen blank > --

[GitHub] [solr] dsmiley commented on a diff in pull request #1780: SOLR-16889 Rate Limiter should stop processing on 429

2023-07-17 Thread via GitHub
dsmiley commented on code in PR #1780: URL: https://github.com/apache/solr/pull/1780#discussion_r1265907722 ## solr/core/src/java/org/apache/solr/servlet/ServletUtils.java: ## @@ -216,16 +217,19 @@ static void rateLimitRequest( } if (!accepted) { -String

[GitHub] [solr] stillalex commented on a diff in pull request #1780: SOLR-16889 Rate Limiter should stop processing on 429

2023-07-17 Thread via GitHub
stillalex commented on code in PR #1780: URL: https://github.com/apache/solr/pull/1780#discussion_r1265951622 ## solr/core/src/java/org/apache/solr/servlet/ServletUtils.java: ## @@ -216,16 +217,19 @@ static void rateLimitRequest( } if (!accepted) { -Strin

[GitHub] [solr] stillalex commented on a diff in pull request #1780: SOLR-16889 Rate Limiter should stop processing on 429

2023-07-17 Thread via GitHub
stillalex commented on code in PR #1780: URL: https://github.com/apache/solr/pull/1780#discussion_r1265957800 ## solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java: ## @@ -209,8 +208,8 @@ public void doFilter( Tracer t = getCores() == null ? GlobalTracer.get

[GitHub] [solr] noblepaul commented on pull request #1787: SOLR-16753: Fix PRS state update for splitShard

2023-07-17 Thread via GitHub
noblepaul commented on PR #1787: URL: https://github.com/apache/solr/pull/1787#issuecomment-1639049964 late to review . but the fix is correct -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [solr] dsmiley commented on a diff in pull request #1780: SOLR-16889 Rate Limiter should stop processing on 429

2023-07-17 Thread via GitHub
dsmiley commented on code in PR #1780: URL: https://github.com/apache/solr/pull/1780#discussion_r1266137594 ## solr/core/src/java/org/apache/solr/servlet/ServletUtils.java: ## @@ -216,16 +217,19 @@ static void rateLimitRequest( } if (!accepted) { -String

[GitHub] [solr] dsmiley commented on a diff in pull request #1780: SOLR-16889 Rate Limiter should stop processing on 429

2023-07-17 Thread via GitHub
dsmiley commented on code in PR #1780: URL: https://github.com/apache/solr/pull/1780#discussion_r1266141534 ## solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java: ## @@ -209,8 +208,8 @@ public void doFilter( Tracer t = getCores() == null ? GlobalTracer.get()

[GitHub] [solr] stillalex commented on a diff in pull request #1780: SOLR-16889 Rate Limiter should stop processing on 429

2023-07-17 Thread via GitHub
stillalex commented on code in PR #1780: URL: https://github.com/apache/solr/pull/1780#discussion_r1266161683 ## solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java: ## @@ -209,8 +208,8 @@ public void doFilter( Tracer t = getCores() == null ? GlobalTracer.get

[GitHub] [solr] stillalex commented on a diff in pull request #1780: SOLR-16889 Rate Limiter should stop processing on 429

2023-07-17 Thread via GitHub
stillalex commented on code in PR #1780: URL: https://github.com/apache/solr/pull/1780#discussion_r1266163119 ## solr/core/src/java/org/apache/solr/servlet/ServletUtils.java: ## @@ -216,16 +217,19 @@ static void rateLimitRequest( } if (!accepted) { -Strin

[jira] [Commented] (SOLR-16889) Rate Limiter should stop processing on 429

2023-07-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744058#comment-17744058 ] David Smiley commented on SOLR-16889: - Indeed, there should always be a Tracer (even

[GitHub] [solr] stillalex commented on pull request #1780: SOLR-16889 Rate Limiter should stop processing on 429

2023-07-17 Thread via GitHub
stillalex commented on PR #1780: URL: https://github.com/apache/solr/pull/1780#issuecomment-1639347134 Pushing a deeper refactoring. the cleanup will happen only once on a finally block inside the main entry method. I think the null tracer codepath is dead code, I don't see anywhere it coul

[GitHub] [solr] dsmiley closed pull request #1729: BackupRepository permit

2023-07-17 Thread via GitHub
dsmiley closed pull request #1729: BackupRepository permit URL: https://github.com/apache/solr/pull/1729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [solr] dsmiley merged pull request #1724: Refactor: move PerReplicaStatesFetcher code into PerReplicaStatesOps

2023-07-17 Thread via GitHub
dsmiley merged PR #1724: URL: https://github.com/apache/solr/pull/1724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[GitHub] [solr] dsmiley commented on a diff in pull request #1780: SOLR-16889 Rate Limiter should stop processing on 429

2023-07-17 Thread via GitHub
dsmiley commented on code in PR #1780: URL: https://github.com/apache/solr/pull/1780#discussion_r1266203328 ## solr/core/src/java/org/apache/solr/servlet/ServletUtils.java: ## @@ -197,35 +197,30 @@ static void configExcludes(PathExcluder excluder, String patternConfig) { *