stillalex commented on code in PR #1780:
URL: https://github.com/apache/solr/pull/1780#discussion_r1265957800
##########
solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java:
##########
@@ -209,8 +208,8 @@ public void doFilter(
Tracer t = getCores() == null ? GlobalTracer.get() :
getCores().getTracer();
request.setAttribute(Tracer.class.getName(), t);
RateLimitManager rateLimitManager =
coreService.getService().getRateLimitManager();
- request.setAttribute(RateLimitManager.class.getName(), rateLimitManager);
Review Comment:
luckily we have very good tooling support to show where a class is used
inside a project. I can 100% tell that this is not used anywhere else. Happy to
be shown different. I think this was just a partial/unfinished plan to do
something and it ended up in an awkward place where it is set as an attribute
instead of simply passing the ref.
I took the liberty to remove some of the tech debt by cleaning up some code
I saw was not clear, if this is putting too much burden on the review I will be
happy to revert, let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
