[jira] [Commented] (SOLR-16812) Support CBOR format for update/query

2023-07-11 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741919#comment-17741919 ] Noble Paul commented on SOLR-16812: --- if I add it to SolrJ , we are advertising that we

[GitHub] [solr] noblepaul commented on a diff in pull request #1762: SOLR-16871: Race condition in `CoordinatorHttpSolrCall` synthetic collection/replica init

2023-07-11 Thread via GitHub
noblepaul commented on code in PR #1762: URL: https://github.com/apache/solr/pull/1762#discussion_r1259459684 ## solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java: ## @@ -208,9 +208,12 @@ private static void setMDCLoggingContext(String collectionName) {

[GitHub] [solr] noblepaul commented on a diff in pull request #1762: SOLR-16871: Race condition in `CoordinatorHttpSolrCall` synthetic collection/replica init

2023-07-11 Thread via GitHub
noblepaul commented on code in PR #1762: URL: https://github.com/apache/solr/pull/1762#discussion_r1259459684 ## solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java: ## @@ -208,9 +208,12 @@ private static void setMDCLoggingContext(String collectionName) {

[GitHub] [solr] janhoy commented on pull request #1090: SOLR-16463: Workaround for serious crash on JDK17+

2023-07-11 Thread via GitHub
janhoy commented on PR #1090: URL: https://github.com/apache/solr/pull/1090#issuecomment-1630941731 > Does this fix still applies? The caffeine upgrade only adds loop timeout detection + crash log as far as I remember? But according to https://bugs.openjdk.org/browse/JDK-8285835 th

[jira] [Commented] (SOLR-8803) Generalize OOME handling to work for any OS

2023-07-11 Thread Ovidiu Mihalcea (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742036#comment-17742036 ] Ovidiu Mihalcea commented on SOLR-8803: --- In my experience, after running a dockerize

[jira] [Updated] (SOLR-16675) Introduce the possibility to rerank topK results with vector similarity functions using DenseVectorField

2023-07-11 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated SOLR-16675: Labels: vector-based-search (was: ) > Introduce the possibility to rerank topK res

[jira] [Updated] (SOLR-16674) DenseVectorField - Introduce support for 1 Byte precision vectors

2023-07-11 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated SOLR-16674: Labels: vector-based-search (was: ) > DenseVectorField - Introduce support for 1 B

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1773: SOLR-16886: Don't commit multi-part uploads that have been aborted

2023-07-11 Thread via GitHub
HoustonPutman commented on code in PR #1773: URL: https://github.com/apache/solr/pull/1773#discussion_r1259852063 ## solr/modules/s3-repository/src/java/org/apache/solr/s3/S3OutputStream.java: ## @@ -200,6 +202,10 @@ public MultipartUpload(String uploadId) { } void u

[jira] [Commented] (SOLR-8803) Generalize OOME handling to work for any OS

2023-07-11 Thread Ovidiu Mihalcea (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742049#comment-17742049 ] Ovidiu Mihalcea commented on SOLR-8803: --- Meanwhile, the workaround we found was to a

[jira] [Comment Edited] (SOLR-8803) Generalize OOME handling to work for any OS

2023-07-11 Thread Ovidiu Mihalcea (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742049#comment-17742049 ] Ovidiu Mihalcea edited comment on SOLR-8803 at 7/11/23 2:54 PM:

[GitHub] [solr] uschindler commented on pull request #1090: SOLR-16463: Workaround for serious crash on JDK17+

2023-07-11 Thread via GitHub
uschindler commented on PR #1090: URL: https://github.com/apache/solr/pull/1090#issuecomment-1630992701 > > Does this fix still applies? > > The caffeine upgrade only adds loop timeout detection + crash log as far as I remember? But according to https://bugs.openjdk.org/browse/JDK-828

[jira] [Commented] (SOLR-8803) Generalize OOME handling to work for any OS

2023-07-11 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742055#comment-17742055 ] Houston Putman commented on SOLR-8803: -- {quote}I can say that in general it is NOT a

[jira] [Commented] (SOLR-8803) Generalize OOME handling to work for any OS

2023-07-11 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742077#comment-17742077 ] Shawn Heisey commented on SOLR-8803: My solr server (running 9.4.0-SNAPSHOT) is not co

[jira] [Commented] (SOLR-8803) Generalize OOME handling to work for any OS

2023-07-11 Thread Ovidiu Mihalcea (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742086#comment-17742086 ] Ovidiu Mihalcea commented on SOLR-8803: --- ??Just to make sure I understand, the {{-XX

[jira] [Commented] (SOLR-8803) Generalize OOME handling to work for any OS

2023-07-11 Thread Ovidiu Mihalcea (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742091#comment-17742091 ] Ovidiu Mihalcea commented on SOLR-8803: --- [~elyograg], this is what I get on stdout i

[jira] [Comment Edited] (SOLR-8803) Generalize OOME handling to work for any OS

2023-07-11 Thread Ovidiu Mihalcea (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742091#comment-17742091 ] Ovidiu Mihalcea edited comment on SOLR-8803 at 7/11/23 4:26 PM:

[GitHub] [solr-operator] mariemat opened a new pull request, #588: Update README.md

2023-07-11 Thread via GitHub
mariemat opened a new pull request, #588: URL: https://github.com/apache/solr-operator/pull/588 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [solr] tflobbe commented on a diff in pull request #1773: SOLR-16886: Don't commit multi-part uploads that have been aborted

2023-07-11 Thread via GitHub
tflobbe commented on code in PR #1773: URL: https://github.com/apache/solr/pull/1773#discussion_r1260043257 ## solr/modules/s3-repository/src/java/org/apache/solr/s3/S3OutputStream.java: ## @@ -200,6 +202,10 @@ public MultipartUpload(String uploadId) { } void uploadP

[jira] [Updated] (SOLR-8803) Generalize OOME handling to work for any OS

2023-07-11 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-8803: --- Attachment: image-2023-07-11-11-38-58-247.png > Generalize OOME handling to work for any OS >

[jira] [Commented] (SOLR-8803) Generalize OOME handling to work for any OS

2023-07-11 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742116#comment-17742116 ] Shawn Heisey commented on SOLR-8803: It has been my experience that OOME is not an eph

[GitHub] [solr] tflobbe commented on pull request #1773: SOLR-16886: Don't commit multi-part uploads that have been aborted

2023-07-11 Thread via GitHub
tflobbe commented on PR #1773: URL: https://github.com/apache/solr/pull/1773#issuecomment-1631259126 > Nice catch. Is there a chance to cover it with some sort of unit test? I was trying to see if it was possible with `s3mock`, but I can't find a way to introduce failures. I could do

[jira] [Commented] (SOLR-16346) Generate OpenAPI spec for v2 APIs

2023-07-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742129#comment-17742129 ] David Smiley commented on SOLR-16346: - Why is the task named "resolve"? Shouldn't it

[GitHub] [solr] iamsanjay opened a new pull request, #1774: SOLR-16397: Create v2(JAX-RS) endpoints for RELOAD core

2023-07-11 Thread via GitHub
iamsanjay opened a new pull request, #1774: URL: https://github.com/apache/solr/pull/1774 https://issues.apache.org/jira/browse/SOLR-16397 # Description V2(JAX-RS) Endpoints for core admin op "RELOAD". # Solution There is already one class present in th

[jira] [Commented] (SOLR-16880) Make OpenAPI spec a release artifact

2023-07-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742136#comment-17742136 ] David Smiley commented on SOLR-16880: - +1 Maybe a separate issue, but I think it wou

[GitHub] [solr] iamsanjay commented on a diff in pull request #1774: SOLR-16397: Create v2(JAX-RS) endpoints for RELOAD core

2023-07-11 Thread via GitHub
iamsanjay commented on code in PR #1774: URL: https://github.com/apache/solr/pull/1774#discussion_r1260143597 ## solr/core/src/test/org/apache/solr/handler/admin/api/ReloadCoreAPITest.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [solr] iamsanjay commented on a diff in pull request #1774: SOLR-16397: Create v2(JAX-RS) endpoints for RELOAD core

2023-07-11 Thread via GitHub
iamsanjay commented on code in PR #1774: URL: https://github.com/apache/solr/pull/1774#discussion_r1260145100 ## solr/core/src/test/org/apache/solr/handler/admin/api/ReloadCoreAPITest.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[jira] [Comment Edited] (SOLR-16880) Make OpenAPI spec a release artifact

2023-07-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742136#comment-17742136 ] David Smiley edited comment on SOLR-16880 at 7/11/23 6:50 PM: -

[GitHub] [solr-operator] HoustonPutman commented on issue #579: Observed generation field addition in solr-operator code

2023-07-11 Thread via GitHub
HoustonPutman commented on issue #579: URL: https://github.com/apache/solr-operator/issues/579#issuecomment-1631442015 Yeah, given #560 , we will have a pretty good idea as to when operations start/end. This could certainly be implemented. It looks like it's following a similar paradigm to

[GitHub] [solr] patsonluk commented on a diff in pull request #1762: SOLR-16871: Race condition in `CoordinatorHttpSolrCall` synthetic collection/replica init

2023-07-11 Thread via GitHub
patsonluk commented on code in PR #1762: URL: https://github.com/apache/solr/pull/1762#discussion_r1260270218 ## solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java: ## @@ -208,9 +208,12 @@ private static void setMDCLoggingContext(String collectionName) {

[GitHub] [solr] patsonluk commented on a diff in pull request #1762: SOLR-16871: Race condition in `CoordinatorHttpSolrCall` synthetic collection/replica init

2023-07-11 Thread via GitHub
patsonluk commented on code in PR #1762: URL: https://github.com/apache/solr/pull/1762#discussion_r126020 ## solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java: ## @@ -208,9 +208,12 @@ private static void setMDCLoggingContext(String collectionName) {

[jira] [Commented] (SOLR-8803) Generalize OOME handling to work for any OS

2023-07-11 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742183#comment-17742183 ] Shawn Heisey commented on SOLR-8803: Creating a new issue for the intended change. >

[jira] [Created] (SOLR-16887) The new "Crash On Out Of Memory Error" capability breaks auto-restart on the docker container

2023-07-11 Thread Shawn Heisey (Jira)
Shawn Heisey created SOLR-16887: --- Summary: The new "Crash On Out Of Memory Error" capability breaks auto-restart on the docker container Key: SOLR-16887 URL: https://issues.apache.org/jira/browse/SOLR-16887

[jira] [Updated] (SOLR-16887) The new "Crash On Out Of Memory Error" capability breaks auto-restart on the docker container

2023-07-11 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-16887: Attachment: SOLR-16887.patch > The new "Crash On Out Of Memory Error" capability breaks auto-restar

[jira] [Commented] (SOLR-16887) The new "Crash On Out Of Memory Error" capability breaks auto-restart on the docker container

2023-07-11 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742192#comment-17742192 ] Shawn Heisey commented on SOLR-16887: - Patch attached.  This cleans up the logging a

[jira] [Comment Edited] (SOLR-8803) Generalize OOME handling to work for any OS

2023-07-11 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742183#comment-17742183 ] Shawn Heisey edited comment on SOLR-8803 at 7/11/23 9:57 PM: -

[jira] [Comment Edited] (SOLR-16887) The new "Crash On Out Of Memory Error" capability breaks auto-restart on the docker container

2023-07-11 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742192#comment-17742192 ] Shawn Heisey edited comment on SOLR-16887 at 7/11/23 9:58 PM: -

[jira] [Commented] (SOLR-16887) The new "Crash On Out Of Memory Error" capability breaks auto-restart on the docker container

2023-07-11 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742196#comment-17742196 ] Shawn Heisey commented on SOLR-16887: - Now running "./gradlew check". > The new "Cra

[jira] [Comment Edited] (SOLR-16887) The new "Crash On Out Of Memory Error" capability breaks auto-restart on the docker container

2023-07-11 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742196#comment-17742196 ] Shawn Heisey edited comment on SOLR-16887 at 7/11/23 10:05 PM:

[jira] [Comment Edited] (SOLR-16887) The new "Crash On Out Of Memory Error" capability breaks auto-restart on the docker container

2023-07-11 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742196#comment-17742196 ] Shawn Heisey edited comment on SOLR-16887 at 7/11/23 10:07 PM:

[jira] [Updated] (SOLR-16887) The new "Crash On Out Of Memory Error" capability breaks auto-restart on the docker container

2023-07-11 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-16887: Attachment: SOLR-16887-1.patch > The new "Crash On Out Of Memory Error" capability breaks auto-rest

[jira] [Commented] (SOLR-16887) The new "Crash On Out Of Memory Error" capability breaks auto-restart on the docker container

2023-07-11 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742202#comment-17742202 ] Shawn Heisey commented on SOLR-16887: - The check task revealed a bunch of immediate i

[GitHub] [solr] dsmiley opened a new pull request, #1775: SOLR-16507: SplitShardCmd shouldn't use NodeStateProvider

2023-07-11 Thread via GitHub
dsmiley opened a new pull request, #1775: URL: https://github.com/apache/solr/pull/1775 Back-porting SOLR-16507 to 9x. SplitShardCmd is then identical to main branch. main CHANGES.txt already has this, including CHANGES.txt in the 9.3 section. -- This is an automated message from the A

[jira] [Commented] (SOLR-16887) The new "Crash On Out Of Memory Error" capability breaks auto-restart on the docker container

2023-07-11 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742212#comment-17742212 ] Shawn Heisey commented on SOLR-16887: - Final patch that passes the `check` task. > T

[jira] [Updated] (SOLR-16887) The new "Crash On Out Of Memory Error" capability breaks auto-restart on the docker container

2023-07-11 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-16887: Attachment: SOLR-16887-2.patch > The new "Crash On Out Of Memory Error" capability breaks auto-rest

[jira] [Commented] (SOLR-16887) The new "Crash On Out Of Memory Error" capability breaks auto-restart on the docker container

2023-07-11 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742218#comment-17742218 ] Shawn Heisey commented on SOLR-16887: - I built a docker container from the patched so