[GitHub] [solr] risdenk commented on pull request #1701: Update dependency com.google.errorprone:error_prone_annotations to v2.20.0

2023-06-23 Thread via GitHub
risdenk commented on PR #1701: URL: https://github.com/apache/solr/pull/1701#issuecomment-1604222702 Need to evaluate these rules too: ``` [InlineTrivialConstant](https://errorprone.info/bugpattern/InlineTrivialConstant) [UnnecessaryStringBuilder](https://errorprone.info/bugpat

[GitHub] [solr] risdenk commented on pull request #1715: Update io.grpc:grpc-* to v1.56.0

2023-06-23 Thread via GitHub
risdenk commented on PR #1715: URL: https://github.com/apache/solr/pull/1715#issuecomment-1604228807 We can remove this specific versions.props constraint for grpc since its constrained by the google cloud bom and we have been keeping it up to date. -- This is an automated message from th

[GitHub] [solr] risdenk commented on pull request #1715: Update io.grpc:grpc-* to v1.56.0

2023-06-23 Thread via GitHub
risdenk commented on PR #1715: URL: https://github.com/apache/solr/pull/1715#issuecomment-1604231187 I stand corrected. I tried to remove the constraint and Google cloud bom only handles some grpc dependencies. ``` * What went wrong: A problem occurred configuring root proje

[GitHub] [solr] cpoerschke commented on pull request #1692: SOLR-16827: Add min/max scaling to the reranker

2023-06-23 Thread via GitHub
cpoerschke commented on PR #1692: URL: https://github.com/apache/solr/pull/1692#issuecomment-1604237314 Hi Joel - thanks for adding me as a reviewer! Unfortunately I don't have bandwidth to review here, sorry. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [solr] risdenk merged pull request #1714: Update dependency org.xerial.snappy:snappy-java to v1.1.10.1

2023-06-23 Thread via GitHub
risdenk merged PR #1714: URL: https://github.com/apache/solr/pull/1714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[GitHub] [solr] risdenk merged pull request #1715: Update io.grpc:grpc-* to v1.56.0

2023-06-23 Thread via GitHub
risdenk merged PR #1715: URL: https://github.com/apache/solr/pull/1715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[GitHub] [solr] risdenk merged pull request #1713: Update dependency io.swagger.core.v3:swagger-annotations to v2.2.12

2023-06-23 Thread via GitHub
risdenk merged PR #1713: URL: https://github.com/apache/solr/pull/1713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[GitHub] [solr] risdenk merged pull request #1712: Update dependency biz.aQute.bnd:biz.aQute.bnd.annotation to v6.4.1

2023-06-23 Thread via GitHub
risdenk merged PR #1712: URL: https://github.com/apache/solr/pull/1712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Created] (SOLR-16850) Flag to users that bin/solr heathcheck doesn't work with non solrcloud

2023-06-23 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-16850: Summary: Flag to users that bin/solr heathcheck doesn't work with non solrcloud Key: SOLR-16850 URL: https://issues.apache.org/jira/browse/SOLR-16850 Project: Solr

[GitHub] [solr] joel-bernstein merged pull request #1692: SOLR-16827: Add min/max scaling to the reranker

2023-06-23 Thread via GitHub
joel-bernstein merged PR #1692: URL: https://github.com/apache/solr/pull/1692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.ap

[jira] [Commented] (SOLR-16827) Add min/max scaling to the reranker

2023-06-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736541#comment-17736541 ] ASF subversion and git services commented on SOLR-16827: Commit 9

[GitHub] [solr] epugh commented on pull request #1670: SOLR-16829: Delegate arg parsing and help usage to java. (Round 1)

2023-06-23 Thread via GitHub
epugh commented on PR #1670: URL: https://github.com/apache/solr/pull/1670#issuecomment-1604503377 @Willdotwhite @mkhludnev so what is the best way to bring in the changes that both of you have made? https://github.com/apache/solr/compare/main...mkhludnev:solr:SOLR-16829 shows some great

[GitHub] [solr-operator] HoustonPutman commented on issue #579: Observed generation field addition in solr-operator code

2023-06-23 Thread via GitHub
HoustonPutman commented on issue #579: URL: https://github.com/apache/solr-operator/issues/579#issuecomment-1604512311 > Whenever we are describing the CustomResource deployed for a Solr cluster we should be able to display current status of cluster deployment such as Pending, Running or Fa

[jira] [Commented] (SOLR-16829) Refactor bin/solr and bin/solr.cmd to delegate usage help to SolrCLI

2023-06-23 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736548#comment-17736548 ] Eric Pugh commented on SOLR-16829: -- I am embarrassed to find this PR that [~willdotwhite

[GitHub] [solr-operator] HoustonPutman commented on a diff in pull request #571: Add SessionAffinity and SessionAffinityConfig fields to ServiceOptions

2023-06-23 Thread via GitHub
HoustonPutman commented on code in PR #571: URL: https://github.com/apache/solr-operator/pull/571#discussion_r1240023370 ## helm/solr/README.md: ## @@ -300,6 +300,8 @@ When using the helm chart, omit `customSolrKubeOptions.` | statefulSetOptions.podManagementPolicy | string | `

[GitHub] [solr-operator] HoustonPutman commented on pull request #571: Add SessionAffinity and SessionAffinityConfig fields to ServiceOptions

2023-06-23 Thread via GitHub
HoustonPutman commented on PR #571: URL: https://github.com/apache/solr-operator/pull/571#issuecomment-1604539222 Also just a thought, but we are giving users the option for the headlessService and podService, but those really don't need sessionAffinity, because they are meant to send reque

[GitHub] [solr-operator] HoustonPutman commented on pull request #578: Upgrading go-version to 1.20

2023-06-23 Thread via GitHub
HoustonPutman commented on PR #578: URL: https://github.com/apache/solr-operator/pull/578#issuecomment-1604539986 Thanks for the contribution @sujeeth62 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [solr-operator] HoustonPutman merged pull request #578: Upgrading go-version to 1.20

2023-06-23 Thread via GitHub
HoustonPutman merged PR #578: URL: https://github.com/apache/solr-operator/pull/578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr-operator] sujeeth62 commented on pull request #578: Upgrading go-version to 1.20

2023-06-23 Thread via GitHub
sujeeth62 commented on PR #578: URL: https://github.com/apache/solr-operator/pull/578#issuecomment-1604541359 > Thanks for the contribution @sujeeth62 ! Thank you for your support @HoustonPutman -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [solr-operator] HoustonPutman closed issue #570: Upgrade golang to v1.20

2023-06-23 Thread via GitHub
HoustonPutman closed issue #570: Upgrade golang to v1.20 URL: https://github.com/apache/solr-operator/issues/570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [solr-operator] HoustonPutman merged pull request #576: Document how a simple load balancer can be achieved through annotations on the commonServiceOptions

2023-06-23 Thread via GitHub
HoustonPutman merged PR #576: URL: https://github.com/apache/solr-operator/pull/576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] dsmiley commented on pull request #1718: SOLR-16848: fix race condition in DeleteReplicaTest

2023-06-23 Thread via GitHub
dsmiley commented on PR #1718: URL: https://github.com/apache/solr/pull/1718#issuecomment-1604628672 The precommit check failure is unrelated (Eric goof'ed usage of System.out and someone fixed it). The test failure is: ``` gradlew :solr:core:test --tests "org.apache.solr.cli.T

[GitHub] [solr] tflobbe merged pull request #1706: SOLR-16846: Use IndexOrDocValuesQuery for PointFields on Set queries

2023-06-23 Thread via GitHub
tflobbe merged PR #1706: URL: https://github.com/apache/solr/pull/1706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-16846) PointFields can use IndexOrDocValuesQuery in set queries when docValues are enabled

2023-06-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736591#comment-17736591 ] ASF subversion and git services commented on SOLR-16846: Commit 3

[jira] [Resolved] (SOLR-10034) PointField could leverage IndexOrDocValuesQuery

2023-06-23 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe resolved SOLR-10034. -- Fix Version/s: 7.0 6.5 Resolution: Fix

[jira] [Commented] (SOLR-16846) PointFields can use IndexOrDocValuesQuery in set queries when docValues are enabled

2023-06-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736592#comment-17736592 ] ASF subversion and git services commented on SOLR-16846: Commit 4

[jira] [Resolved] (SOLR-16846) PointFields can use IndexOrDocValuesQuery in set queries when docValues are enabled

2023-06-23 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe resolved SOLR-16846. -- Fix Version/s: main (10.0) 9.3 Resolut

[GitHub] [solr] mlbiscoc commented on a diff in pull request #1704: SOLR-16470 : Create V2 equivalent of V1 Replication: GET files

2023-06-23 Thread via GitHub
mlbiscoc commented on code in PR #1704: URL: https://github.com/apache/solr/pull/1704#discussion_r1240174113 ## solr/core/src/java/org/apache/solr/handler/admin/api/CoreReplicationAPI.java: ## @@ -46,12 +50,24 @@ public CoreReplicationAPI(SolrCore solrCore, SolrQueryRequest req

[GitHub] [solr] tflobbe commented on pull request #1705: SOLR-16841 QueryResponseWriter benchmarks

2023-06-23 Thread via GitHub
tflobbe commented on PR #1705: URL: https://github.com/apache/solr/pull/1705#issuecomment-1604759432 Thanks @stillalex. I've pushed a rebase after resolving conflicts. These are my numbers right now, they seem much slower, but also some discrepancies in the relative speeds: ``` Benchm

[jira] [Created] (SOLR-16851) Use IndexOrDocValuesQuery for Set queries on string fields when docValues are enabled

2023-06-23 Thread Tomas Eduardo Fernandez Lobbe (Jira)
Tomas Eduardo Fernandez Lobbe created SOLR-16851: Summary: Use IndexOrDocValuesQuery for Set queries on string fields when docValues are enabled Key: SOLR-16851 URL: https://issues.apache.org/jira/

[GitHub] [solr] stillalex commented on pull request #1705: SOLR-16841 QueryResponseWriter benchmarks

2023-06-23 Thread via GitHub
stillalex commented on PR #1705: URL: https://github.com/apache/solr/pull/1705#issuecomment-1604894849 thank you @tflobbe! maybe it's time for a HW upgrade 🚅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Created] (SOLR-16852) Let backups have custom key/values

2023-06-23 Thread Tomas Eduardo Fernandez Lobbe (Jira)
Tomas Eduardo Fernandez Lobbe created SOLR-16852: Summary: Let backups have custom key/values Key: SOLR-16852 URL: https://issues.apache.org/jira/browse/SOLR-16852 Project: Solr

[jira] [Commented] (SOLR-16841) QueryResponseWriter benchmarks

2023-06-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736626#comment-17736626 ] ASF subversion and git services commented on SOLR-16841: Commit d

[GitHub] [solr] tflobbe merged pull request #1705: SOLR-16841 QueryResponseWriter benchmarks

2023-06-23 Thread via GitHub
tflobbe merged PR #1705: URL: https://github.com/apache/solr/pull/1705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-16841) QueryResponseWriter benchmarks

2023-06-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736627#comment-17736627 ] ASF subversion and git services commented on SOLR-16841: Commit 8