mlbiscoc commented on code in PR #1704: URL: https://github.com/apache/solr/pull/1704#discussion_r1240174113
########## solr/core/src/java/org/apache/solr/handler/admin/api/CoreReplicationAPI.java: ########## @@ -46,12 +50,24 @@ public CoreReplicationAPI(SolrCore solrCore, SolrQueryRequest req, SolrQueryResp @GET @Path("/indexversion") - @Produces({"application/json", "application/xml", BINARY_CONTENT_TYPE_V2}) + @Produces({MediaType.APPLICATION_JSON, MediaType.APPLICATION_XML, BINARY_CONTENT_TYPE_V2}) @PermissionName(CORE_READ_PERM) public IndexVersionResponse fetchIndexVersion() throws IOException { return doFetchIndexVersion(); } + @GET + @Path("/files/generation/{gen}") + @Produces({MediaType.APPLICATION_JSON, MediaType.APPLICATION_XML, BINARY_CONTENT_TYPE_V2}) + @PermissionName(CORE_READ_PERM) + public NamedList<Object> fetchFiles( Review Comment: Changed the method name and returned a POJO object of a strongly typed class. Also updated the tests to reflect that. Let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org