[jira] [Commented] (SOLR-16753) SplitShardWithNodeRoleTest.testSolrClusterWithNodeRoleWithPull failures

2023-05-09 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720843#comment-17720843 ] Noble Paul commented on SOLR-16753: --- Is it possible to trace this to any particular com

[GitHub] [solr] cpoerschke commented on a diff in pull request #1570: Move duplicated code to method in TaskManagementHandler.java

2023-05-09 Thread via GitHub
cpoerschke commented on code in PR #1570: URL: https://github.com/apache/solr/pull/1570#discussion_r1188282152 ## solr/solrj/src/java/org/apache/solr/common/params/ModifiableSolrParams.java: ## @@ -175,6 +177,18 @@ public boolean remove(String name, String value) { // ---

[jira] [Created] (SOLR-16794) Return exit codes from CLI tools

2023-05-09 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-16794: Summary: Return exit codes from CLI tools Key: SOLR-16794 URL: https://issues.apache.org/jira/browse/SOLR-16794 Project: Solr Issue Type: Sub-task Componen

[jira] [Updated] (SOLR-16794) Return exit codes from CLI tools

2023-05-09 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16794: - Description: In review of https://github.com/apache/solr/pull/1600, [~krisden] noticed that the exit cod

[GitHub] [solr] epugh commented on a diff in pull request #1600: SOLR-16760: bin/solr package support the -h and -help commands like other tools

2023-05-09 Thread via GitHub
epugh commented on code in PR #1600: URL: https://github.com/apache/solr/pull/1600#discussion_r1188478363 ## solr/bin/solr: ## @@ -746,7 +750,6 @@ function run_tool() { # get status about any Solr nodes running on this host function get_status() { - CODE=4 Review Comment:

[GitHub] [solr] epugh merged pull request #1623: SOLR-16782: Export tool should export in JSON that matches Solr Import Format

2023-05-09 Thread via GitHub
epugh merged PR #1623: URL: https://github.com/apache/solr/pull/1623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Resolved] (SOLR-16782) Export tool should export in JSON that matches Solr Import Format

2023-05-09 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16782. -- Fix Version/s: main (10.0) 9.3 Resolution: Fixed > Export tool should export

[jira] [Commented] (SOLR-16782) Export tool should export in JSON that matches Solr Import Format

2023-05-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720897#comment-17720897 ] ASF subversion and git services commented on SOLR-16782: Commit a

[jira] [Commented] (SOLR-16782) Export tool should export in JSON that matches Solr Import Format

2023-05-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720898#comment-17720898 ] ASF subversion and git services commented on SOLR-16782: Commit e

[GitHub] [solr] epugh opened a new pull request, #1634: SOLR-6994: Integrate post tool into bin/solr and bin/solr.cmd

2023-05-09 Thread via GitHub
epugh opened a new pull request, #1634: URL: https://github.com/apache/solr/pull/1634 https://issues.apache.org/jira/browse/SSOLR-6994 # Description Get rid of the post.jar that hangs out, and instead use `bin/solr post` as the entry point. Move logic into the Java code t

[GitHub] [solr] dsmiley commented on a diff in pull request #1625: SOLR-16507: Refactor out ImplicitSnitch

2023-05-09 Thread via GitHub
dsmiley commented on code in PR #1625: URL: https://github.com/apache/solr/pull/1625#discussion_r1188562791 ## solr/solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientNodeStateProvider.java: ## @@ -221,110 +217,18 @@ static void fetchReplicaMetrics( @Overrid

[GitHub] [solr] epugh commented on pull request #1570: Factor out ModifiableSolrParams.setShardAttributesToParams method

2023-05-09 Thread via GitHub
epugh commented on PR #1570: URL: https://github.com/apache/solr/pull/1570#issuecomment-1540150494 @renatoh is this your first patch to solr? Normally small refactorings don't go into solr/CHANGES.txt, however when it's a new contributor, I like to mention them! Assuming that is okay, ho

[GitHub] [solr] gerlowskija commented on pull request #1594: SOLR-16392: Convert v2 shard, replica deletion to JAX-RS

2023-05-09 Thread via GitHub
gerlowskija commented on PR #1594: URL: https://github.com/apache/solr/pull/1594#issuecomment-1540172129 > Maybe we don't count it as a delete anymore, when the action is more of a scale. So `PUT /api/collections/Cn/replicas/scale?count=123` Thanks for the suggestion! I have so

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1622: SOLR-16661 Remove deprecated Analytics Component in 10.0

2023-05-09 Thread via GitHub
HoustonPutman commented on code in PR #1622: URL: https://github.com/apache/solr/pull/1622#discussion_r1188652908 ## solr/solr-ref-guide/modules/query-guide/pages/analytics-expression-sources.adoc: ## @@ -1,95 +0,0 @@ -= Analytics Expression Sources Review Comment: I believe

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1622: SOLR-16661 Remove deprecated Analytics Component in 10.0

2023-05-09 Thread via GitHub
HoustonPutman commented on code in PR #1622: URL: https://github.com/apache/solr/pull/1622#discussion_r1188656206 ## solr/core/src/java/org/apache/solr/handler/component/ResponseBuilder.java: ## @@ -60,7 +60,6 @@ public class ResponseBuilder { public boolean doExpand; publ

[GitHub] [solr] renatoh commented on a diff in pull request #1570: Factor out ModifiableSolrParams.setShardAttributesToParams method

2023-05-09 Thread via GitHub
renatoh commented on code in PR #1570: URL: https://github.com/apache/solr/pull/1570#discussion_r1188697934 ## solr/solrj/src/java/org/apache/solr/common/params/ModifiableSolrParams.java: ## @@ -175,6 +177,18 @@ public boolean remove(String name, String value) { // --

[GitHub] [solr] janhoy commented on a diff in pull request #1622: SOLR-16661 Remove deprecated Analytics Component in 10.0

2023-05-09 Thread via GitHub
janhoy commented on code in PR #1622: URL: https://github.com/apache/solr/pull/1622#discussion_r1188705713 ## solr/solr-ref-guide/modules/query-guide/pages/analytics-expression-sources.adoc: ## @@ -1,95 +0,0 @@ -= Analytics Expression Sources Review Comment: Ok, cool. We sho

[GitHub] [solr] janhoy commented on a diff in pull request #1622: SOLR-16661 Remove deprecated Analytics Component in 10.0

2023-05-09 Thread via GitHub
janhoy commented on code in PR #1622: URL: https://github.com/apache/solr/pull/1622#discussion_r1188708460 ## solr/solr-ref-guide/modules/query-guide/pages/analytics-expression-sources.adoc: ## @@ -1,95 +0,0 @@ -= Analytics Expression Sources Review Comment: Ok, cool. We sho

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1622: SOLR-16661 Remove deprecated Analytics Component in 10.0

2023-05-09 Thread via GitHub
HoustonPutman commented on code in PR #1622: URL: https://github.com/apache/solr/pull/1622#discussion_r1188714405 ## solr/solr-ref-guide/modules/query-guide/pages/analytics-expression-sources.adoc: ## @@ -1,95 +0,0 @@ -= Analytics Expression Sources Review Comment: Kind of,

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1622: SOLR-16661 Remove deprecated Analytics Component in 10.0

2023-05-09 Thread via GitHub
HoustonPutman commented on code in PR #1622: URL: https://github.com/apache/solr/pull/1622#discussion_r1188826368 ## solr/solr-ref-guide/modules/query-guide/pages/analytics-expression-sources.adoc: ## @@ -1,95 +0,0 @@ -= Analytics Expression Sources Review Comment: Ok this i

[jira] [Commented] (SOLR-14886) Suppress stack trace in Query response.

2023-05-09 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721002#comment-17721002 ] Isabelle Giguere commented on SOLR-14886: - To reproduce on Solr 9 (now that SOLR-

[jira] [Comment Edited] (SOLR-14886) Suppress stack trace in Query response.

2023-05-09 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721002#comment-17721002 ] Isabelle Giguere edited comment on SOLR-14886 at 5/9/23 4:46 PM: --

[jira] [Comment Edited] (SOLR-14886) Suppress stack trace in Query response.

2023-05-09 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721002#comment-17721002 ] Isabelle Giguere edited comment on SOLR-14886 at 5/9/23 4:46 PM: --

[jira] [Updated] (SOLR-16795) Upgrade gradle wrapper to 7.6.1

2023-05-09 Thread Letu Ren (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Letu Ren updated SOLR-16795: Description: Gradle 7.6.1 has been released. It is the first patch release for Gradle 7.6 and is recommend

[jira] [Created] (SOLR-16795) Upgrade gradle wrapper to 7.6.1

2023-05-09 Thread Letu Ren (Jira)
Letu Ren created SOLR-16795: --- Summary: Upgrade gradle wrapper to 7.6.1 Key: SOLR-16795 URL: https://issues.apache.org/jira/browse/SOLR-16795 Project: Solr Issue Type: Improvement Security Lev

[GitHub] [solr] HoustonPutman opened a new pull request, #1635: Add test with ssl and basic auth

2023-05-09 Thread via GitHub
HoustonPutman opened a new pull request, #1635: URL: https://github.com/apache/solr/pull/1635 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [solr-operator] fliphess commented on issue #497: solr prometheus exporter crashloopbackoff

2023-05-09 Thread via GitHub
fliphess commented on issue #497: URL: https://github.com/apache/solr-operator/issues/497#issuecomment-1540600036 I ran into a similar issue where the prometheus exporter kept crashing: Changing the CPU limits on the prometheus exporter did the trick for me: Otherwise every collection round

[GitHub] [solr] HoustonPutman commented on pull request #1203: introduce org.cyclonedx.bom gradle plugin

2023-05-09 Thread via GitHub
HoustonPutman commented on PR #1203: URL: https://github.com/apache/solr/pull/1203#issuecomment-1540644941 We should create a JIRA for this btw. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Commented] (SOLR-16795) Upgrade gradle wrapper to 7.6.1

2023-05-09 Thread Letu Ren (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721036#comment-17721036 ] Letu Ren commented on SOLR-16795: - There are some problems when running {{./gradle check

[GitHub] [solr] HoustonPutman merged pull request #1635: Add test with ssl and basic auth

2023-05-09 Thread via GitHub
HoustonPutman merged PR #1635: URL: https://github.com/apache/solr/pull/1635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[GitHub] [solr] janhoy commented on a diff in pull request #1622: SOLR-16661 Remove deprecated Analytics Component in 10.0

2023-05-09 Thread via GitHub
janhoy commented on code in PR #1622: URL: https://github.com/apache/solr/pull/1622#discussion_r1189023064 ## solr/solr-ref-guide/modules/query-guide/pages/analytics-expression-sources.adoc: ## @@ -1,95 +0,0 @@ -= Analytics Expression Sources Review Comment: We can always co

[GitHub] [solr] epugh merged pull request #1600: SOLR-16760: bin/solr package support the -h and -help commands like other tools

2023-05-09 Thread via GitHub
epugh merged PR #1600: URL: https://github.com/apache/solr/pull/1600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-16760) bin/solr package -h doesn't work

2023-05-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721093#comment-17721093 ] ASF subversion and git services commented on SOLR-16760: Commit 9

[jira] [Commented] (SOLR-16760) bin/solr package -h doesn't work

2023-05-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721094#comment-17721094 ] ASF subversion and git services commented on SOLR-16760: Commit b

[jira] [Resolved] (SOLR-16760) bin/solr package -h doesn't work

2023-05-09 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16760. -- Fix Version/s: main (10.0) 9.3 Resolution: Fixed > bin/solr package -h doesn'

[jira] [Resolved] (SOLR-16764) Be clearer that bin/solr export uses JSONL, not JSON format. Fix up how files are named and output and add tests.

2023-05-09 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16764. -- Fix Version/s: main (10.0) 9.3 Resolution: Fixed > Be clearer that bin/solr e

[jira] [Assigned] (SOLR-16764) Be clearer that bin/solr export uses JSONL, not JSON format. Fix up how files are named and output and add tests.

2023-05-09 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-16764: Assignee: Eric Pugh > Be clearer that bin/solr export uses JSONL, not JSON format. Fix up how >

[GitHub] [solr] renatoh commented on pull request #1570: Factor out ModifiableSolrParams.setShardAttributesToParams method

2023-05-09 Thread via GitHub
renatoh commented on PR #1570: URL: https://github.com/apache/solr/pull/1570#issuecomment-1540914303 @epugh I have done 2 or 3 very small commits before, e.g. fixing a typo or doing a minor change to 1 or 2 lines of code. Yes, that is OK, I would like to be referenced with my full name, w

[GitHub] [solr] epugh commented on pull request #1570: Factor out ModifiableSolrParams.setShardAttributesToParams method

2023-05-09 Thread via GitHub
epugh commented on PR #1570: URL: https://github.com/apache/solr/pull/1570#issuecomment-1540938494 I don't know why, but yeah, Crave gets confused at times... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [solr] epugh opened a new pull request, #1636: SOLR-16765: Export what the limit param specifies, and don't be off by one in the counter.

2023-05-09 Thread via GitHub
epugh opened a new pull request, #1636: URL: https://github.com/apache/solr/pull/1636 https://issues.apache.org/jira/browse/SOLR-16765 # Description export is off by one on the limit and the logic # Solution fix # Tests Please describe the tests you've develo

[GitHub] [solr] epugh commented on pull request #1636: SOLR-16765: Export what the limit param specifies, and don't be off by one in the counter.

2023-05-09 Thread via GitHub
epugh commented on PR #1636: URL: https://github.com/apache/solr/pull/1636#issuecomment-1541058531 This is ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Assigned] (SOLR-16765) Export tool doesn't properly count the number of exported docs.

2023-05-09 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-16765: Assignee: Eric Pugh > Export tool doesn't properly count the number of exported docs. > --

[jira] [Commented] (SOLR-13880) Collection creation fails with coreNodeName core_nodeX does not exist in shard

2023-05-09 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721200#comment-17721200 ] Ishan Chattopadhyaya commented on SOLR-13880: - This test is failing ever sinc