HoustonPutman commented on code in PR #1622:
URL: https://github.com/apache/solr/pull/1622#discussion_r1188656206
##########
solr/core/src/java/org/apache/solr/handler/component/ResponseBuilder.java:
##########
@@ -60,7 +60,6 @@ public class ResponseBuilder {
public boolean doExpand;
public boolean doStats;
public boolean doTerms;
- public boolean doAnalytics;
Review Comment:
Yeah unfortunately this was necessary at the time, although it is very
regrettable.
> From [SOLR-13511](https://issues.apache.org/jira/browse/SOLR-13511) I
understand that you can provide your own custom ResponseBuilder if you own the
SearchHandler. Fair enough, could be part of that plugin package.
Yeah, this seems like a pretty easy win. But a `Map<Sting,Object>
responseContext` would also work pretty easily. Basically there just needs to
be a way for SearchComponents to store customState in the response builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
