[jira] [Commented] (SOLR-16755) bin/solr's '-noprompt' option no longer works for examples

2023-04-19 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714058#comment-17714058 ] Jan Høydahl commented on SOLR-16755: The "right" fix would probably be using an array

[jira] [Assigned] (SOLR-16755) bin/solr's '-noprompt' option no longer works for examples

2023-04-19 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-16755: -- Assignee: Jan Høydahl > bin/solr's '-noprompt' option no longer works for examples >

[GitHub] [solr] janhoy opened a new pull request, #1576: SOLR-16755: bin/solr's '-noprompt' option no longer works for examples

2023-04-19 Thread via GitHub
janhoy opened a new pull request, #1576: URL: https://github.com/apache/solr/pull/1576 https://issues.apache.org/jira/browse/SOLR-16755 The new test fails with `# ERROR: No line found` without this patch. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Resolved] (SOLR-10888) almost self-generating python script(s) to access V2 APIs

2023-04-19 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-10888. Resolution: Won't Fix > almost self-generating python script(s) to access V2 APIs > ---

[GitHub] [solr] epugh commented on pull request #1568: SOLR-16711: Extract SolrCLI tool implementations into their own package and classes (Take 2)

2023-04-19 Thread via GitHub
epugh commented on PR #1568: URL: https://github.com/apache/solr/pull/1568#issuecomment-1514755448 > I haven't had time to review all of the changes (5k LOC 🤯 ), but things LGTM from the brief skimming I was able to do. > > I'd feel more confident in large refactors like this if the b

[jira] [Commented] (SOLR-16507) Remove NodeStateProvider & Snitch

2023-04-19 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714110#comment-17714110 ] Jason Gerlowski commented on SOLR-16507: bq. The V2 API situation is very much in

[GitHub] [solr] bqcuong commented on pull request #1575: SOLR-16752 Reduce attack surface and size for Docker image

2023-04-19 Thread via GitHub
bqcuong commented on PR #1575: URL: https://github.com/apache/solr/pull/1575#issuecomment-1514763484 Currently, there should be no removed packages for that apt-get install command. However, I think it is recommended to have `--no-intall-recommends` for the case that you want to add other p

[GitHub] [solr] HoustonPutman commented on pull request #1575: SOLR-16752 Reduce attack surface and size for Docker image

2023-04-19 Thread via GitHub
HoustonPutman commented on PR #1575: URL: https://github.com/apache/solr/pull/1575#issuecomment-1514789409 This looks good to me. If you want to add an entry to `solr/CHANGELOG.txt`, I think this should be good to go. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [solr] bqcuong commented on pull request #1575: SOLR-16752 Reduce attack surface and size for Docker image

2023-04-19 Thread via GitHub
bqcuong commented on PR #1575: URL: https://github.com/apache/solr/pull/1575#issuecomment-1514811016 I updated the Changelog in the newest commit. Please revise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [solr] HoustonPutman commented on pull request #1576: SOLR-16755: bin/solr's '-noprompt' option no longer works for examples

2023-04-19 Thread via GitHub
HoustonPutman commented on PR #1576: URL: https://github.com/apache/solr/pull/1576#issuecomment-1514815394 @janhoy used bash arrays instead of the string. We should also do this with `SOLR_SSL_OPTS` as it's the only other env to use `+=""`, but we can tackle that in a separate iss

[GitHub] [solr] janhoy commented on pull request #1576: SOLR-16755: bin/solr's '-noprompt' option no longer works for examples

2023-04-19 Thread via GitHub
janhoy commented on PR #1576: URL: https://github.com/apache/solr/pull/1576#issuecomment-1514830795 Thanks Houston. I removed the now obsolete shellcheck disable comment. Will commit and backport shortly -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [solr] epugh commented on a diff in pull request #1576: SOLR-16755: bin/solr's '-noprompt' option no longer works for examples

2023-04-19 Thread via GitHub
epugh commented on code in PR #1576: URL: https://github.com/apache/solr/pull/1576#discussion_r1171428345 ## solr/packaging/test/test_example_noprompt.bats: ## @@ -0,0 +1,36 @@ +#!/usr/bin/env bats + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contri

[GitHub] [solr] epugh commented on a diff in pull request #1576: SOLR-16755: bin/solr's '-noprompt' option no longer works for examples

2023-04-19 Thread via GitHub
epugh commented on code in PR #1576: URL: https://github.com/apache/solr/pull/1576#discussion_r1171429229 ## solr/packaging/test/test_example_noprompt.bats: ## @@ -0,0 +1,36 @@ +#!/usr/bin/env bats + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contri

[GitHub] [solr] janhoy commented on a diff in pull request #1576: SOLR-16755: bin/solr's '-noprompt' option no longer works for examples

2023-04-19 Thread via GitHub
janhoy commented on code in PR #1576: URL: https://github.com/apache/solr/pull/1576#discussion_r1171436635 ## solr/packaging/test/test_example_noprompt.bats: ## @@ -0,0 +1,36 @@ +#!/usr/bin/env bats + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contr

[GitHub] [solr] epugh commented on pull request #1568: SOLR-16711: Extract SolrCLI tool implementations into their own package and classes (Take 2)

2023-04-19 Thread via GitHub
epugh commented on PR #1568: URL: https://github.com/apache/solr/pull/1568#issuecomment-1514849013 > Huge improvement to split this up. LGTM although have not studied every change. > > Are there places where you did more than simply breaking classes out, where you'd like us to pay sp

[GitHub] [solr] janhoy commented on a diff in pull request #1575: SOLR-16752 Reduce attack surface and size for Docker image

2023-04-19 Thread via GitHub
janhoy commented on code in PR #1575: URL: https://github.com/apache/solr/pull/1575#discussion_r1171439968 ## solr/CHANGES.txt: ## @@ -91,6 +91,8 @@ Improvements /api/collections/collName/snapshots/snapshotName`, listed at `GET /api/collections/collName/snapshots`, and delet

[GitHub] [solr] janhoy commented on a diff in pull request #1575: SOLR-16752 Reduce attack surface and size for Docker image

2023-04-19 Thread via GitHub
janhoy commented on code in PR #1575: URL: https://github.com/apache/solr/pull/1575#discussion_r1171439968 ## solr/CHANGES.txt: ## @@ -91,6 +91,8 @@ Improvements /api/collections/collName/snapshots/snapshotName`, listed at `GET /api/collections/collName/snapshots`, and delet

[GitHub] [solr] janhoy merged pull request #1576: SOLR-16755: bin/solr's '-noprompt' option no longer works for examples

2023-04-19 Thread via GitHub
janhoy merged PR #1576: URL: https://github.com/apache/solr/pull/1576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-16755) bin/solr's '-noprompt' option no longer works for examples

2023-04-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714138#comment-17714138 ] ASF subversion and git services commented on SOLR-16755: Commit d

[jira] [Resolved] (SOLR-16755) bin/solr's '-noprompt' option no longer works for examples

2023-04-19 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16755. Fix Version/s: 9.3 9.2.1 Resolution: Fixed > bin/solr's '-noprompt' optio

[GitHub] [solr] janhoy commented on pull request #1568: SOLR-16711: Extract SolrCLI tool implementations into their own package and classes (Take 2)

2023-04-19 Thread via GitHub
janhoy commented on PR #1568: URL: https://github.com/apache/solr/pull/1568#issuecomment-1514869614 Yea, and the script changes is basically java package name change. Looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [solr] gerlowskija merged pull request #1572: SOLR-16391: Tweak "create coll" API to be more REST-ful

2023-04-19 Thread via GitHub
gerlowskija merged PR #1572: URL: https://github.com/apache/solr/pull/1572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[jira] [Commented] (SOLR-16391) Cosmetic improvements and migration to JAX-RS (collection, collection prop, core CRUD APIs)

2023-04-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714141#comment-17714141 ] ASF subversion and git services commented on SOLR-16391: Commit a

[jira] [Commented] (SOLR-16755) bin/solr's '-noprompt' option no longer works for examples

2023-04-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714142#comment-17714142 ] ASF subversion and git services commented on SOLR-16755: Commit 5

[jira] [Commented] (SOLR-16755) bin/solr's '-noprompt' option no longer works for examples

2023-04-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714146#comment-17714146 ] ASF subversion and git services commented on SOLR-16755: Commit 7

[GitHub] [solr] HoustonPutman merged pull request #1575: SOLR-16752 Reduce attack surface and size for Docker image

2023-04-19 Thread via GitHub
HoustonPutman merged PR #1575: URL: https://github.com/apache/solr/pull/1575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[jira] [Commented] (SOLR-16752) Reduce attack surface and size for Docker image

2023-04-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714154#comment-17714154 ] ASF subversion and git services commented on SOLR-16752: Commit 8

[GitHub] [solr] bqcuong commented on a diff in pull request #1575: SOLR-16752 Reduce attack surface and size for Docker image

2023-04-19 Thread via GitHub
bqcuong commented on code in PR #1575: URL: https://github.com/apache/solr/pull/1575#discussion_r1171494844 ## solr/CHANGES.txt: ## @@ -91,6 +91,8 @@ Improvements /api/collections/collName/snapshots/snapshotName`, listed at `GET /api/collections/collName/snapshots`, and dele

[jira] [Commented] (SOLR-16752) Reduce attack surface and size for Docker image

2023-04-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714158#comment-17714158 ] ASF subversion and git services commented on SOLR-16752: Commit b

[jira] [Resolved] (SOLR-16752) Reduce attack surface and size for Docker image

2023-04-19 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16752. --- Fix Version/s: 9.3 Assignee: Houston Putman Resolution: Fixed > Reduce attack

[GitHub] [solr] HoustonPutman commented on pull request #1575: SOLR-16752 Reduce attack surface and size for Docker image

2023-04-19 Thread via GitHub
HoustonPutman commented on PR #1575: URL: https://github.com/apache/solr/pull/1575#issuecomment-1514926143 Thanks for the contribution @bqcuong ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Commented] (SOLR-16393) Cosmetic improvements and migration to JAX-RS (alias, alias-prop CRUD APIs)

2023-04-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714169#comment-17714169 ] ASF subversion and git services commented on SOLR-16393: Commit f

[GitHub] [solr] patsonluk commented on pull request #1477: SOLR-16712: Simplify DocCollection ctor for PRS enabled collection

2023-04-19 Thread via GitHub
patsonluk commented on PR #1477: URL: https://github.com/apache/solr/pull/1477#issuecomment-1515058837 @noblepaul would u mind to link it again please? i tried the only link i found https://github.com/apache/solr/pull/1477/files/6f682a2febf9e5e4a03b161f61615115d3aea60d and it did not show

[jira] [Commented] (SOLR-16741) CLUSTERSTATUS API returns wrong value for state ,leader for PRS collections

2023-04-19 Thread Patson Luk (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714224#comment-17714224 ] Patson Luk commented on SOLR-16741: --- Thank you for fixing this [~noble.paul]! I see th

[GitHub] [solr-operator] HoustonPutman merged pull request #520: Use correct user for chmod command in cp-solr-xml init container

2023-04-19 Thread via GitHub
HoustonPutman merged PR #520: URL: https://github.com/apache/solr-operator/pull/520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr-operator] HoustonPutman closed issue #519: cp-solr-xml fails when a local backup repository is configured with SolrCloud running as a custom user

2023-04-19 Thread via GitHub
HoustonPutman closed issue #519: cp-solr-xml fails when a local backup repository is configured with SolrCloud running as a custom user URL: https://github.com/apache/solr-operator/issues/519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [solr-operator] HoustonPutman closed issue #557: Add in unsupported ZookeeperCluster options

2023-04-19 Thread via GitHub
HoustonPutman closed issue #557: Add in unsupported ZookeeperCluster options URL: https://github.com/apache/solr-operator/issues/557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [solr-operator] HoustonPutman merged pull request #558: Add currently unsupported ZookeeperCluster options

2023-04-19 Thread via GitHub
HoustonPutman merged PR #558: URL: https://github.com/apache/solr-operator/pull/558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[jira] [Commented] (SOLR-16391) Cosmetic improvements and migration to JAX-RS (collection, collection prop, core CRUD APIs)

2023-04-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714249#comment-17714249 ] ASF subversion and git services commented on SOLR-16391: Commit b

[GitHub] [solr-operator] HoustonPutman commented on issue #505: security.json isn't exported to Zookeeper

2023-04-19 Thread via GitHub
HoustonPutman commented on issue #505: URL: https://github.com/apache/solr-operator/issues/505#issuecomment-1515166409 It looks like Sitecore supports 8.11.2, and there is a workaround for users that need that lower Solr version. I'm going to close this for now. -- This is an automated me

[GitHub] [solr-operator] HoustonPutman closed issue #505: security.json isn't exported to Zookeeper

2023-04-19 Thread via GitHub
HoustonPutman closed issue #505: security.json isn't exported to Zookeeper URL: https://github.com/apache/solr-operator/issues/505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [solr] tflobbe opened a new pull request, #1577: SOLR-16719: Let AffinityPlacementFactory have an anti-affinity label

2023-04-19 Thread via GitHub
tflobbe opened a new pull request, #1577: URL: https://github.com/apache/solr/pull/1577 This PR adds the option to require anti-affinity within an AZ (essentially giving another level of anti-affinity). The usecase is, to support something like rack diversity between an AZ, or host dive

[GitHub] [solr] tflobbe commented on pull request #1577: SOLR-16719: Let AffinityPlacementFactory have an anti-affinity label

2023-04-19 Thread via GitHub
tflobbe commented on PR #1577: URL: https://github.com/apache/solr/pull/1577#issuecomment-1515451424 This is the output of the `testScalability` on my machine running with nightly property: ``` Patch: 1225 INFO (TEST-AffinityPlacementFactoryTest.testScalability-seed#[29B84ABB

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1577: SOLR-16719: Let AffinityPlacementFactory have an anti-affinity label

2023-04-19 Thread via GitHub
sonatype-lift[bot] commented on code in PR #1577: URL: https://github.com/apache/solr/pull/1577#discussion_r1171922585 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java: ## @@ -204,6 +206,8 @@ static class AffinityPlacementPlugin imple

[jira] [Commented] (SOLR-16753) SplitShardWithNodeRoleTest.testSolrClusterWithNodeRoleWithPull failures

2023-04-19 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714353#comment-17714353 ] Chris M. Hostetter commented on SOLR-16753: --- FWIW, I found that on my machine,

[GitHub] [solr] solrbot closed pull request #1569: Update dependency com.github.ben-manes.caffeine:caffeine to v3.1.6 - autoclosed

2023-04-19 Thread via GitHub
solrbot closed pull request #1569: Update dependency com.github.ben-manes.caffeine:caffeine to v3.1.6 - autoclosed URL: https://github.com/apache/solr/pull/1569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [solr] solrbot closed pull request #1520: Update dependency no.nav.security:mock-oauth2-server to v0.5.8 - autoclosed

2023-04-19 Thread via GitHub
solrbot closed pull request #1520: Update dependency no.nav.security:mock-oauth2-server to v0.5.8 - autoclosed URL: https://github.com/apache/solr/pull/1520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [solr] solrbot closed pull request #1551: Update io.netty:* to v4.1.91.Final - autoclosed

2023-04-19 Thread via GitHub
solrbot closed pull request #1551: Update io.netty:* to v4.1.91.Final - autoclosed URL: https://github.com/apache/solr/pull/1551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [solr] solrbot commented on pull request #1522: Update dependency org.mockito:mockito-core to v3.12.4 - abandoned

2023-04-19 Thread via GitHub
solrbot commented on PR #1522: URL: https://github.com/apache/solr/pull/1522#issuecomment-1515572066 ### Autoclosing Skipped This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bu

[jira] [Commented] (SOLR-16753) SplitShardWithNodeRoleTest.testSolrClusterWithNodeRoleWithPull failures

2023-04-19 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714380#comment-17714380 ] Noble Paul commented on SOLR-16753: --- {quote}Somewhere in the code we have a (pre-existi

[GitHub] [solr] noblepaul commented on pull request #1477: SOLR-16712: Simplify DocCollection ctor for PRS enabled collection

2023-04-19 Thread via GitHub
noblepaul commented on PR #1477: URL: https://github.com/apache/solr/pull/1477#issuecomment-1515636831 @patsonluk as it is mutating an existing Object, there is a small period during which the state of a given replica is unpredictable . some replicas of the collection would fetch state