epugh commented on PR #1568: URL: https://github.com/apache/solr/pull/1568#issuecomment-1514849013
> Huge improvement to split this up. LGTM although have not studied every change. > > Are there places where you did more than simply breaking classes out, where you'd like us to pay special attention? I tried to restrain myself from "fixing" too many things. The edits were mostly just responding to some intellij warnings.. I think as long as the changes to the bash/cmd scripts look good? The bats tests run as do the unit tests, so I think it's actually not too much risk.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
