[GitHub] [solr] noblepaul commented on a diff in pull request #1363: SOLR-16664: TestCoordinatorRole fails docs is null

2023-02-19 Thread via GitHub
noblepaul commented on code in PR #1363: URL: https://github.com/apache/solr/pull/1363#discussion_r213104 ## solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java: ## @@ -389,6 +390,7 @@ private String getHostCoreName( SolrQuery q = new SolrQuery("*:*");

[jira] [Commented] (SOLR-13942) /api/cluster/zk/* to fetch raw ZK data

2023-02-19 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690867#comment-17690867 ] Noble Paul commented on SOLR-13942: --- {quote}We add new stuff but the boring work of mig

[jira] [Assigned] (SOLR-16653) Shard split doesn't work when shard has NRT and pull replica and prs is enable on collection

2023-02-19 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul reassigned SOLR-16653: - Assignee: Noble Paul (was: Ishan Chattopadhyaya) > Shard split doesn't work when shard has NRT

[GitHub] [solr] noblepaul merged pull request #1350: Shard split when NRT and pull replica & prs enabled leads to inactive replica

2023-02-19 Thread via GitHub
noblepaul merged PR #1350: URL: https://github.com/apache/solr/pull/1350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-16653) Shard split doesn't work when shard has NRT and pull replica and prs is enable on collection

2023-02-19 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690885#comment-17690885 ] Ishan Chattopadhyaya commented on SOLR-16653: - [~noble.paul], [~hiteshkhamesr

[GitHub] [solr] mkhludnev commented on a diff in pull request #1260: SOLR-788: transfer mlt query for component right

2023-02-19 Thread via GitHub
mkhludnev commented on code in PR #1260: URL: https://github.com/apache/solr/pull/1260#discussion_r239181 ## solr/core/src/java/org/apache/solr/handler/MoreLikeThisHandler.java: ## @@ -422,6 +417,24 @@ public DocListAndSet getMoreLikeThis( return results; } +

[GitHub] [solr] mkhludnev commented on a diff in pull request #1260: SOLR-788: transfer mlt query for component right

2023-02-19 Thread via GitHub
mkhludnev commented on code in PR #1260: URL: https://github.com/apache/solr/pull/1260#discussion_r240673 ## solr/core/src/java/org/apache/solr/handler/component/MoreLikeThisComponent.java: ## @@ -127,6 +128,53 @@ public void process(ResponseBuilder rb) throws IOException {

[GitHub] [solr] mkhludnev commented on a diff in pull request #1260: SOLR-788: transfer mlt query for component right

2023-02-19 Thread via GitHub
mkhludnev commented on code in PR #1260: URL: https://github.com/apache/solr/pull/1260#discussion_r241215 ## solr/core/src/java/org/apache/solr/handler/component/MoreLikeThisComponent.java: ## @@ -127,6 +128,53 @@ public void process(ResponseBuilder rb) throws IOException {

[jira] [Created] (SOLR-16672) Unused setDefaultCollection in SolrCLI

2023-02-19 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-16672: Summary: Unused setDefaultCollection in SolrCLI Key: SOLR-16672 URL: https://issues.apache.org/jira/browse/SOLR-16672 Project: Solr Issue Type: Improvement Sec

[GitHub] [solr] epugh opened a new pull request, #1372: SOLR-16672: Unused setDefaultCollection in SolrCLI

2023-02-19 Thread via GitHub
epugh opened a new pull request, #1372: URL: https://github.com/apache/solr/pull/1372 https://issues.apache.org/jira/browse/SOLR-16672 found unused (I believe!) parameter... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [solr] HoustonPutman merged pull request #1370: SOLR-16671: Explicitly call out library permissions for config-edit

2023-02-19 Thread via GitHub
HoustonPutman merged PR #1370: URL: https://github.com/apache/solr/pull/1370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[jira] [Commented] (SOLR-16671) Explicitly call out library permissions for config-edit

2023-02-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690961#comment-17690961 ] ASF subversion and git services commented on SOLR-16671: Commit d

[GitHub] [solr] epugh commented on pull request #1353: SOLR-16563 DefaultCollectionSolrClient

2023-02-19 Thread via GitHub
epugh commented on PR #1353: URL: https://github.com/apache/solr/pull/1353#issuecomment-1436173735 @dsmiley I tried using the `DefaultCollectionSolrClient` with out much success. Everywhere wanted a CloudSolrClient... Or, I didn't have setters in the testing infrastructure to take in a `

[jira] [Commented] (SOLR-16671) Explicitly call out library permissions for config-edit

2023-02-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690962#comment-17690962 ] ASF subversion and git services commented on SOLR-16671: Commit d

[jira] [Commented] (SOLR-16671) Explicitly call out library permissions for config-edit

2023-02-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690963#comment-17690963 ] ASF subversion and git services commented on SOLR-16671: Commit c

[jira] [Commented] (SOLR-16671) Explicitly call out library permissions for config-edit

2023-02-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690964#comment-17690964 ] ASF subversion and git services commented on SOLR-16671: Commit 5

[jira] [Commented] (SOLR-10466) setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-02-19 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690967#comment-17690967 ] Eric Pugh commented on SOLR-10466: -- I tried to build on the PR that [~dsmiley] put up ab

[jira] [Commented] (SOLR-16671) Explicitly call out library permissions for config-edit

2023-02-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690987#comment-17690987 ] ASF subversion and git services commented on SOLR-16671: Commit c

[jira] [Resolved] (SOLR-16671) Explicitly call out library permissions for config-edit

2023-02-19 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16671. --- Fix Version/s: 8.11.3 9.2 Assignee: Houston Putman Resoluti

[GitHub] [solr] noblepaul commented on pull request #1351: SOLR-16654: Add support for node-level caches

2023-02-19 Thread via GitHub
noblepaul commented on PR #1351: URL: https://github.com/apache/solr/pull/1351#issuecomment-1436332096 If we go with # 1 , we do not have a way to use this feauture at all. OTOH if we go with # 2 , atleast somebody will use it -- This is an automated message from the Apache Git Service. T

[jira] [Comment Edited] (SOLR-13942) /api/cluster/zk/* to fetch raw ZK data

2023-02-19 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690867#comment-17690867 ] Noble Paul edited comment on SOLR-13942 at 2/20/23 7:15 AM: {

[jira] [Commented] (SOLR-16593) Redundant fields are present in the replica object of state.json

2023-02-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691040#comment-17691040 ] ASF subversion and git services commented on SOLR-16593: Commit a

[jira] [Commented] (SOLR-16593) Redundant fields are present in the replica object of state.json

2023-02-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691041#comment-17691041 ] ASF subversion and git services commented on SOLR-16593: Commit 1