[jira] [Commented] (SOLR-16143) SolrConfig ResourceProvider can miss updates from ZooKeeper

2022-05-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538167#comment-17538167 ] Kevin Risden commented on SOLR-16143: - bq. That sounds fine, would you like to backpo

[jira] [Commented] (SOLR-16019) UTF-8 parsing errors for parameters should cause a HTTP 400 status code, not 500

2022-05-17 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538275#comment-17538275 ] Mike Drob commented on SOLR-16019: -- [~janhoy] - do you still intend to backport this to

[GitHub] [solr] madrob commented on a diff in pull request #804: SOLR-16146: Avoid loading all collections during node startup

2022-05-17 Thread GitBox
madrob commented on code in PR #804: URL: https://github.com/apache/solr/pull/804#discussion_r874960165 ## solr/solrj/src/java/org/apache/solr/client/solrj/routing/NodePreferenceRulesComparator.java: ## @@ -40,7 +40,7 @@ */ public class NodePreferenceRulesComparator implement

[GitHub] [solr] madrob commented on a diff in pull request #864: SOLR-16194 Don't overwrite list of collections in a Routed Alias when…

2022-05-17 Thread GitBox
madrob commented on code in PR #864: URL: https://github.com/apache/solr/pull/864#discussion_r874969255 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -2299,6 +2300,25 @@ public long getStatus() { return status; } + /** + * Retrieve the aliases

[GitHub] [solr] madrob commented on a diff in pull request #864: SOLR-16194 Don't overwrite list of collections in a Routed Alias when…

2022-05-17 Thread GitBox
madrob commented on code in PR #864: URL: https://github.com/apache/solr/pull/864#discussion_r874970917 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateAliasCmd.java: ## @@ -140,15 +145,21 @@ private void callCreateRoutedAlias( Sets.differenc

[jira] [Updated] (SOLR-16194) Updating Time Routed Alias Parameters Loses Existing Collection List

2022-05-17 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-16194: - Fix Version/s: 9.1 8.11.1 > Updating Time Routed Alias Parameters Loses Existing Colle

[jira] [Commented] (SOLR-15892) RoutedAliasUpdateProcessor not distributing delete and commit requests.

2022-05-17 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538289#comment-17538289 ] Mike Drob commented on SOLR-15892: -- [~akkig117] - we typically follow a development patt

[jira] [Updated] (SOLR-16191) Sanity-check assumptions about Linux `ps` command in `solr/bin/solr` script

2022-05-17 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-16191: - Fix Version/s: 9.0.1 8.11.2 9.1 > Sanity-check assumptions about Li

[jira] [Commented] (SOLR-15892) RoutedAliasUpdateProcessor not distributing delete and commit requests.

2022-05-17 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538302#comment-17538302 ] Gus Heck commented on SOLR-15892: - One thing about the suggested patch is that this may n

[jira] [Closed] (SOLR-16196) Use the Solr KEYS file for the official Dockerfile

2022-05-17 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman closed SOLR-16196. - > Use the Solr KEYS file for the official Dockerfile > --

[jira] [Closed] (SOLR-15557) Figure out how to handle ref guide page renames/redirects

2022-05-17 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman closed SOLR-15557. - > Figure out how to handle ref guide page renames/redirects > ---

[GitHub] [solr] HoustonPutman merged pull request #859: Ref guide overall version improvement

2022-05-17 Thread GitBox
HoustonPutman merged PR #859: URL: https://github.com/apache/solr/pull/859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[GitHub] [solr] madrob opened a new pull request, #867: SOLR-16191: Verify that ps supports -p

2022-05-17 Thread GitBox
madrob opened a new pull request, #867: URL: https://github.com/apache/solr/pull/867 https://issues.apache.org/jira/browse/SOLR-16191 @colvinco You may be interested in this as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Assigned] (SOLR-16191) Sanity-check assumptions about Linux `ps` command in `solr/bin/solr` script

2022-05-17 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reassigned SOLR-16191: Assignee: Mike Drob > Sanity-check assumptions about Linux `ps` command in `solr/bin/solr` script

[GitHub] [solr] risdenk commented on pull request #848: SOLR-16190: Http2SolrClient should make sure to shutdown the executor

2022-05-17 Thread GitBox
risdenk commented on PR #848: URL: https://github.com/apache/solr/pull/848#issuecomment-1129104224 @madrob / @magibney / @CaoManhDat any thoughts on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [solr] magibney commented on a diff in pull request #867: SOLR-16191: Verify that ps supports -p

2022-05-17 Thread GitBox
magibney commented on code in PR #867: URL: https://github.com/apache/solr/pull/867#discussion_r875091635 ## solr/bin/solr: ## @@ -61,6 +61,11 @@ if [ "${THIS_OS:0:6}" == "CYGWIN" ]; then echo -e "This script does not support cygwin due to severe limitations and lack of adhe

[GitHub] [solr] madrob commented on a diff in pull request #865: SOLR-16199: Improve handling of LIKE queries with wildcard

2022-05-17 Thread GitBox
madrob commented on code in PR #865: URL: https://github.com/apache/solr/pull/865#discussion_r875176213 ## solr/modules/sql/src/java/org/apache/solr/handler/sql/SolrFilter.java: ## @@ -346,21 +346,52 @@ protected String translateAnd(RexNode node0) { } protected Strin

[GitHub] [solr-docker] HoustonPutman opened a new pull request, #6: SOLR-15102: Add Solr Docker release docs

2022-05-17 Thread GitBox
HoustonPutman opened a new pull request, #6: URL: https://github.com/apache/solr-docker/pull/6 Let me know if this makes sense to y'all or if there's anything that isn't clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [solr] kiranchitturi commented on a diff in pull request #865: SOLR-16199: Improve handling of LIKE queries with wildcard

2022-05-17 Thread GitBox
kiranchitturi commented on code in PR #865: URL: https://github.com/apache/solr/pull/865#discussion_r875259672 ## solr/modules/sql/src/java/org/apache/solr/handler/sql/SolrFilter.java: ## @@ -346,21 +346,52 @@ protected String translateAnd(RexNode node0) { } protecte

[GitHub] [solr] kiranchitturi commented on a diff in pull request #865: SOLR-16199: Improve handling of LIKE queries with wildcard

2022-05-17 Thread GitBox
kiranchitturi commented on code in PR #865: URL: https://github.com/apache/solr/pull/865#discussion_r875261198 ## solr/modules/sql/src/java/org/apache/solr/handler/sql/SolrFilter.java: ## @@ -346,21 +346,52 @@ protected String translateAnd(RexNode node0) { } protecte

[GitHub] [solr] kiranchitturi commented on a diff in pull request #865: SOLR-16199: Improve handling of LIKE queries with wildcard

2022-05-17 Thread GitBox
kiranchitturi commented on code in PR #865: URL: https://github.com/apache/solr/pull/865#discussion_r875262356 ## solr/modules/sql/src/test/org/apache/solr/handler/sql/TestSQLHandler.java: ## @@ -2434,15 +2434,73 @@ public void testColIsNull() throws Exception { @Test publ

[GitHub] [solr-docker] madrob commented on a diff in pull request #6: SOLR-15102: Add Solr Docker release docs

2022-05-17 Thread GitBox
madrob commented on code in PR #6: URL: https://github.com/apache/solr-docker/pull/6#discussion_r875264595 ## README.md: ## @@ -1,49 +1,28 @@ -# NOTE: Not vulnerable to Log4J 2 "Log4shell" - -Some Docker images *were* vulnerable to one of a pair of vulnerabilities in Log4J 2. -

[GitHub] [solr] madrob commented on a diff in pull request #865: SOLR-16199: Improve handling of LIKE queries with wildcard

2022-05-17 Thread GitBox
madrob commented on code in PR #865: URL: https://github.com/apache/solr/pull/865#discussion_r875276783 ## solr/modules/sql/src/java/org/apache/solr/handler/sql/SolrFilter.java: ## @@ -346,21 +346,52 @@ protected String translateAnd(RexNode node0) { } protected Strin

[GitHub] [solr-docker] HoustonPutman commented on a diff in pull request #6: SOLR-15102: Add Solr Docker release docs

2022-05-17 Thread GitBox
HoustonPutman commented on code in PR #6: URL: https://github.com/apache/solr-docker/pull/6#discussion_r875279254 ## README.md: ## @@ -1,49 +1,28 @@ -# NOTE: Not vulnerable to Log4J 2 "Log4shell" - -Some Docker images *were* vulnerable to one of a pair of vulnerabilities in Log

[GitHub] [solr-docker] HoustonPutman commented on a diff in pull request #6: SOLR-15102: Add Solr Docker release docs

2022-05-17 Thread GitBox
HoustonPutman commented on code in PR #6: URL: https://github.com/apache/solr-docker/pull/6#discussion_r875280387 ## dev-docs/README.md: ## @@ -0,0 +1,33 @@ +# Official Solr Dockerfile Management + +In general most interactions with this repository should be done via the Solr R

[GitHub] [solr] dsmiley commented on a diff in pull request #848: SOLR-16190: Http2SolrClient should make sure to shutdown the executor

2022-05-17 Thread GitBox
dsmiley commented on code in PR #848: URL: https://github.com/apache/solr/pull/848#discussion_r875305975 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -250,16 +250,18 @@ private HttpClient createHttpClient(Builder builder) { public void

[GitHub] [solr] dsmiley commented on pull request #804: SOLR-16146: Avoid loading all collections during node startup

2022-05-17 Thread GitBox
dsmiley commented on PR #804: URL: https://github.com/apache/solr/pull/804#issuecomment-1129389009 I like that this removes a usage of `NodeStateProvider`, which we're now even closer to removing. It was introduced in the autoscaling times, and as-such is used in 8x a bunch. In 9x it's us

[jira] [Updated] (SOLR-16201) Upgrading solr failing all the rules

2022-05-17 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck updated SOLR-16201: Security: Public (was: Private (Security Issue)) > Upgrading solr failing all the rules >

[GitHub] [solr] gus-asf merged pull request #864: SOLR-16194 Don't overwrite list of collections in a Routed Alias when…

2022-05-17 Thread GitBox
gus-asf merged PR #864: URL: https://github.com/apache/solr/pull/864 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-16194) Updating Time Routed Alias Parameters Loses Existing Collection List

2022-05-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538568#comment-17538568 ] ASF subversion and git services commented on SOLR-16194: Commit a