dsmiley commented on PR #804: URL: https://github.com/apache/solr/pull/804#issuecomment-1129389009
I like that this removes a usage of `NodeStateProvider`, which we're now even closer to removing. It was introduced in the autoscaling times, and as-such is used in 8x a bunch. In 9x it's used in like a couple places, including this one. The other is SplitShardCmd which I might modify to use something else to obtain replica sizes. It's not clear NodeStateProvider has a purpose otherwise. If we agree it shouldn't have a long life, let's also mark it Deprecated in this PR? I like to think we can and should use Deprecated a ton more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
