[GitHub] [solr] dweiss commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-08-04 Thread GitBox
dweiss commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r682373159 ## File path: solr/test-framework/src/java/org/apache/solr/util/RandomizeSSL.java ## @@ -104,10 +105,10 @@ public SSLRandomizer(double ssl, double clientAuth,

[jira] [Created] (SOLR-15577) Avoid {{ClusterState.getCollectionsMap()}} when not necessary

2021-08-04 Thread Andrzej Bialecki (Jira)
Andrzej Bialecki created SOLR-15577: --- Summary: Avoid {{ClusterState.getCollectionsMap()}} when not necessary Key: SOLR-15577 URL: https://issues.apache.org/jira/browse/SOLR-15577 Project: Solr

[jira] [Updated] (SOLR-15577) Avoid ClusterState.getCollectionsMap() when not necessary

2021-08-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-15577: Fix Version/s: 8.10 > Avoid ClusterState.getCollectionsMap() when not necessary > -

[jira] [Updated] (SOLR-15577) Avoid ClusterState.getCollectionsMap() when not necessary

2021-08-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-15577: Summary: Avoid ClusterState.getCollectionsMap() when not necessary (was: Avoid {{ClusterSt

[jira] [Updated] (SOLR-15572) Improve the default Prometheus exporter config performance

2021-08-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-15572: Fix Version/s: 8.10 > Improve the default Prometheus exporter config performance >

[jira] [Updated] (SOLR-15572) Improve the default Prometheus exporter config performance

2021-08-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-15572: Attachment: SOLR-15572.patch > Improve the default Prometheus exporter config performance >

[GitHub] [solr] epugh commented on pull request #159: [SOLR-10059] Handle appends params in distributed requests

2021-08-04 Thread GitBox
epugh commented on pull request #159: URL: https://github.com/apache/solr/pull/159#issuecomment-892617936 One more request @tboeghk, it apears from JIRA that your patch would fix https://issues.apache.org/jira/browse/SOLR-14931 ??? -- This is an automated message from the Apache Git Serv

[GitHub] [solr] tboeghk commented on pull request #159: [SOLR-10059] Handle appends params in distributed requests

2021-08-04 Thread GitBox
tboeghk commented on pull request #159: URL: https://github.com/apache/solr/pull/159#issuecomment-892623271 Yes (I'm 95% sure): The macros don't get expanded on the shard. With the fix above the configuration is not picked up on the shard and the macros should stay expanded. Do we need ano

[GitHub] [solr] epugh commented on pull request #159: [SOLR-10059] Handle appends params in distributed requests

2021-08-04 Thread GitBox
epugh commented on pull request #159: URL: https://github.com/apache/solr/pull/159#issuecomment-892673867 Does anyone ever say "no, we don't need another test" ;-) I'd love one, partly because this whole space is kind of new for me, so it might help me feel confident of your fix uni

[jira] [Assigned] (SOLR-10059) In SolrCloud, every fq added via is computed twice.

2021-08-04 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh reassigned SOLR-10059: -- Assignee: David Eric Pugh > In SolrCloud, every fq added via is computed twice. > ---

[GitHub] [solr] madrob commented on a change in pull request #247: SOLR-15576: Allow filtering on ISO-8601 formatted timestamp literals in SQL WHERE clause

2021-08-04 Thread GitBox
madrob commented on a change in pull request #247: URL: https://github.com/apache/solr/pull/247#discussion_r682942562 ## File path: solr/core/src/java/org/apache/solr/handler/sql/SolrFilter.java ## @@ -278,6 +265,24 @@ protected String translateComparison(RexNode node) {

[GitHub] [solr] madrob commented on pull request #243: SOLR-15480 Added putAll method to Tuple and refactored the copy constructor, merge, and clone methods to use it.

2021-08-04 Thread GitBox
madrob commented on pull request #243: URL: https://github.com/apache/solr/pull/243#issuecomment-892961555 This LGTM, @cpoerschke did you have thoughts on additional documentation around this change? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [solr] madrob commented on a change in pull request #225: SOLR-15538 Update Lucene Preview Release dependency

2021-08-04 Thread GitBox
madrob commented on a change in pull request #225: URL: https://github.com/apache/solr/pull/225#discussion_r682949171 ## File path: solr/core/src/test/org/apache/solr/search/FuzzySearchTest.java ## @@ -51,6 +52,7 @@ public void setupCollection() throws Exception { } @Te

[GitHub] [solr] thelabdude commented on a change in pull request #247: SOLR-15576: Allow filtering on ISO-8601 formatted timestamp literals in SQL WHERE clause

2021-08-04 Thread GitBox
thelabdude commented on a change in pull request #247: URL: https://github.com/apache/solr/pull/247#discussion_r682971005 ## File path: solr/core/src/java/org/apache/solr/handler/sql/SolrFilter.java ## @@ -278,6 +265,24 @@ protected String translateComparison(RexNode node) {

[jira] [Created] (SOLR-15578) Add Support for HSTS Security Protocol

2021-08-04 Thread Marcus Eagan (Jira)
Marcus Eagan created SOLR-15578: --- Summary: Add Support for HSTS Security Protocol Key: SOLR-15578 URL: https://issues.apache.org/jira/browse/SOLR-15578 Project: Solr Issue Type: Improvement

[GitHub] [solr] thelabdude commented on a change in pull request #247: SOLR-15576: Allow filtering on ISO-8601 formatted timestamp literals in SQL WHERE clause

2021-08-04 Thread GitBox
thelabdude commented on a change in pull request #247: URL: https://github.com/apache/solr/pull/247#discussion_r682995862 ## File path: solr/core/src/java/org/apache/solr/handler/sql/SolrFilter.java ## @@ -278,6 +265,24 @@ protected String translateComparison(RexNode node) {

[GitHub] [solr] thelabdude merged pull request #246: SOLR-15575: Propagate request level basic auth creds from the top-level request to internally used async requests

2021-08-04 Thread GitBox
thelabdude merged pull request #246: URL: https://github.com/apache/solr/pull/246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (SOLR-15575) CollectionAdminRequest's processAndWait does not propagate the per-request basic auth credentials from the main request to RequestStatus and DeleteStatus used internall

2021-08-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17393472#comment-17393472 ] ASF subversion and git services commented on SOLR-15575: Commit d

[GitHub] [solr] madrob commented on a change in pull request #238: SOLR-15286 A brand new follower in the legacy mode should wait to replicate index before reporting healthy

2021-08-04 Thread GitBox
madrob commented on a change in pull request #238: URL: https://github.com/apache/solr/pull/238#discussion_r682950270 ## File path: solr/core/src/java/org/apache/solr/handler/admin/HealthCheckHandler.java ## @@ -61,6 +64,17 @@ * is fully initialized and stable before proce

[GitHub] [solr] madrob commented on a change in pull request #247: SOLR-15576: Allow filtering on ISO-8601 formatted timestamp literals in SQL WHERE clause

2021-08-04 Thread GitBox
madrob commented on a change in pull request #247: URL: https://github.com/apache/solr/pull/247#discussion_r683000680 ## File path: solr/core/src/java/org/apache/solr/handler/sql/SolrFilter.java ## @@ -278,6 +265,24 @@ protected String translateComparison(RexNode node) {

[jira] [Resolved] (SOLR-15575) CollectionAdminRequest's processAndWait does not propagate the per-request basic auth credentials from the main request to RequestStatus and DeleteStatus used internally

2021-08-04 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter resolved SOLR-15575. --- Fix Version/s: 8.10 main (9.0) Resolution: Fixed > CollectionAdminR

[jira] [Commented] (SOLR-15575) CollectionAdminRequest's processAndWait does not propagate the per-request basic auth credentials from the main request to RequestStatus and DeleteStatus used internall

2021-08-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17393487#comment-17393487 ] ASF subversion and git services commented on SOLR-15575: Commit f

[jira] [Commented] (SOLR-15428) Integrate the OpenJDK JMH micro benchmark framework for micro benchmarks and performance comparisons and investigation.

2021-08-04 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17393503#comment-17393503 ] Mark Robert Miller commented on SOLR-15428: --- The first commit for this is ready

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-08-04 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r683075217 ## File path: solr/benchmark/src/java/org/apache/solr/bench/MiniClusterState.java ## @@ -0,0 +1,370 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [solr] markrmiller commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-08-04 Thread GitBox
markrmiller commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r683078542 ## File path: solr/benchmark/build.gradle ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor l

[GitHub] [solr] markrmiller commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-08-04 Thread GitBox
markrmiller commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r683080004 ## File path: solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java ## @@ -227,8 +212,8 @@ public MiniSolrCloudCluster(int numServe

[GitHub] [solr] markrmiller commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-08-04 Thread GitBox
markrmiller commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r683080004 ## File path: solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java ## @@ -227,8 +212,8 @@ public MiniSolrCloudCluster(int numServe

[GitHub] [solr] markrmiller commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-08-04 Thread GitBox
markrmiller commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r683080378 ## File path: solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java ## @@ -295,12 +280,14 @@ public MiniSolrCloudCluster(int numSer

[GitHub] [solr] markrmiller commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-08-04 Thread GitBox
markrmiller commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r683080554 ## File path: solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java ## @@ -788,6 +777,26 @@ public void waitForActiveCollection(Str

[GitHub] [solr] markrmiller commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-08-04 Thread GitBox
markrmiller commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r683080694 ## File path: solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java ## @@ -212,7 +197,7 @@ public MiniSolrCloudCluster(int numServe

[GitHub] [solr] markrmiller commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-08-04 Thread GitBox
markrmiller commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r683080790 ## File path: solr/benchmark/src/java/org/apache/solr/bench/DocMaker.java ## @@ -0,0 +1,301 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [solr] markrmiller commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-08-04 Thread GitBox
markrmiller commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r683080952 ## File path: solr/benchmark/src/java/org/apache/solr/bench/MiniClusterState.java ## @@ -0,0 +1,370 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [solr] markrmiller commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-08-04 Thread GitBox
markrmiller commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r683081024 ## File path: solr/benchmark/src/java/org/apache/solr/bench/MiniClusterState.java ## @@ -0,0 +1,370 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [solr] markrmiller commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-08-04 Thread GitBox
markrmiller commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r683081223 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -487,6 +488,14 @@ public long getIndexSize() { return size; } + public

[GitHub] [solr] markrmiller commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-08-04 Thread GitBox
markrmiller commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r683081476 ## File path: solr/core/src/java/org/apache/solr/client/solrj/embedded/JettySolrRunner.java ## @@ -697,6 +716,52 @@ public void stop() throws Exception {

[GitHub] [solr] markrmiller commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-08-04 Thread GitBox
markrmiller commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r683081581 ## File path: solr/benchmark/src/java/org/apache/solr/bench/index/CloudIndexing.java ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundati