dweiss commented on a change in pull request #214:
URL: https://github.com/apache/solr/pull/214#discussion_r682373159
##########
File path: solr/test-framework/src/java/org/apache/solr/util/RandomizeSSL.java
##########
@@ -104,10 +105,10 @@ public SSLRandomizer(double ssl, double clientAuth,
String debug) {
public SSLTestConfig createSSLTestConfig() {
// even if we know SSL is disabled, always consume the same amount of
randomness
// that way all other test behavior should be consistent even if a user
adds/removes @SuppressSSL
-
- final boolean useSSL = TestUtil.nextInt(LuceneTestCase.random(), 0, 999)
<
+ Random random = new Random();
Review comment:
Anything, really. If it's not running under the junit (randomized) test
runner then you won't be able to use any of the randomized context stuff -
it'll throw illegal state exceptions. But you can try to pass/ reuse the system
property tests.seed to initialize that "local" random without entering
randomizedtesting code. This is done in StringHelper, for example:
```
static {
String prop = System.getProperty("tests.seed");
if (prop != null) {
// So if there is a test failure that relied on hash
// order, we remain reproducible based on the test seed:
GOOD_FAST_HASH_SEED = prop.hashCode();
} else {
GOOD_FAST_HASH_SEED = (int) System.currentTimeMillis();
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
