bruno-roustant merged pull request #68:
URL: https://github.com/apache/solr/pull/68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
[
https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated SOLR-15361:
---
Attachment: SOLR-15361.patch
> update gradle build to support gpg signing of tgz/zip distributions
>
[
https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327174#comment-17327174
]
Dawid Weiss commented on SOLR-15361:
Gradle is code. The evaluation/ execution order
bruno-roustant commented on a change in pull request #47:
URL: https://github.com/apache/solr/pull/47#discussion_r618244929
##
File path: solr/solr-ref-guide/src/major-changes-in-solr-8.adoc
##
@@ -283,9 +283,9 @@ The login screen's purpose is cosmetic only - Admin
UI-triggere
bruno-roustant commented on a change in pull request #47:
URL: https://github.com/apache/solr/pull/47#discussion_r618245496
##
File path: solr/solr-ref-guide/src/major-changes-in-solr-8.adoc
##
@@ -283,9 +283,9 @@ The login screen's purpose is cosmetic only - Admin
UI-triggere
[
https://issues.apache.org/jira/browse/SOLR-15019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327241#comment-17327241
]
Andrzej Bialecki commented on SOLR-15019:
-
Ok, I'll remove this until we actually
bruno-roustant commented on a change in pull request #47:
URL: https://github.com/apache/solr/pull/47#discussion_r618268515
##
File path: solr/core/src/java/org/apache/solr/security/AllowListUrlChecker.java
##
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the Apache Software Foundation
bruno-roustant commented on a change in pull request #47:
URL: https://github.com/apache/solr/pull/47#discussion_r618272385
##
File path: solr/core/src/test/org/apache/solr/cloud/UnloadDistributedZkTest.java
##
@@ -65,7 +67,11 @@ protected String getSolrXml() {
@Test
pu
[
https://issues.apache.org/jira/browse/SOLR-15365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-15365:
---
Description:
Added a new row to the default Grafana dashboard. Also uploaded to
[https://grafana.com
Jan Høydahl created SOLR-15365:
--
Summary: New cluster row in Grafana Dashboard
Key: SOLR-15365
URL: https://issues.apache.org/jira/browse/SOLR-15365
Project: Solr
Issue Type: Improvement
S
[
https://issues.apache.org/jira/browse/SOLR-15365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-15365:
---
Attachment: Solr Grafana Dashboard cluster panel.png
> New cluster row in Grafana Dashboard
> ---
[
https://issues.apache.org/jira/browse/SOLR-15365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-15365:
---
Description:
Added a new row to the default Grafana dashboard. Also uploaded to
[https://grafana.com
gerlowskija commented on pull request #41:
URL: https://github.com/apache/solr/pull/41#issuecomment-824752402
Hey @epugh I pushed up a few fixes for my previous review comments.
In the process though I noticed something odd. On certain API calls, the
docs still have two sets of exam
[
https://issues.apache.org/jira/browse/SOLR-15365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-15365:
---
Description:
Added a new row to the default Grafana dashboard. Also uploaded to
[https://grafana.com
epugh commented on pull request #41:
URL: https://github.com/apache/solr/pull/41#issuecomment-824766011
> Hey @epugh I pushed up a few fixes for my previous review comments.
>
> In the process though I noticed something odd. On certain API calls, the
docs still have two sets of examp
epugh commented on pull request #41:
URL: https://github.com/apache/solr/pull/41#issuecomment-824766776
your edits look great!
WDYT about merging after those last edits? Feel free to click the magic
button!
--
This is an automated message from the Apache Git Service.
To respon
janhoy opened a new pull request #88:
URL: https://github.com/apache/solr/pull/88
See https://issues.apache.org/jira/browse/SOLR-15365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
janhoy commented on pull request #88:
URL: https://github.com/apache/solr/pull/88#issuecomment-824778277
@thelabdude Please have a look at this. I tested in grafana and did an
export through "share" button -> export -> "export for sharing externally". But
the diff is all messed up, so hard
thelabdude commented on pull request #88:
URL: https://github.com/apache/solr/pull/88#issuecomment-824900375
Very cool @janhoy . I imported into a live K8s cluster running 8.8.2 with
the customized exporter config and see the attached.
Not sure what that extra dimension with `=:` is on t
madrob merged pull request #86:
URL: https://github.com/apache/solr/pull/86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
janhoy commented on pull request #88:
URL: https://github.com/apache/solr/pull/88#issuecomment-824938995
> Not sure what that extra dimension with `=:` is on the Replica State
History panel?
Since the state label was not there before, you have historic data points
without any value.
[
https://issues.apache.org/jira/browse/SOLR-15363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329198#comment-17329198
]
ASF subversion and git services commented on SOLR-15363:
Commit e
janhoy commented on pull request #88:
URL: https://github.com/apache/solr/pull/88#issuecomment-824940798
Pushed changes
* state history is now 0 for active, and any non-active will stack up in the
graph. Much easier to spot failures
* hide legends of replicas that have never been shar
[
https://issues.apache.org/jira/browse/SOLR-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329217#comment-17329217
]
Mike Drob commented on SOLR-15146:
--
[~ilan] - I ran git bisect and identified the latest
HoustonPutman opened a new pull request #262:
URL: https://github.com/apache/solr-operator/pull/262
- Ability to not use the Zookeeper Operator in the Solr Operator Helm Chart
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
dsmiley merged pull request #52:
URL: https://github.com/apache/solr/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contac
[
https://issues.apache.org/jira/browse/SOLR-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329251#comment-17329251
]
ASF subversion and git services commented on SOLR-15283:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-15283.
-
Resolution: Fixed
> Remove Solr trace sampling; let Tracer configuration/impl decide
> --
[
https://issues.apache.org/jira/browse/SOLR-15157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329258#comment-17329258
]
David Smiley commented on SOLR-15157:
-
Is this issue still open for some reason?
> R
HoustonPutman commented on issue #259:
URL: https://github.com/apache/solr-operator/issues/259#issuecomment-824999599
Agreed. This is a good feature that should be included in v0.4.0.
We should expose all options for the Zookeeper storage, but default to
`ephemeral`/`persistent` depe
HoustonPutman commented on issue #261:
URL: https://github.com/apache/solr-operator/issues/261#issuecomment-825007921
I just tried running this on my Mac after pulling the latest `main`.
```
docker buildx build --platform "linux/s390x" --build-arg GIT_SHA=6f26747 .
--tag solr-oper
cpoerschke commented on a change in pull request #78:
URL: https://github.com/apache/solr/pull/78#discussion_r618591504
##
File path:
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java
##
@@ -236,6 +240,21 @@ public void prepare(ResponseBuilder rb) throws
[
https://issues.apache.org/jira/browse/SOLR-15311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329304#comment-17329304
]
Christine Poerschke commented on SOLR-15311:
ticket linking via comment:
* t
[
https://issues.apache.org/jira/browse/SOLR-14341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329306#comment-17329306
]
Christine Poerschke commented on SOLR-14341:
ticket linking via comment:
* th
thomaswoeckinger opened a new issue #263:
URL: https://github.com/apache/solr-operator/issues/263
Creating following cluster:
```
apiVersion: solr.apache.org/v1beta1
kind: SolrCloud
metadata:
name: solr-cloud
spec:
replicas: 3
solrImage:
tag: 8.6.3
[
https://issues.apache.org/jira/browse/SOLR-15363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved SOLR-15363.
--
Fix Version/s: main (9.0)
Resolution: Fixed
> Add CompletableFuture#runAsync(Runnable) to forbid
HoustonPutman commented on issue #263:
URL: https://github.com/apache/solr-operator/issues/263#issuecomment-825076528
This RBAC rule is necessary when a particular setting is turned on in the
admission controller. But we should definitely include it by default.
The verb only needs to
madrob closed pull request #67:
URL: https://github.com/apache/solr/pull/67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
[
https://issues.apache.org/jira/browse/SOLR-15329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329374#comment-17329374
]
ASF subversion and git services commented on SOLR-15329:
Commit 9
[
https://issues.apache.org/jira/browse/SOLR-15329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved SOLR-15329.
--
Fix Version/s: main (9.0)
Assignee: Mike Drob
Resolution: Fixed
Thanks for the patch, I
gerlowskija commented on pull request #41:
URL: https://github.com/apache/solr/pull/41#issuecomment-825135620
I rm'd the stuff that looked redundant to me, so I'm fine w/ merging
whenever at this point. I'll leave it open for the weekend to let you do the
honors, or in case you want to ma
gerlowskija edited a comment on pull request #41:
URL: https://github.com/apache/solr/pull/41#issuecomment-825135620
I rm'd the stuff that looked redundant to me, so I'm fine w/ merging
whenever at this point. I'll leave it open for the weekend to let you do the
honors, or in case you wan
Mike Drob created SOLR-15366:
Summary: SaslZkACLProviderTest.testSaslZkACLProvider fails
Key: SOLR-15366
URL: https://issues.apache.org/jira/browse/SOLR-15366
Project: Solr
Issue Type: Test
madrob opened a new pull request #89:
URL: https://github.com/apache/solr/pull/89
cherry-picked from apache/lucene#100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
[
https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob reopened SOLR-15361:
--
This causes some failures up on Jenkins - maybe we need to disable the task if
{{signatory.keyId}} is not
[
https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329407#comment-17329407
]
Mike Drob edited comment on SOLR-15361 at 4/22/21, 8:38 PM:
T
[
https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329415#comment-17329415
]
David Eric Pugh commented on SOLR-15361:
I wanted to share that I'm seeing a fail
[
https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329416#comment-17329416
]
Dawid Weiss commented on SOLR-15361:
It's weird this task runs on jenkins? Does it at
[
https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329453#comment-17329453
]
Chris M. Hostetter commented on SOLR-15361:
---
it should not be attaching to asse
[
https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329455#comment-17329455
]
Chris M. Hostetter commented on SOLR-15361:
---
and to clarify: i specifically did
[
https://issues.apache.org/jira/browse/SOLR-15366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329459#comment-17329459
]
ASF subversion and git services commented on SOLR-15366:
Commit 2
[
https://issues.apache.org/jira/browse/SOLR-15334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329464#comment-17329464
]
Mike Drob commented on SOLR-15334:
--
https://jenkins.thetaphi.de/view/Solr/job/Solr-main-
[
https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329468#comment-17329468
]
Chris M. Hostetter commented on SOLR-15361:
---
bq. it should not be attaching to
[
https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329470#comment-17329470
]
ASF subversion and git services commented on SOLR-15361:
Commit 6
dsmiley commented on pull request #74:
URL: https://github.com/apache/solr/pull/74#issuecomment-825355375
I think like Houston, I would prefer to see a bin/somethingelse instead of
bin/solr on principle because this is not starting solr, this is
starting/installing Zeppelin. On this point
David Smiley created SOLR-15367:
---
Summary: Convert "rid" functionality into a default Tracer
Key: SOLR-15367
URL: https://issues.apache.org/jira/browse/SOLR-15367
Project: Solr
Issue Type: Impr
[
https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated SOLR-15361:
--
Status: Reopened (was: Reopened)
Ok, let's try this again ... as noted in a comment in
[
https://issues.apache.org/jira/browse/SOLR-15367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329953#comment-17329953
]
David Smiley commented on SOLR-15367:
-
"rid" supports a user-specified parameter of "
[
https://issues.apache.org/jira/browse/SOLR-15367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley reassigned SOLR-15367:
---
Assignee: David Smiley
> Convert "rid" functionality into a default Tracer
> ---
[
https://issues.apache.org/jira/browse/SOLR-15367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329957#comment-17329957
]
David Smiley commented on SOLR-15367:
-
There's also a case to be made for just doing
60 matches
Mail list logo