cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r2263827463
##
solr/core/src/test/org/apache/solr/update/SolrIndexConfigTest.java:
##
@@ -118,7 +118,7 @@ public void testTieredMPSolrIndexConfigCreation() throws
Exception {
cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r2263751291
##
solr/core/src/test/org/apache/solr/update/SolrIndexConfigTest.java:
##
@@ -118,7 +118,7 @@ public void testTieredMPSolrIndexConfigCreation() throws
Exception {
cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r2263727856
##
solr/core/src/java/org/apache/solr/request/DocValuesStats.java:
##
@@ -222,7 +222,9 @@ static int accumMulti(
}
if (doc == si.docID()) {
long
cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r2263724040
##
solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java:
##
@@ -112,14 +113,20 @@ public static LeafReader wrap(IndexReader reader) throws
IOExcept
cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r2263687415
##
solr/core/src/java/org/apache/solr/servlet/SolrRequestParsers.java:
##
@@ -736,7 +736,9 @@ public SolrParams parseParamsAndFillStreams(
// Protect container
cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r2263628875
##
solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java:
##
@@ -97,7 +97,7 @@ public void init(NamedList args) {
log.debug("Using default compressionM
cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r2263569503
##
gradle/libs.versions.toml:
##
@@ -37,8 +37,8 @@ apache-httpcomponents-httpcore = "4.4.16"
apache-httpcomponents-httpmime = "4.5.14"
apache-kafka = "3.9.0"
apache-
chatman commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r2261261170
##
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java:
##
@@ -22,7 +22,7 @@
import java.io.UncheckedIOException;
import org.apache.luc
chatman commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-3165435262
> I'm only "blaming" you for not following a best practice (twice now) on
big/important PRs. Nothing more. If neither broke things I wouldn't be happy
but probably wouldn't have said anythin
dsmiley commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-3165355972
I'm only "blaming" you for not following a best practice (twice now) on
big/important PRs. Nothing more. If neither broke things I wouldn't be happy
but probably wouldn't have said anythin
chatman commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-3165302672
> But I've got to say, it's premature to merge a PR without either first
seeking and getting another approval or to state your intention to merge in 48
hours. This isn't a triival PR (of
chatman commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-3165249702
> The same thing happened with the multiThreaded PR, which didn't turn
out well, as you know.
I've opened up an issue to fix it:
https://issues.apache.org/jira/browse/SOLR-17841
chatman commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-3165232514
> But I've got to say, it's premature to merge a PR without either first
seeking and getting another approval or to state your intention to merge in 48
hours. This isn't a triival PR (of cou
chatman commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-3165201252
> Is the test you are talking about the:
ltr_expensiveFeatureRescoring_shouldTimeOutAndReturnPartialResults?
@aruggero yes. Apologies, since that was added by @alessandrobenedetti and
dsmiley commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-3165198787
Thanks so much Ishan & others! I mean that super sincerely...
But I've got other say, it's premature to merge a PR without either first
seeking and getting another approval or to sta
aruggero commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-3164910752
Hi Ishan,
Is the test you are talking about the:
ltr_expensiveFeatureRescoring_shouldTimeOutAndReturnPartialResults?
--
This is an automated message from the Apache Git Service.
To
chatman commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-3164889160
I think I deleted some .lockfiles inadvertently. I'm working on fixing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
chatman commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-3164836927
> [Solr Script Tests / Run Solr Script Tests
(pull_request)](https://github.com/apache/solr/actions/runs/16809084447/job/47609370778?pr=3053)Started
Aug 7, 2025 — This check has started...
chatman commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-3164842798
Thank you to everyone for help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
asf-gitbox-commits merged PR #3053:
URL: https://github.com/apache/solr/pull/3053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@sol
chatman commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-3164575932
I have rebased all the changes on current main, tried to compose them into
relatively separate changes instead of lumping them into a single commit.
However, still, the first commit contains
chatman commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-3163251538
I was so focused on Solr core test failures that I totally forgot about the
rest. Now that I have a handle on the core tests (I'll push the changes here
shortly), I discovered the following
chatman commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-3156889838
The grouping implementation was only using filter queries for search
ignoring the main query entirely. This caused function queries like
{\!func}foo2_i to be ignored during grouping, resulti
liangkaiwen commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-3155495144
Hello, also would like to help pitch in. My guess is the best thing we
should do to parallelize/coordinate is to pick one of the remaining failing
tests and announce that here?
--
Thi
ilariapet commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-3135621541
Hello. Has anyone planned to resume work on this anytime soon? Planning to
help, but I don't want to step on anybody's toes.
--
This is an automated message from the Apache Git Service.
chatman commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-2981826918
@HoustonPutman @antonmry I've updated to Lucene 10.2.1 based on @dsmiley's
suggestion. However, now I see some compiler errors for LTRScoringQuery.java,
which I suppose was not there a while
bruno-roustant commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-2903926088
Fyi @antogruz and I are going to help on this PR. We'll first review and
then propose new commits to fix tests.
--
This is an automated message from the Apache Git Service.
To respo
chatman commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-2866359248
Just ran the tests on this branch and saw these failures:
```
TestSnapshotCoreBackup
TestFiltering
PreAnalyzedUpdateProcessorTest
PathHierarchyTokenizerFactoryTest
Distribute
gerlowskija commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-2836309092
Ran out of time to move this forward, so others should feel free to pick
this up without fear of duplicating work, etc.
--
This is an automated message from the Apache Git Service.
To
gerlowskija commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-2816864402
Alright, I've merged in the latest main and tackled a few test failures.
Here are the remaining failures as a check-box list that we can update as we
progress:
- [ ] org.apache.s
gerlowskija commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r2050996506
##
solr/core/src/test/org/apache/solr/legacy/TestMultiValuedNumericRangeQuery.java:
##
@@ -79,16 +76,16 @@ public void testMultiValuedNRQ() throws Exception {
gerlowskija commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r2050966911
##
solr/core/src/java/org/apache/solr/search/grouping/distributed/responseprocessor/TopGroupsShardResponseProcessor.java:
##
@@ -233,7 +233,7 @@ static void fillResult
gerlowskija commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r2050864362
##
solr/core/src/java/org/apache/solr/search/DocSetQuery.java:
##
@@ -80,12 +73,12 @@ public Weight createWeight(IndexSearcher searcher,
ScoreMode scoreMode, float bo
gerlowskija commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r2050834136
##
solr/core/src/java/org/apache/solr/search/ExtendedDismaxQParser.java:
##
@@ -1240,9 +1240,9 @@ && allSameQueryStructure(lst)) {
BooleanQuery bool
gerlowskija commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r2050646974
##
solr/core/src/java/org/apache/solr/core/MMapDirectoryFactory.java:
##
@@ -66,7 +65,7 @@ public void init(NamedList args) {
protected Directory create(String path
epugh commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-2676871185
Looking forward to this landing. I was just looking at upgrading OpenNLP
and seeing that it requires Lucene 10...
--
This is an automated message from the Apache Git Service.
To respond to
janhoy commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-2676269144
@chatman review feedback waiting :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r1941767347
##
solr/core/src/java/org/apache/solr/search/Grouping.java:
##
@@ -603,7 +566,7 @@ protected Integer getNumberOfGroups() {
protected void populateScoresIfNecessary
cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r1937402513
##
solr/modules/ltr/src/test/org/apache/solr/ltr/TestLTRReRankingPipeline.java:
##
@@ -145,8 +145,8 @@ public void testRescorer() throws Exception {
hits = resco
cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r1928902341
##
solr/core/src/test/org/apache/solr/search/RankQueryTestPlugin.java:
##
@@ -476,7 +476,6 @@ private static class ScoreAndDoc extends Scorable {
this.score =
cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r1928852796
##
solr/core/src/java/org/apache/solr/search/CollapsingQParserPlugin.java:
##
@@ -582,7 +572,6 @@ public float score() {
return score;
}
-@Override
cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r1928384222
##
solr/core/src/java/org/apache/solr/core/backup/repository/BackupRepository.java:
##
@@ -216,7 +216,7 @@ default void copyIndexFileFrom(
Directory sourceDir, S
cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r1928419378
##
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java:
##
@@ -22,7 +22,7 @@
import java.io.UncheckedIOException;
import org.apache.
cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r1928398006
##
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java:
##
@@ -1755,7 +1755,6 @@ protected static class ScoreAndDoc extends Scorable {
this.
chatman commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-2610037402
List of failing tests now:
```TestReversedWildcardFilterFactory
TestGroupingSearch
TestJoin
PathHierarchyTokenizerFactoryTest
BasicFunctionalityTest
TestDistributedGrouping
chatman commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-2607786041
Now, here's the list of failing tests:
```TestRandomDVFaceting
TestReversedWildcardFilterFactory
TestGroupingSearch
BasicFunctionalityTest
TestDistributedGrouping
TestDis
chatman commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-2607539742
I dealt with the removal of SortedSetDocValues.NO_MORE_ORDS [0] inaccurately
in the PR. Will fix now.
[0] - https://github.com/apache/lucene/pull/969
--
This is an automated message
47 matches
Mail list logo
