cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r1941767347
##########
solr/core/src/java/org/apache/solr/search/Grouping.java:
##########
@@ -603,7 +566,7 @@ protected Integer getNumberOfGroups() {
protected void populateScoresIfNecessary() throws IOException {
if (needScores) {
for (GroupDocs<?> groups : result.groups) {
- TopFieldCollector.populateScores(groups.scoreDocs, searcher, query);
+ TopFieldCollector.populateScores(groups.scoreDocs(), searcher,
query);
Review Comment:
Just leaving a note here from investigating the grouping-related test
failures, the filling in of the scores here does not influence the `maxScore`
of a group and that seems to be wrong (always 1 possibly?) and so the groups
are ordered wrongly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
