psalagnac merged PR #3036:
URL: https://github.com/apache/solr/pull/3036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
psalagnac commented on PR #3036:
URL: https://github.com/apache/solr/pull/3036#issuecomment-2596891316
> ZkStateReader.waitForState has the wait unit params immediately after the
collection name. I think the new waitForState you added should be consistent.
Keeping the functional arg at the
psalagnac commented on code in PR #3036:
URL: https://github.com/apache/solr/pull/3036#discussion_r191871
##
solr/solrj/src/test/org/apache/solr/common/cloud/PerReplicaStatesIntegrationTest.java:
##
@@ -245,50 +245,42 @@ public void testMultipleTransitions() throws Exception
psalagnac commented on code in PR #3036:
URL: https://github.com/apache/solr/pull/3036#discussion_r1918216036
##
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##
@@ -207,6 +210,47 @@ protected static void waitForState(
}
}
+ /**
+ * Wait
dsmiley commented on code in PR #3036:
URL: https://github.com/apache/solr/pull/3036#discussion_r1917836970
##
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##
@@ -207,6 +210,47 @@ protected static void waitForState(
}
}
+ /**
+ * Wait f
