Re: [PR] SOLR-16903: Make java.io.File a forbidden API [solr]

2025-05-22 Thread via GitHub
mlbiscoc merged PR #3321: URL: https://github.com/apache/solr/pull/3321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o

Re: [PR] SOLR-16903: Make java.io.File a forbidden API [solr]

2025-05-22 Thread via GitHub
mlbiscoc commented on PR #3321: URL: https://github.com/apache/solr/pull/3321#issuecomment-2901480369 > Ready to merge; right? GHA seemed to have issues on the precommit but maybe was temporary Yep ready ready to merge and we can finally end this jira. All checks and precommits pass

Re: [PR] SOLR-16903: Make java.io.File a forbidden API [solr]

2025-05-20 Thread via GitHub
dsmiley commented on PR #3321: URL: https://github.com/apache/solr/pull/3321#issuecomment-2896441891 Ready to merge; right? GHA seemed to have issues on the precommit but maybe was temporary -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] SOLR-16903: Make java.io.File a forbidden API [solr]

2025-04-16 Thread via GitHub
mlbiscoc commented on code in PR #3321: URL: https://github.com/apache/solr/pull/3321#discussion_r2046935800 ## solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginIntegrationTest.java: ## @@ -104,9 +105,7 @@ public static void beforeClass() throws Exception

Re: [PR] SOLR-16903: Make java.io.File a forbidden API [solr]

2025-04-15 Thread via GitHub
dsmiley commented on code in PR #3321: URL: https://github.com/apache/solr/pull/3321#discussion_r2045357256 ## solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginIntegrationTest.java: ## @@ -104,9 +104,7 @@ public static void beforeClass() throws Exception

Re: [PR] SOLR-16903: Make java.io.File a forbidden API [solr]

2025-04-15 Thread via GitHub
mlbiscoc commented on PR #3321: URL: https://github.com/apache/solr/pull/3321#issuecomment-2807239066 ``` JWTAuthPluginIntegrationTest > classMethod FAILED java.nio.file.ProviderMismatchException: mismatch, expected: FilterPath, got: class sun.nio.fs.UnixPath ``` Looks like w

Re: [PR] SOLR-16903: Make java.io.File a forbidden API [solr]

2025-04-15 Thread via GitHub
mlbiscoc commented on PR #3321: URL: https://github.com/apache/solr/pull/3321#issuecomment-2805065630 Moved to `createTempDir`. Also think moving to `createTempDir` fixed that error that bubbled up from the previous precommit run. -- This is an automated message from the Apache Git Servic

Re: [PR] SOLR-16903: Make java.io.File a forbidden API [solr]

2025-04-12 Thread via GitHub
dsmiley commented on code in PR #3321: URL: https://github.com/apache/solr/pull/3321#discussion_r2040723746 ## solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginIntegrationTest.java: ## @@ -105,8 +106,7 @@ public static void beforeClass() throws Exception