dsmiley commented on code in PR #3289:
URL: https://github.com/apache/solr/pull/3289#discussion_r2240982786
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkMaintenanceUtils.java:
##
Review Comment:
The use of `Path.of` in `uploadToZK` file is an absolute tra
mlbiscoc commented on PR #3289:
URL: https://github.com/apache/solr/pull/3289#issuecomment-2759056846
Cool! Yeah we are going to be stepping on each other toes here... My PR just
had a merge conflict which I need to fix. Going to fix it today or tomorrow and
hopefully we can merge it soon.
dsmiley merged PR #3289:
URL: https://github.com/apache/solr/pull/3289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on code in PR #3289:
URL: https://github.com/apache/solr/pull/3289#discussion_r2017601578
##
solr/test-framework/src/test/org/apache/solr/cloud/MiniSolrCloudClusterTest.java:
##
@@ -119,8 +118,8 @@ public void testSolrHomeAndResourceLoaders() throws
Exception
AndreyBozhko commented on code in PR #3289:
URL: https://github.com/apache/solr/pull/3289#discussion_r2017597484
##
solr/test-framework/src/test/org/apache/solr/cloud/MiniSolrCloudClusterTest.java:
##
@@ -119,8 +118,8 @@ public void testSolrHomeAndResourceLoaders() throws
Excep
AndreyBozhko commented on PR #3289:
URL: https://github.com/apache/solr/pull/3289#issuecomment-2759464340
Thanks - I agree that it makes total sense to wait with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dsmiley commented on code in PR #3289:
URL: https://github.com/apache/solr/pull/3289#discussion_r2016848377
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -147,12 +146,11 @@ public String lookupZKManagedSchemaPath() {
*/
public Path loo
epugh commented on code in PR #3289:
URL: https://github.com/apache/solr/pull/3289#discussion_r2014483983
##
solr/core/src/java/org/apache/solr/cli/ConfigSetDownloadTool.java:
##
@@ -81,11 +80,11 @@ public void runImpl(CommandLine cli) throws Exception {
echoIfVerbose("\n
