dsmiley commented on code in PR #3289:
URL: https://github.com/apache/solr/pull/3289#discussion_r2017601578
##########
solr/test-framework/src/test/org/apache/solr/cloud/MiniSolrCloudClusterTest.java:
##########
@@ -119,8 +118,8 @@ public void testSolrHomeAndResourceLoaders() throws
Exception {
System.setProperty(SOLR_HOME_PROP, fakeSolrHome);
// mock FS from createTempDir don't play nice using 'startsWith' when the
solr stack
- // reconsistutes the path from string so we have to go the string route
here as well...
- final Path workDir =
Paths.get(createTempDir().toAbsolutePath().toString());
+ // reconstitutes the path from string so we have to go the string route
here as well...
+ final Path workDir = Path.of(createTempDir().toAbsolutePath().toString());
Review Comment:
Oh right (and "duh" on me for not reading the comment :shame:).
In the other PR, I like the different approach we're taking of unwrapping
the custom Path, which is more plainly apparent and also searchable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
